From 9e6f116bc978eb3149dca01800f0f42323bb7b69 Mon Sep 17 00:00:00 2001 From: reemuru Date: Thu, 21 Jul 2022 11:55:32 -0400 Subject: [PATCH] TxUtils: don't show resolve for float Add parseFloat() checks so that the 'Resolve' button for OpenAlias remains hidden. Also add a length check for one character with a dot. IP addresses will not be respected, but the whole point of domain names and OA is for facilitating human readable / user friendly information. Co-authored-by: selsta --- js/TxUtils.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/js/TxUtils.js b/js/TxUtils.js index de79b625..49b0c34e 100644 --- a/js/TxUtils.js +++ b/js/TxUtils.js @@ -71,9 +71,8 @@ function checkSignature(signature) { function isValidOpenAliasAddress(address) { address = address.trim() - var dot = address.indexOf('.') - if (dot < 0) - return false // we can get an awful lot of valid domains, including non ASCII chars... accept anything - return true + // there should be something after the . + // make sure it is not some kind of floating number + return address.length > 2 && isNaN(parseFloat(address)) && address.indexOf('.') >= 0 }