4rkal/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-14 12:26:31 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #3408

Browse Source 
e1b526b3 Remove the `Blockchain::get_all_known_block_ids` function. (Jean Pierre Dudey)
This commit is contained in:
Riccardo Spagni 2018-03-15 17:09:13 +02:00
commit 60af9d689b
No known key found for this signature in database
GPG Key ID: 55432DF31CCD4FCD
2 changed files with 0 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/cryptonote_core/blockchain.cpp
View File

@ -744,25 +744,6 @@ bool Blockchain::get_block_by_hash(const crypto::hash &h, block &blk, bool *orph
return false;
}
//------------------------------------------------------------------
//FIXME: this function does not seem to be called from anywhere, but
// if it ever is, should probably change std::list for std::vector
void Blockchain::get_all_known_block_ids(std::list<crypto::hash> &main, std::list<crypto::hash> &alt, std::list<crypto::hash> &invalid) const
{
LOG_PRINT_L3("Blockchain::" << __func__);
CRITICAL_REGION_LOCAL(m_blockchain_lock);
for (auto& a : m_db->get_hashes_range(0, m_db->height() - 1))
{
main.push_back(a);
}
for (const blocks_ext_by_hash::value_type &v: m_alternative_chains)
alt.push_back(v.first);
for (const blocks_ext_by_hash::value_type &v: m_invalid_blocks)
invalid.push_back(v.first);
}
//------------------------------------------------------------------
// This function aggregates the cumulative difficulties and timestamps of the
// last DIFFICULTY_BLOCKS_COUNT blocks and passes them to next_difficulty,
// returning the result of that call. Ignores the genesis block, and can use

9
src/cryptonote_core/blockchain.h
View File

@ -206,15 +206,6 @@ namespace cryptonote
*/
bool get_block_by_hash(const crypto::hash &h, block &blk, bool *orphan = NULL) const;
/**
* @brief get all block hashes (main chain, alt chains, and invalid blocks)
*
* @param main return-by-reference container to put result main chain blocks' hashes in
* @param alt return-by-reference container to put result alt chain blocks' hashes in
* @param invalid return-by-reference container to put result invalid blocks' hashes in
*/
void get_all_known_block_ids(std::list<crypto::hash> &main, std::list<crypto::hash> &alt, std::list<crypto::hash> &invalid) const;
/**
* @brief performs some preprocessing on a group of incoming blocks to speed up verification
*