4rkal/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-14 04:16:32 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added some //TODO comments pertaining to returning enums instead of bools in order to be better able to handle failure states.

Browse Source
This commit is contained in:
Dion Ahmetaj 2017-02-02 12:34:51 -05:00 committed by Dion Ahmetaj
parent 0b1045ed7d
commit 68652cd94d
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/cryptonote_basic/miner.cpp
View File

@ -798,5 +798,10 @@ namespace cryptonote
LOG_ERROR(__func__ << " : couldn't query power status"); LOG_ERROR(__func__ << " : couldn't query power status");
return false; // shouldn't get here unless no support for querying battery status return false; // shouldn't get here unless no support for querying battery status
// TODO: return enum with ability to signify failure in querying for power status
// and change bg-mining logic so that it stops. As @vtnerd states, with the current
// setup "If someone enabled background mining on a system that fails to grab ac
// status, it will just continually check with little hope of ever being resolved
// automagically". This is also the case for time/idle stats functions.
} }
} }