4rkal/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-14 12:26:31 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed

Browse Source 
Followup on #4653
This commit is contained in:
stoffu 2018-11-05 12:13:15 +09:00
parent 7e2483e1d5
commit 7ae36e91f6
No known key found for this signature in database
GPG Key ID: 41DAB8343A9EC012
1 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/wallet/wallet_rpc_server.cpp
View File

@ -1742,12 +1742,43 @@ namespace tools
if (req.key_type.compare("mnemonic") == 0) if (req.key_type.compare("mnemonic") == 0)
{ {
epee::wipeable_string seed; epee::wipeable_string seed;
if (!m_wallet->get_seed(seed)) bool ready;
if (m_wallet->multisig(&ready))
{
if (!ready)
{
er.code = WALLET_RPC_ERROR_CODE_NOT_MULTISIG;
er.message = "This wallet is multisig, but not yet finalized";
return false;
}
if (!m_wallet->get_multisig_seed(seed))
{
er.code = WALLET_RPC_ERROR_CODE_UNKNOWN_ERROR;
er.message = "Failed to get multisig seed.";
return false;
}
}
else
{
if (m_wallet->watch_only())
{
er.code = WALLET_RPC_ERROR_CODE_WATCH_ONLY;
er.message = "The wallet is watch-only. Cannot display seed.";
return false;
}
if (!m_wallet->is_deterministic())
{ {
er.code = WALLET_RPC_ERROR_CODE_NON_DETERMINISTIC; er.code = WALLET_RPC_ERROR_CODE_NON_DETERMINISTIC;
er.message = "The wallet is non-deterministic. Cannot display seed."; er.message = "The wallet is non-deterministic. Cannot display seed.";
return false; return false;
} }
if (!m_wallet->get_seed(seed))
{
er.code = WALLET_RPC_ERROR_CODE_UNKNOWN_ERROR;
er.message = "Failed to get seed.";
return false;
}
}
res.key = std::string(seed.data(), seed.size()); // send to the network, then wipe RAM :D res.key = std::string(seed.data(), seed.size()); // send to the network, then wipe RAM :D
} }
else if(req.key_type.compare("view_key") == 0) else if(req.key_type.compare("view_key") == 0)