From ac9a8978cab3fe89d0a60b72f53d46ea5b9f751f Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Tue, 7 Feb 2023 12:12:02 +0000 Subject: [PATCH] Revert "epee: when loading a JSON RPC payload, ensure params is an object" This reverts commit b67e931843cd0c8191ec49f80448c010cba39901. This turns out to be a bad idea, because we do have weird RPC which do actually go counter to this --- contrib/epee/include/net/http_server_handlers_map2.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/contrib/epee/include/net/http_server_handlers_map2.h b/contrib/epee/include/net/http_server_handlers_map2.h index 00967b2da..848b8ffc4 100644 --- a/contrib/epee/include/net/http_server_handlers_map2.h +++ b/contrib/epee/include/net/http_server_handlers_map2.h @@ -152,16 +152,6 @@ epee::serialization::store_t_to_json(static_cast(rsp), response_info.m_body); \ return true; \ } \ - epee::serialization::storage_entry se; \ - if(ps.get_value("params", se, nullptr) && se.type() != typeid(epee::serialization::section)) \ - { \ - boost::value_initialized rsp; \ - static_cast(rsp).jsonrpc = "2.0"; \ - static_cast(rsp).error.code = -32701; \ - static_cast(rsp).error.message = "Params is not an object"; \ - epee::serialization::store_t_to_json(static_cast(rsp), response_info.m_body); \ - return true; \ - } \ epee::serialization::storage_entry id_; \ id_ = epee::serialization::storage_entry(std::string()); \ ps.get_value("id", id_, nullptr); \