4rkal/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-13 11:56:31 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

blockchain_db: initialize m_open in base class ctor

Browse Source 
It's cleaner this way, since it's a base class field

Coverity 136568
This commit is contained in:
moneromooo-monero 2018-02-02 15:21:39 +00:00
parent bece67f9e8
commit ad11db9144
No known key found for this signature in database
GPG Key ID: 686F07454D6CEFC3
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/blockchain_db/berkeleydb/db_bdb.cpp
View File

@ -770,13 +770,13 @@ BlockchainBDB::~BlockchainBDB()
}
BlockchainBDB::BlockchainBDB(bool batch_transactions) :
BlockchainDB(),
m_buffer(DB_BUFFER_COUNT, DB_BUFFER_LENGTH)
{
LOG_PRINT_L3("BlockchainBDB::" << __func__);
// initialize folder to something "safe" just in case
// someone accidentally misuses this class...
m_folder = "thishsouldnotexistbecauseitisgibberish";
m_open = false;
m_run_checkpoint = 0;
m_batch_transactions = batch_transactions;
m_write_txn = nullptr;

5
src/blockchain_db/blockchain_db.h
View File

@ -537,6 +537,11 @@ protected:
public:
/**
* @brief An empty constructor.
*/
BlockchainDB(): m_open(false) { }
/**
* @brief An empty destructor.
*/

3
src/blockchain_db/lmdb/db_lmdb.cpp
View File

@ -1074,13 +1074,12 @@ BlockchainLMDB::~BlockchainLMDB()
close();
}
BlockchainLMDB::BlockchainLMDB(bool batch_transactions)
BlockchainLMDB::BlockchainLMDB(bool batch_transactions): BlockchainDB()
{
LOG_PRINT_L3("BlockchainLMDB::" << __func__);
// initialize folder to something "safe" just in case
// someone accidentally misuses this class...
m_folder = "thishsouldnotexistbecauseitisgibberish";
m_open = false;
m_batch_transactions = batch_transactions;
m_write_txn = nullptr;