mirror of
https://github.com/monero-project/monero.git
synced 2024-12-13 20:06:32 +02:00
BlockchainBDB: When removing, find amount output index fast by starting at end
This improves blockchain reorganization time by allowing one of the more
expensive DB lookups when popping a block to not have to seek through a
long dup list in the "output_amounts" db. This is most noticeable for
HDDs.
See ffcf6bdb95
This commit is contained in:
parent
1a5c3fa729
commit
b8707466e2
@ -514,20 +514,43 @@ void BlockchainBDB::remove_amount_output_index(const uint64_t amount, const uint
|
||||
db_recno_t num_elems = 0;
|
||||
cur->count(&num_elems, 0);
|
||||
|
||||
// workaround for Berkeley DB to start at end of k's duplicate list:
|
||||
// if next key exists:
|
||||
// - move cursor to start of next key's duplicate list, then move back one
|
||||
// duplicate element to reach the end of the original key's duplicate
|
||||
// list.
|
||||
//
|
||||
// else if the next key doesn't exist:
|
||||
// - that means we're already on the last key.
|
||||
// - move cursor to last element in the db, which is the last element of
|
||||
// the desired key's duplicate list.
|
||||
|
||||
result = cur->get(&k, &v, DB_NEXT_NODUP);
|
||||
if (result != 0 && result != DB_NOTFOUND)
|
||||
throw0(DB_ERROR("DB error attempting to get next non-duplicate output amount"));
|
||||
|
||||
if (result == 0)
|
||||
result = cur->get(&k, &v, DB_PREV);
|
||||
else if (result == DB_NOTFOUND)
|
||||
result = cur->get(&k, &v, DB_LAST);
|
||||
|
||||
bool found_index = false;
|
||||
uint64_t amount_output_index = 0;
|
||||
uint64_t goi = 0;
|
||||
bool found_index = false;
|
||||
for (uint64_t i = 0; i < num_elems; ++i)
|
||||
|
||||
for (uint64_t i = num_elems; i > 0; --i)
|
||||
{
|
||||
goi = v;
|
||||
if (goi == global_output_index)
|
||||
{
|
||||
amount_output_index = i;
|
||||
amount_output_index = i-1;
|
||||
found_index = true;
|
||||
break;
|
||||
}
|
||||
cur->get(&k, &v, DB_NEXT_DUP);
|
||||
if (i > 1)
|
||||
cur->get(&k, &v, DB_PREV_DUP);
|
||||
}
|
||||
|
||||
if (found_index)
|
||||
{
|
||||
// found the amount output index
|
||||
|
Loading…
Reference in New Issue
Block a user