Riccardo Spagni
148d14164e
Merge pull request #4615
...
a7960542
2018-10-26 22:38:41 +02:00
Riccardo Spagni
c761bee764
Merge pull request #4561
...
04ddf02e
2018-10-26 22:33:35 +02:00
Riccardo Spagni
169e6e9074
Merge pull request #4552
...
67e76aa0
2018-10-26 22:32:34 +02:00
Riccardo Spagni
659cf52a61
Merge pull request #4539
...
977fc1bc
2018-10-26 22:20:57 +02:00
moneromooo-monero
1f35de2300
simplewallet: display locked/unlocked state in show_transfers
...
it doesn't display the details, which are already displayed
in show_transfer
2018-10-25 23:02:42 +00:00
Lee Clagett
6097472a19
Update ZMQ fee estimate and add ZMQ output distribution
2018-10-23 23:46:31 -04:00
moneromooo-monero
61f83316b3
wallet2: extend fake out picks away from the gamma pick
...
in order to unbias selection from blocks with few txes
2018-10-23 09:06:47 +00:00
Paul Shapiro
70877b1d91
wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc
2018-10-22 18:51:45 -05:00
moneromooo-monero
7f0dd094e7
wallet2: sanity check rct output distribution from the daemon
2018-10-22 14:01:46 +00:00
Paul Shapiro
76681b9bda
wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args
2018-10-21 12:44:22 -05:00
Paul Shapiro
cf646e3afe
wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr
2018-10-21 12:43:31 -05:00
Riccardo Spagni
ed4b953bb7
Merge pull request #4518
...
92a0827e
2018-10-20 20:39:36 +02:00
Michał Sałaban
ade369f96f
Add RPC error code for non-deterministic wallet
2018-10-18 23:14:06 +02:00
moneromooo-monero
99cd6f961a
Rename "blackball" for clarity
...
Apparently some people seem to think it's a censorship list...
2018-10-18 18:45:45 +00:00
Riccardo Spagni
c5be5ca6b4
Merge pull request #4623
...
99d45a95
2018-10-16 18:23:30 +02:00
moneromooo-monero
99d45a9578
wallet_rpc_server: fix change_wallet_password RPC
2018-10-16 15:19:05 +00:00
moneromooo-monero
0cdd4b074e
wallet2_api: fix generating new wallet in the GUI
...
It was creating a new wallet without a password first (this should
be fixed), then not changing the password correctly
2018-10-16 14:46:17 +00:00
moneromooo-monero
3212378912
wallet2: initialize some scalar fields in ctor where appropriate
...
Coverity 188336
2018-10-16 11:58:48 +00:00
mmitkevich
a7960542a9
WalletAPI: rescanBlockchain, rescanBlockchainAsync
2018-10-16 14:58:22 +03:00
Riccardo Spagni
544413de8f
Merge pull request #4577
...
d886b97f
2018-10-15 13:31:29 +02:00
m2049r
d886b97fe2
SOFTWARE is the default wallet device
2018-10-13 09:25:49 +02:00
moneromooo-monero
e736964a0c
Remove epee header dependency on cryptonote_core
2018-10-12 17:16:44 +00:00
Michał Sałaban
04ddf02e3a
Return appropriate RPC error code when key image signature check fails
2018-10-11 18:12:17 +02:00
moneromooo-monero
67e76aa06c
wallet_rpc_server: optionally return tx keys in sign_transfer
2018-10-10 15:55:35 +00:00
moneromooo-monero
92a0827eea
wallet2: make fake out selection messages less spammy
2018-10-09 21:46:33 +00:00
moneromooo-monero
8833aec083
wallet2: fix cold signing using non padded bulletproofs
...
This code was deciding which bulletproof configuration to use
based on ptx which weren't created yet.
2018-10-09 14:32:38 +00:00
moneromooo-monero
977fc1bceb
wallet_rpc_server: add describe_transfer RPC
...
for unsigned tx sets using a view only wallet
2018-10-09 10:47:32 +00:00
Riccardo Spagni
e19652df51
Merge pull request #4036
...
9acf42d39f3963e8
2018-10-07 19:57:26 +02:00
Guillaume LE VAILLANT
977df6315f
Fix some calls to the translation function
...
Some strings were not detected by lupdate because "tr() cannot be called without
context".
2018-10-06 10:26:06 +02:00
Riccardo Spagni
c9fc61dbb5
Merge pull request #4495
...
34a85e0c
2018-10-05 23:13:15 +02:00
moneromooo-monero
c5928bdec6
wallet2_api: fix build with C++14
2018-10-04 13:42:01 +00:00
moneromooo-monero
34a85e0cc3
wallet2: disable height based segregation
...
It can still be enable via DNS if a key reusing fork pops up
2018-10-03 20:44:48 +00:00
Riccardo Spagni
932a17018a
Merge pull request #4490
...
bccd88dd
2018-10-02 22:41:24 +02:00
Riccardo Spagni
6cb9c815d4
Merge pull request #4484
...
2c74b1a1
2018-10-02 22:40:51 +02:00
Riccardo Spagni
66094dee00
Merge pull request #4482
...
25e5890d
2018-10-02 22:39:57 +02:00
doy-lee
bccd88ddf5
wallet2: clear found out for every tx key
...
Avoids triggering the sanity check
2018-10-02 08:53:28 +00:00
naughtyfox
9f3963e823
Arbitrary M/N multisig schemes:
...
* support in wallet2
* support in monero-wallet-cli
* support in monero-wallet-rpc
* support in wallet api
* support in monero-gen-trusted-multisig
* unit tests for multisig wallets creation
2018-10-01 19:16:56 +03:00
moneromooo-monero
2c74b1a1c4
wallet_rpc_server: include all transfer records for a txid
...
Since subaddresses were added, a tx can now create more than
one payment
2018-10-01 14:47:26 +00:00
moneromooo-monero
25e5890d37
wallet: fix --generate-from-json using wrong password
2018-10-01 12:32:26 +00:00
moneromooo-monero
6da36ea057
wallet2_api: blackball/unblackball now take two parameters
...
amount and offset (instead of pubkey)
2018-09-30 08:10:30 +00:00
Riccardo Spagni
83d8f03c23
Merge pull request #4333
...
73403004
2018-09-29 22:20:44 +02:00
Riccardo Spagni
4a2664f743
Merge pull request #4461
...
7dd11711
2018-09-29 22:20:41 +02:00
Riccardo Spagni
effcbf2060
Merge pull request #4459
...
bcf3f6af3ebd05d4a093092e1eebb82bfb6a36302e2139ff0749a8bd1b0afeeb418a9936ea7f95436e85542253df2debe67016dd661439f45fdcda507ece1550a085da32d8b1ec8b02563bf4c57a65b2
2018-09-29 22:20:38 +02:00
Riccardo Spagni
9a54d0033e
Merge pull request #4458
...
921b0fb1
2018-09-29 22:20:35 +02:00
Riccardo Spagni
e951258543
Merge pull request #4456
...
06d05c21
2018-09-29 22:20:27 +02:00
Riccardo Spagni
54d883d826
Merge pull request #4427
...
83debef9
2018-09-29 22:19:58 +02:00
Riccardo Spagni
cd5638f894
Merge pull request #4417
...
a21da905
2018-09-29 22:19:40 +02:00
Riccardo Spagni
e4130e6ae6
Merge pull request #4409
...
7a056f44
2018-09-29 22:19:36 +02:00
Riccardo Spagni
402349760f
Merge pull request #4407
...
43a06350
2018-09-29 22:19:32 +02:00
Riccardo Spagni
ff0d7a7678
Merge pull request #4406
...
7964d4f8
2018-09-29 22:09:46 +02:00
Riccardo Spagni
f2eee1eb8c
Merge pull request #4438
...
e350cc5abf9a0f4c45683ee0
2018-09-25 13:33:37 +02:00
moneromooo-monero
e350cc5ad5
wallet2: fix duplicate output making it to the RPC
2018-09-25 11:28:39 +00:00
Riccardo Spagni
e67789d075
Merge pull request #4422
...
6e270fbd
2018-09-25 12:13:34 +02:00
Riccardo Spagni
cd8c7f6e78
Merge pull request #4433
...
b35beaa8
2018-09-25 12:12:14 +02:00
moneromooo-monero
b35beaa8d6
wallet_rpc_server: include account index in incoming_transfers RPC
2018-09-24 19:42:26 +00:00
moneromooo-monero
6e270fbd29
wallet2_api: fix for latest code changes
2018-09-22 23:00:34 +00:00
moneromooo-monero
83907f8829
wallet_rpc_server: fix --run-as-service on Windows
...
Thanks iDunk for the windows testing
2018-09-22 11:56:30 +00:00
moneromooo-monero
e03402b0c7
wallet_rpc_server: fix build for windows
...
Thanks iDunk for building patches on windows
2018-09-21 18:50:05 +00:00
Riccardo Spagni
85110b42ab
Merge pull request #4401
...
669019018cd984084ed30bab24f5239652e19d690c77523d
2018-09-21 20:46:22 +02:00
Riccardo Spagni
63eeb9df80
Merge pull request #4394
...
b7660149
2018-09-21 20:44:48 +02:00
m2049r
bce474be7d
query backing device
2018-09-19 18:25:38 +02:00
Riccardo Spagni
2371a814cf
Merge pull request #4387
...
6e6ffc06
2018-09-18 17:59:44 +02:00
Riccardo Spagni
535bd0eb7e
Merge pull request #4361
...
26971d46
2018-09-18 17:58:53 +02:00
Riccardo Spagni
08f0c60ffc
Merge pull request #4360
...
7a76354c
2018-09-18 17:58:14 +02:00
Riccardo Spagni
580497d5f9
Merge pull request #4306
...
56b50faa07ec748c
2018-09-18 17:32:11 +02:00
Riccardo Spagni
b174527f1d
Merge pull request #4302
...
ba8dd347
2018-09-18 17:31:35 +02:00
Riccardo Spagni
b4a9ebad6c
Merge pull request #4299
...
f9b22a7b
2018-09-18 17:29:26 +02:00
whythat
4ed30bab50
wallet: implement coin splitting for sweep_* 'outputs' option
...
Implemented strategy splits total amount into N equal parts,
where N is a specified number of outputs. If N > 1, dummy
change output is NOT created.
rebased by moneromooo
2018-09-18 11:02:03 +00:00
whythat
24f5239693
wallet: add 'outputs' option for sweep_* commands
...
'outputs' option allows to specify the number of
separate outputs of smaller denomination that will
be created by sweep operation.
rebased by moneromooo
2018-09-18 11:01:59 +00:00
stoffu
ba8dd3479d
api/wallet: properly disable key encryption
2018-09-17 22:15:29 +09:00
moneromooo-monero
b766014933
node_rpc_proxy: return a non empty error string on connection failure
...
This makes it easier to avoid bugs on the caller side if errors are
represented by non empty strings.
This fixes the refresh height setting in new wallets when no daemon
is running.
2018-09-17 11:03:46 +00:00
moneromooo-monero
6e6ffc0650
wallet2_api: bring up to latest wallet api
2018-09-16 13:24:48 +00:00
jcktm
c336d0f217
add daemonizer to rpc wallet
2018-09-15 06:24:27 +10:00
Dusan Klinec
f9b22a7b01
hw_device: support for multiple devices added [for review]
...
- device name is a new wallet property
- full device name is now a bit more structured so we can address particular device vendor + device path. Example: 'Ledger', 'Trezor:udp', 'Trezor:udp:127.0.0.1:21324', 'Trezor:bridge:usb01'. The part before ':' identifies HW device implementation, the optional part after ':' is device path to look for.
- new --hw-device parameter added to the wallet, can name the hardware device
- device reconnect added
2018-09-14 16:02:00 +02:00
Riccardo Spagni
d743994086
Merge pull request #4324
...
44259e56
2018-09-14 13:15:41 +02:00
moneromooo-monero
44259e560e
wallet: ask-password can now ask without encrypting the secret spend key
2018-09-14 11:14:21 +00:00
Riccardo Spagni
fd194aaa4d
Merge pull request #4347
...
df0e7c2f
2018-09-14 13:06:38 +02:00
Riccardo Spagni
7850541074
Merge pull request #4337
...
97764bae
2018-09-14 13:06:22 +02:00
Riccardo Spagni
b182dc8262
Merge pull request #4336
...
5f8f5631
2018-09-14 13:06:06 +02:00
Riccardo Spagni
dd2fc3afe3
Merge pull request #4332
...
20171746be6acfd5
2018-09-14 13:05:43 +02:00
Riccardo Spagni
1396b65bbc
Merge pull request #4331
...
88fbc4a5
2018-09-14 13:05:02 +02:00
Riccardo Spagni
5f9374c735
Merge pull request #4329
...
45c85c89
2018-09-14 13:03:46 +02:00
Riccardo Spagni
239a7e10ff
Merge pull request #4253
...
be001326
2018-09-14 12:54:25 +02:00
moneromooo-monero
be001326d1
remove obsolete daemon selection of fake outs and old tx construction
2018-09-14 10:51:45 +00:00
Riccardo Spagni
c74d9057f8
Merge pull request #4260
...
a54dbaee44439c324bce935bb66ba783639a3c01eb8a51bed6d276c62b2a681b80e4fef34801d6b5846190fddaa6cc7d50cb370d
2018-09-14 12:45:18 +02:00
Riccardo Spagni
438781afc4
Merge pull request #4221
...
62511df6b219c24c5b6bcca3
2018-09-14 12:38:36 +02:00
moneromooo-monero
56b50faab2
wallet: use wipeable_string in more places where a secret is used
2018-09-12 09:26:11 +00:00
Riccardo Spagni
157690caaa
Merge pull request #4352
...
0664a984
2018-09-11 21:26:50 +02:00
moneromooo-monero
ac4f71c200
wallet2: bump testnet rollback to account for coming reorg
2018-09-11 13:38:35 +00:00
moneromooo-monero
a1359ad43c
Check inputs to addKeys are in range
...
Reported by QuarksLab.
2018-09-11 13:38:09 +00:00
moneromooo-monero
5ffb2ff9b7
v8: per byte fee, pad bulletproofs, fixed 11 ring size
2018-09-11 13:38:07 +00:00
moneromooo-monero
2a8fcb421b
Bulletproof aggregated verification and tests
...
Also constrains bulletproofs to simple rct, for simplicity
2018-09-11 13:37:37 +00:00
moneromooo-monero
9ce9f8caf6
bulletproofs: add multi output bulletproofs to rct
2018-09-11 13:37:28 +00:00
naughtyfox
26971d46fc
WalletAPI: 'hasMultisigPartialKeyImages' function added
2018-09-10 19:33:08 +03:00
naughtyfox
7a76354c8b
wallet2: import_multisig forward refresh exception
2018-09-10 18:45:37 +03:00
moneromooo-monero
44439c3208
record blackballs as amount/offset, and add export ability
2018-09-10 09:04:18 +00:00
moneroexamples
0664a98421
wallet_rpc_server: remove some unused code
2018-09-09 12:37:01 +00:00
moneromooo-monero
50cb370d5b
ringdb: allow blackballing many outputs at once
...
It cuts down on txn commits, and speeds up blackballing substantially
2018-09-09 12:01:43 +00:00
moneromooo-monero
df0e7c2feb
wallet2: fix secondary partially signed multisig txes
2018-09-08 23:12:06 +00:00
moneromooo-monero
97764bae3a
wallet_rpc_server: error out if wallet-file and wallet-dir are both used
2018-09-08 20:54:14 +00:00
Guillaume LE VAILLANT
54b859bea5
wallet rpc: Add close_wallet RPC
...
And close the current wallet automatically if necessary when opening another
wallet.
2018-09-05 16:52:16 +02:00
luigi1111
77ed11e627
Merge pull request #4270
...
29dea0376affd9dc6c06976ac5a8
2018-09-04 13:19:58 -05:00
luigi1111
59e6fb06f9
Merge pull request #4269
...
3d5abbe#4027 ] add change_wallet_password wallet rpc command (artyomsol)
2018-09-04 13:17:40 -05:00
luigi1111
5f1bbe3bce
Merge pull request #4268
...
1f2409e
2018-09-04 13:16:04 -05:00
luigi1111
085b6ba98e
Merge pull request #4263
...
5ed6669
2018-09-04 13:12:48 -05:00
luigi1111
6d4d4ddb68
Merge pull request #4252
...
ac09cfa
2018-09-04 13:05:12 -05:00
stoffu
5f8f56315c
wallet2.get_reserve_proof: throw when specified amount is zero
2018-09-04 13:00:38 +09:00
moneromooo-monero
20171746de
wallet2: factor the creation of a new wallet keys file
2018-09-03 11:27:46 +00:00
moneromooo-monero
be6acfd5be
wallet2: factor new blockchain setup
2018-09-03 11:27:43 +00:00
moneromooo-monero
88fbc4a567
wallet2: fill in v2 height for stagenet
2018-09-03 11:26:28 +00:00
el00ruobuob
45c85c89de
remove unused fields from relay_tx RPC
2018-09-02 23:50:31 +02:00
stoffu
8ca1215f25
wallet: store trusted-daemon flag in wallet2
2018-08-23 14:55:09 +09:00
luigi1111
1db7a29e12
Merge pull request #4247
...
10475ab
2018-08-22 21:04:34 -05:00
luigi1111
2e7bfd0de5
Merge pull request #4242
...
6fcdc9e
2018-08-22 21:00:10 -05:00
luigi1111
6e8e4fb3b7
Merge pull request #4202
...
8439306
2018-08-22 20:42:20 -05:00
Dusan Klinec
6fcdc9e0b2
rpc-wallet: refresh command added
2018-08-22 16:57:55 +02:00
moneromooo-monero
62511df622
wallet2: fix refresh retry when a block/tx fails to parse
...
It would switch to a new set of blocks and fail, getting out of sync
with the hash chain in the process
2018-08-22 09:57:46 +00:00
moneromooo-monero
b219c24c3a
wallet2: trim hash chain after fast refresh of hashes
...
This ensures it can't end up filled with the actual placeholders
2018-08-22 09:57:42 +00:00
moneromooo-monero
5b6bcca32a
wallet2: fix checking the wrong vector when adding hashes
...
The two vectors should be the same size anyway, so add an assert
to catch any case where they aren't
2018-08-22 09:57:39 +00:00
moneromooo-monero
76ac5a8fbe
wallet2: ask for a binary output distribution, for speed
2018-08-19 15:58:25 +00:00
artyomsol
3d5abbe86b
[ #4027 ] add change_wallet_password wallet rpc command
2018-08-17 09:54:26 +03:00
stoffu
1f2409e9e2
Do memwipe for critical secret keys copied to rct::key
2018-08-16 22:26:30 +09:00
moneromooo-monero
ab74dc277a
crypto: make secret_key automatically mlock
2018-08-16 11:57:49 +00:00
moneromooo-monero
e9ffa91257
store secret keys encrypted where possible
...
The secret spend key is kept encrypted in memory, and
decrypted on the fly when needed.
Both spend and view secret keys are kept encrypted in a JSON
field in the keys file. This avoids leaving the keys in
memory due to being manipulated by the JSON I/O API.
2018-08-16 11:57:43 +00:00
moneromooo-monero
ea37614efe
wallet: wipe seed from memory where appropriate
2018-08-16 09:17:52 +00:00
stoffu
a64f57fe42
wallet2: make --restricted-rpc available for wallet RPC only
2018-08-16 09:54:23 +09:00
luigi1111
e69e0e9e34
Merge pull request #4194
...
0f75717
2018-08-15 17:56:23 -05:00
luigi1111
1c55a3756b
Merge pull request #4193
...
4520cfd
2018-08-15 17:54:49 -05:00
luigi1111
8d2e454929
Merge pull request #4188
...
a3fe1c5
2018-08-15 17:47:05 -05:00
luigi1111
7aa2030cee
Merge pull request #4174
...
ff37bd0
2018-08-15 17:40:55 -05:00
luigi1111
a68143bc52
Merge pull request #4171
...
9127a8b
2018-08-15 17:37:23 -05:00
luigi1111
564e9c3b5f
Merge pull request #4170
...
1c6cfd3
2018-08-15 17:35:49 -05:00
luigi1111
e7328ed5b7
Merge pull request #4158
...
7db7ec8
2018-08-15 17:25:19 -05:00
luigi1111
5e795ee7af
Merge pull request #4153
...
37f0799
2018-08-15 17:23:56 -05:00
luigi1111
2a44c2defd
Merge pull request #4150
...
f2e65c6
2018-08-15 17:22:36 -05:00
luigi1111
1d2c08610b
Merge pull request #4136
...
4307489
2018-08-15 17:15:49 -05:00
luigi1111
017e07a035
Merge pull request #4103
...
bcab579
2018-08-15 17:09:52 -05:00
luigi1111
4cde4cb946
Merge pull request #3528
...
34d4b79
2018-08-15 17:00:32 -05:00
moneromooo-monero
5ed6669130
wallet_rpc_server: remove unused amount_keys field in transfer RPC
2018-08-15 12:47:33 +00:00
fireice-uk
10475ab23f
node_rpc_proxy: fix fork earliest height caching [RYO backport]
...
xref https://github.com/ryo-currency/ryo-currency/pull/86
2018-08-13 22:16:17 +02:00
moneromooo-monero
ac09cfa6be
wallet2: remove obsolete pruned/unpruned case
...
All daemons will not support pruned blocks
2018-08-13 13:17:27 +00:00
moneromooo-monero
4307489147
wallet: disable core dumps on startup in release mode
2018-08-12 16:28:10 +00:00
stoffu
bcab579864
wallet: allow adjusting number of rounds for the key derivation function
2018-08-08 01:56:54 +09:00
moneromooo-monero
37f0799284
wallet: distinguish coinbase from other txes in show_transfers
2018-08-03 12:48:16 +00:00
moneromooo-monero
8439306212
wallet2: do not divide by 0 on invalid daemon response
2018-07-31 14:26:00 +00:00
stoffu
1c6cfd34f4
wallet-rpc: add get_address_index command
2018-07-31 21:36:12 +09:00
stoffu
9127a8b79f
wallet-rpc: filter getbalance response by address index
2018-07-31 20:45:41 +09:00
moneromooo-monero
0f757177fe
wallet2: avoid using arbitrary random values when unknown
2018-07-30 13:34:15 +01:00
moneromooo-monero
4520cfd978
wallet2: guard against bad outputs in import_outputs
...
also some minor speedup
2018-07-30 13:21:58 +01:00
stoffu
a3fe1c56ee
simplewallet: add set_tx_key for importing tx keys from 3rd party wallets
2018-07-30 20:50:05 +09:00
luigi1111
f739a3cbb8
Merge pull request #4109
...
2951436
2018-07-27 14:27:47 -05:00
luigi1111
92b5d6c204
Merge pull request #4091
...
a4272de
2018-07-27 14:22:34 -05:00
moneromooo-monero
ff37bd00bc
wallet2: fix O(n^2) behaviour in import_key_images
...
That takes a lot of time for even not so large wallets
2018-07-24 14:34:19 +01:00
stoffu
7db7ec8591
wallet rpc: support making integrated address of given standard address
2018-07-20 21:33:36 +09:00
luigi1111
702a41034d
Merge pull request #4088
...
8c4db68
2018-07-19 14:15:16 -05:00
luigi1111
5c102c60dc
Merge pull request #4087
...
d6440ab
2018-07-19 14:14:10 -05:00
luigi1111
f6d7e87b67
Merge pull request #4075
...
438d52d
2018-07-19 14:10:20 -05:00
luigi1111
be81a27fa4
Merge pull request #4071
...
d6d78f1
2018-07-19 14:06:54 -05:00
luigi1111
9315e12d34
Merge pull request #4033
...
3e46db9
2018-07-19 13:55:37 -05:00
stoffu
f2e65c6e50
wallet2: consider minimum fee when testing if balance is sufficient
2018-07-19 20:31:07 +09:00
moneromooo-monero
d6440ab319
wallet2: recover from index out of hashchain bounds error
...
This can happen when there's a very large reorg on the daemon
(ie, on testnet)
2018-07-16 23:13:56 +01:00
moneromooo-monero
2951436704
wallet: warn when payment IDs are used
...
Subaddresses are better for privacy
2018-07-12 19:37:29 +01:00
moneromooo-monero
fc39d3b23c
wallet2: ensure outputs are processed only once
...
This should be proof against any way one might get to multiple
processing, such as generating the same derivation from the
same pubkey, etc
2018-07-08 12:56:51 +01:00
moneromooo-monero
34d4b798d4
wallet2: use a gamma distribution to pick fake outs
...
as per "An Empirical Analysis of Linkability in the Monero
Blockchain", by Miller et al.
2018-07-03 18:10:48 +01:00
Riccardo Spagni
40f85f478e
Merge pull request #3985
...
58cceaad
2018-07-03 15:51:41 +02:00
Riccardo Spagni
f449dbe8eb
Merge pull request #4041
...
df9d50a8
2018-07-03 15:20:42 +02:00
Riccardo Spagni
94803bad01
Merge pull request #4035
...
66df13a5
2018-07-03 15:19:54 +02:00
Riccardo Spagni
97f5a130d6
Merge pull request #4028
...
2a19697b
2018-07-03 15:19:24 +02:00
Riccardo Spagni
e451c76181
Merge pull request #4005
...
b85acb4c
2018-07-03 15:18:05 +02:00
Riccardo Spagni
27ca6ca594
Merge pull request #4004
...
bc443494
2018-07-03 15:16:37 +02:00
moneromooo-monero
58cceaad71
wallet2: fix double counting outs if the tx pubkey is duplicated
2018-07-03 14:16:30 +01:00
stoffu
a4272de797
wallet2: unlock keys file before calling verify_password (needed for Windows)
...
Also added notes to WalletManager::verifyWalletPassword (which afaik seems unused
by anyone at the moment) regarding the need to unlock the keys file beforehand.
2018-07-03 18:07:20 +09:00
stoffu
d6d78f157b
Allow fractional outputs to be ignored
2018-07-03 18:04:31 +09:00
moneromooo-monero
8c4db68ff7
node_rpc_proxy: factor a few RPC calls using get_info
...
Takes advantage of caching
2018-07-02 17:59:44 +01:00
moneromooo-monero
438d52deaf
remove epee from link lines where it's redundant
...
For some reason, this confuses and kills ASAN on startup
as it thinks const uint8_t ipv4_network_address::ID is
defined multiple times.
2018-06-28 16:45:22 +01:00
luigi1111
a9b83f5a6e
Merge pull request #4067
...
9a39b7d
2018-06-27 21:28:34 -05:00
stoffu
29254fc06e
api/wallet: add missing arg to wallet2::refresh()
2018-06-28 10:24:05 +09:00
luigi1111
ba0a7294d0
Merge pull request #4000
...
4510f41
2018-06-27 20:18:41 -05:00
luigi1111
4c6de54ee2
Merge pull request #3994
...
1d1764759de6f83d623a8
2018-06-27 20:17:25 -05:00
stoffu
4510f417f9
Wallet API: add some missing override keyword
...
Also remove dust() from UnsignedTransactionImpl (already in PendingTransactionImpl)
2018-06-28 09:59:09 +09:00
stoffu
3d623a86d1
wallet: prevent the same wallet file from being opened by multiple processes
2018-06-28 09:41:43 +09:00
moneromooo-monero
9a39b7dd7f
wallet2: fix build for windows (std::max again)
2018-06-28 00:47:48 +01:00
moneromooo-monero
9b38551c3c
wallet_rpc_server: fix build - forgot to build rpc version
2018-06-27 23:34:02 +01:00
luigi1111
2329d2f4c8
Merge pull request #3907
...
dcbc17e
2018-06-27 16:32:33 -05:00
luigi1111
8a27caeb22
Merge pull request #3998
...
8db23df
2018-06-27 16:30:38 -05:00
luigi1111
9453573581
Merge pull request #3995
...
0a5292c
2018-06-27 16:28:57 -05:00
luigi1111
c28a2b0d7d
Merge pull request #3992
...
25c15dc
2018-06-27 16:26:23 -05:00
luigi1111
5eb2e01216
Merge pull request #3991
...
798dfcf
2018-06-27 16:25:03 -05:00
luigi1111
3ad4ecd4ff
Merge pull request #3982
...
08b85a80cf80ba
2018-06-27 15:38:23 -05:00
moneromooo-monero
dcbc17e97e
wallet: include a suggested number of confirmations based on amount
...
This is based on how much an attacking miner stands to lose in block
rewardy by mining a private chain which double spends a payment.
This is not foolproof, since mining is based on luck, and breaks
down as the attacking miner nears 50% of the network hash rate,
and the estimation is based on a constant block reward.
2018-06-27 21:38:21 +01:00
luigi1111
a844844cda
Merge pull request #3716
...
a2b557f6795bd0209ec96ed2c81ea830db257ea90231a895eba8331cf7f191741be339f025ae9ef2cb63dcfd2995d3e70227046242771a180e4c7d0
2018-06-27 15:33:01 -05:00
moneromooo-monero
0e4c7d0fae
wallet2: cache ringdb key while refreshing
...
Speeds up syncing with a lot of outgoing outputs as key generation
runs Cryptonight.
2018-06-26 22:15:38 +01:00
moneromooo-monero
2771a18e85
threadpool: allow leaf functions to run concurrently
...
Decrease the number of worker threads by one to account
for the fact the calling thread acts as a worker thread now
2018-06-26 22:15:22 +01:00
moneromooo-monero
2704624eae
wallet2: remove unneeded divisions
2018-06-26 22:15:20 +01:00
moneromooo-monero
5d3e70229e
wallet2: remove old blockchain size cache hack
2018-06-26 22:15:18 +01:00
moneromooo-monero
dcfd299239
wallet2: speedup refresh
...
key derivation and checking for incoming outputs are threaded
in batch before adding blocks to the local blockchain. Other
minor bits and bobs are also cached.
2018-06-26 22:15:16 +01:00
moneromooo-monero
f025ae9760
wallet2: avoid re-parsing blocks when refreshing in a loop
2018-06-26 22:15:12 +01:00
moneromooo-monero
41be339655
wallet2: avoid duplicate parsing of tx extra
2018-06-26 22:15:10 +01:00
moneromooo-monero
f7f1917ed4
wallet2: remove useless device locking
2018-06-26 22:14:35 +01:00
moneromooo-monero
ba8331ce41
wallet2: parse blocks in the RPC thread, not the processing thread
...
Processing typically is the bottleneck
2018-06-26 22:14:33 +01:00
moneromooo-monero
31a895e876
wallet2: simplify/speedup process_blocks
2018-06-26 22:14:31 +01:00
moneromooo-monero
57ea90285c
wallet: don't process miner tx if we're refreshing with no-coinbase
2018-06-26 22:14:26 +01:00
moneromooo-monero
ed2c81ed95
replace std::list with std::vector on some hot paths
...
also use reserve where appropriate
2018-06-26 22:14:21 +01:00
moneromooo-monero
6795bd0d4e
rpc: add option to skip coinbase info in get_blocks.bin
2018-06-26 22:14:16 +01:00
moneromooo-monero
a2b557fe5c
wallet2: use std::move on containers where appropriate
2018-06-26 22:14:14 +01:00
luigi1111
506be80601
Merge pull request #3955
...
d7a6b72
2018-06-25 15:09:48 -05:00
luigi1111
26562e9f3c
Merge pull request #3941
...
bf26920
2018-06-25 14:54:54 -05:00
moneromooo-monero
df9d50a8a4
wallet2: fix read buffer overflow in import_key_images
2018-06-23 09:22:20 +01:00
moneromooo-monero
3e46db97e5
rpc: add a non binary get_transaction_pool_hashes RPC
2018-06-21 09:02:42 +01:00
stoffu
46e90b7780
Wallet API: add support for wallet creation from hardware device
2018-06-21 12:36:27 +09:00
stoffu
8fc0cdb96f
wallet2: lower default for subaddress lookahead when restoring with hardware
2018-06-21 12:35:23 +09:00
stoffu
66df13a58b
wallet-rpc.getaddress: throw if index is out of bound
2018-06-21 10:49:03 +09:00
luigi1111
9a3712541e
Merge pull request #3939
...
62c8c07
2018-06-20 14:52:55 -05:00
luigi1111
51cdd76bbd
Merge pull request #3897
...
63d0ab0
2018-06-20 14:19:30 -05:00
moneromooo-monero
2a19697bd4
wallet2: fix double header in unsigned transfer file
2018-06-19 22:30:02 +01:00
luigi1111
896512b2b6
Merge pull request #3878
...
5a412b7
2018-06-19 12:57:59 -05:00
luigi1111
d841339b09
Merge pull request #3829
...
4764929
2018-06-19 12:43:10 -05:00
luigi1111
9226acca4b
Merge pull request #3804
...
89e51ec
2018-06-16 14:15:52 -05:00
luigi1111
4e7897e57c
Merge pull request #3780
...
9c2a7b4
2018-06-16 14:12:57 -05:00
luigi1111
e3012444fb
Merge pull request #3762
...
eb9f3a3
2018-06-16 14:10:11 -05:00
luigi1111
7af0b7fffc
Merge pull request #3735
...
4812c06
2018-06-16 14:07:25 -05:00
Howard Chu
b85acb4cb8
Fix RPC crashes that didn't check for an open wallet
2018-06-15 20:18:41 +01:00
moneromooo-monero
bc443494f3
wallet2: fix out of sync account tag cache
...
This would cause crashes when trying to tag an account that was
just created
2018-06-15 20:18:12 +01:00
moneromooo-monero
8db23df581
wallet: on first refresh, start off with a quantized height
...
for privacy reasons, so an untrusted node can't easily track
wallets from IP address to IP address, etc. The granularity
is 1024 blocks, which is about a day and a half.
2018-06-13 22:44:27 +01:00
stoffu
63d0ab09b5
mlog: --max-log-files to set the max number of rotated log files
2018-06-13 12:44:27 +09:00
stoffu
798dfcfe79
wallet: allow unspendable unmixable outputs to be discarded
2018-06-13 11:56:40 +09:00
stoffu
0a5292c339
wallet2: use decoded amount when reporting repeated output key
2018-06-13 01:06:44 +09:00
stoffu
25c15dca5c
wallet2: use correct fee for split txes
2018-06-12 12:06:51 +09:00
stoffu
08b85a8e00
cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X
2018-06-11 20:17:02 +09:00
luigi1111
6884db7b31
Merge pull request #3599
...
8787fd8
2018-06-08 14:45:46 -05:00
luigi1111
00635bd68b
Merge pull request #3598
...
b21bc00
2018-06-08 14:40:06 -05:00
luigi1111
1af890287b
Merge pull request #3890
...
f80b157
2018-06-07 12:12:28 -05:00
moneromooo-monero
d7a6b72c15
wallet2: fix bulletproof cold signing
...
Cold signing was always using Borromean range proofs, causing
a larger tx, and an incorrect fee
2018-06-07 12:29:30 +01:00
stoffu
bf26920f27
wallet2: fix get_approximate_blockchain_height for stagenet
2018-06-06 20:33:01 +09:00
moneromooo-monero
62c8c07c47
wallet: do not log by default if we're not asked to log to console
...
This means monero-wallet-rpc still does, but the user level program
does not.
2018-06-06 10:15:13 +01:00
cryptochangements34
4764929ecb
use deterministic viewkey if not supplied
2018-06-05 19:32:03 -04:00
Dusan Klinec
9c2a7b4638
wallet-rpc: watch-only and cold wallet features added
...
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs
Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx
- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
2018-06-03 13:21:00 +02:00
luigi1111
503d2693fd
Merge pull request #3640
...
f36132a
2018-05-31 14:44:54 -05:00
luigi1111
3ee6a1b706
Merge pull request #3635
...
c1bda09
2018-05-31 14:43:18 -05:00
luigi1111
b6eb7484d1
Merge pull request #3592
...
90a16b16a61f52
2018-05-31 14:41:17 -05:00
luigi1111
3a373c3d3a
Merge pull request #3489
...
47fdb7447fdb74
2018-05-31 14:34:34 -05:00
moneromooo-monero
f80b1571c6
wallet2: don't ask for pruned txes yet, we still parse the entire tx
2018-05-31 16:46:58 +01:00
stoffu
0da5d37bf3
wallet: fix shared ring db path
2018-05-31 08:16:45 +09:00
luigi1111
5b189ce2a8
Merge pull request #3405
...
80d2f80
2018-05-29 12:52:43 -05:00
moneromooo-monero
5a412b7a3f
disable file size sanity check when loading the wallet cache
2018-05-28 14:58:22 +01:00
Riccardo Spagni
709658d166
Merge pull request #3832
...
cb9c7972
2018-05-21 20:57:52 +02:00
Riccardo Spagni
d6cefbd1b8
Merge pull request #3745
...
b13bddc3
2018-05-21 20:56:20 +02:00
stoffu
cb9c7972b6
Fix output shuffling for multisig
2018-05-20 09:38:41 +09:00
jcktm
89e51ecd38
simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet
2018-05-15 15:28:42 +10:00
moneromooo-monero
a58d9738c9
wallet2: consider 6 outputs or less to be unmixable from v7
2018-05-10 21:19:33 +01:00
itssteven
eb9f3a3294
check_spend_proof
...
My intention is to mitigate #3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: https://github.com/monero-integrations/monerophp/issues/72 & my temp fix: https://github.com/monero-integrations/monerophp/pull/74
2018-05-06 17:42:27 +01:00
Teutone
4812c062c5
add .load() to make Boost 1.67 happy with its new is_integral check
2018-05-05 21:44:28 +02:00
stoffu
b13bddc3c9
Wallet API: allow log path to be non-default & console output to be configurable
2018-05-04 10:21:25 +09:00
Riccardo Spagni
93e76e14a2
Merge pull request #3685
...
ffeeefde2dae0f20
2018-04-28 16:56:22 +02:00
Riccardo Spagni
35299644b2
Merge pull request #3650
...
5bd7f760
2018-04-28 16:54:37 +02:00
naughtyfox
b21bc00704
Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api)
2018-04-25 17:55:54 +03:00
moneromooo-monero
2dae0f203a
wallet2: add missing parameters to get_output_histogram
2018-04-23 10:54:25 +01:00
stoffu
f36132a837
wallet cli/rpc: terminate execution with code 0 when --help or --version is given
2018-04-22 11:48:44 +09:00
Mikhail Mitkevichl
5bd7f760e9
import_multisig_info: fix sanity check crash in detach_blockchain
2018-04-21 23:25:01 +03:00
Riccardo Spagni
a3a617f35f
Merge pull request #3576
...
f82c10dc
2018-04-21 21:58:10 +02:00
Riccardo Spagni
03ff3be10e
Merge pull request #3672
...
875c1cab70f232178c7363fb
2018-04-21 21:54:08 +02:00
moneromooo-monero
875c1cabb9
wallet2: increase rpc timeout for get_output_distribution
2018-04-19 16:06:26 +01:00
moneromooo-monero
70f2321763
add top height to get_output_distribution, and cache it for rct
...
This should cache the vast majority of calls for long running wallets
2018-04-19 16:06:22 +01:00
moneromooo-monero
c1bda097c1
wallet_rpc_server: add a get_version RPC
2018-04-14 13:34:05 +01:00
naughtyfox
8787fd899b
WalletApi: publicMultisigSignerKey method
2018-04-13 13:15:20 +03:00
stoffu
b5d6c723e9
wallet2: store subaddress lookahead settings
2018-04-12 22:23:53 +09:00
cslashm
94b899db26
Use 'boost' mutex instead of 'std' mutex
2018-04-12 13:58:57 +02:00
cslashm
2c274e05fe
Fix sub-address tx scan.
...
When additional keys was needed, the TX scan failed because the
derivation data was always recomputed with the main tx_key and not
the corresponding additional one.
Moreover this patch avoid perf decreasing when not using HW device.
2018-04-12 13:58:57 +02:00
Riccardo Spagni
5e08fd89ea
Merge pull request #3549
...
73951cbd25fe67e4
2018-04-12 13:49:33 +02:00
Riccardo Spagni
14c870ee5f
Merge pull request #3615
...
24acb66e
2018-04-12 13:47:54 +02:00
Riccardo Spagni
3b8704b0fa
Merge pull request #3555
...
0b26c4d5
2018-04-12 13:47:39 +02:00
Riccardo Spagni
5d8439e310
Merge pull request #3534
...
eecfb57d
2018-04-12 13:47:20 +02:00
Riccardo Spagni
8703f1d80e
Merge pull request #3516
...
1e0958c0
2018-04-12 13:46:18 +02:00
moneromooo-monero
24acb66eac
wallet2: fix misc issues when the ringdb can't be initialized
2018-04-12 11:07:07 +01:00
Riccardo Spagni
5053f8f40b
Merge pull request #3502
...
11c933e1
2018-04-12 11:14:43 +02:00
Riccardo Spagni
96b2fee721
Merge pull request #3536
...
c77d2bfa100b7bc1641dfc99
2018-04-12 11:12:33 +02:00
Riccardo Spagni
1b4dc46129
Merge pull request #3473
...
eaa8bfe70a619f78
2018-04-12 11:05:31 +02:00
Riccardo Spagni
ebb55f797b
Merge pull request #3468
...
0098ed33
2018-04-12 11:00:47 +02:00
moneromooo-monero
6a61f520e2
unit_tests: add ringdb unit tests
2018-04-11 11:43:39 +01:00
moneromooo-monero
73951cbd39
wallet2: request transactions in slices when scanning for known rings
...
This avoid massive memory consumption for huge wallets
2018-04-07 08:31:46 +01:00
moneromooo-monero
25fe67e4cf
rpc: allow getting pruned blocks from gettransactions
...
and get them pruned in find_and_save_rings, since it does not need
the pruned data in the first place.
Also set decode_to_json to false where missing, we don't need this
either.
2018-04-07 08:29:11 +01:00
stoffu
f82c10dc96
WalletManagerImpl: reuse existing connection to daemon instead of reconnectivng every time
2018-04-07 14:06:29 +09:00
moneromooo-monero
0b26c4d57c
wallet2: move segregation height to v7
...
since people seem to really want to use things the wrong way.
2018-04-05 12:49:38 +01:00
cslashm
c77d2bfaa0
Add the possibility to export private view key for fast scan.
...
On client startup the device asks for authorization to export the private view key.
If user agree, the client hold the private view key allowing a fast blockchain scan.
If the user does not agree, the blockchain scan is fully done via the device.
2018-03-31 18:00:33 +02:00
moneromooo-monero
eecfb57df9
wallet: warn if not using the default ring size
2018-03-31 15:47:02 +01:00
sneurlax
1e0958c083
wallet: fix default mixin (4 -> 6)
2018-03-28 09:30:11 -07:00
naughtyfox
5a96056600
WalletApi: getMultisigInfo entry for gui wallets
...
WalletApi: makeMultisig call introduced
WalletApi: finalizeMultisig call introduced
WalletApi: new calls exportMultisigImages and importMultisigImages
WalletApi: method to return multisig wallet creation state
WalletApi: create multisig transaction, sign multisig transaction, commit transaction and get multisig data are added
WalletApi: identation and style fixes
2018-03-28 18:22:13 +03:00
naughtyfox
47fdb74273
Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings
...
WalletApi: added method statusWithErrorString to atomically retrieve error with error string
2018-03-28 16:11:16 +03:00
moneromooo-monero
11c933e137
fix lambda compile error on openbsd
2018-03-27 14:48:36 +01:00
stoffu
eaa8bfe7c0
wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly
...
The previous expression
req_t.from_height = X ? Y >= Z : 0;
forces the parameter to take the value of either 0 or 1.
2018-03-22 20:02:25 +09:00
stoffu
0a619f789b
wallet2: enable the mitigation only after the fork height
2018-03-22 20:02:14 +09:00
stoffu
0098ed338c
wallet2: fix for loading settings of key reuse mitigation
2018-03-22 12:10:46 +09:00
moneromooo-monero
5730049178
wallet: catch exceptions dealing with ringdb and warn
2018-03-21 14:29:49 +00:00
moneromooo-monero
1e393f4bb7
wallet: make the segregation height settable
...
via user setting first, then DNS TXT record, hardcoded fallback
2018-03-17 14:56:31 +00:00
Riccardo Spagni
5cd36e48bf
Merge pull request #3421
...
9732a37e
2018-03-17 16:52:46 +02:00
moneromooo-monero
9732a37e9a
wallet_rpc_server: add sweep_unmixable as alias for sweep_dust
2018-03-17 11:22:58 +00:00
stoffu
b86f1e5dad
Add command line option allowing to restrict the default sub-address lookahead in order to avoid
...
so looooong time of set-up when creating a HW based wallet.
2018-03-16 18:00:28 +01:00
Riccardo Spagni
0f27fc57ac
Merge pull request #3336
...
57c0b1ed
2018-03-16 18:08:07 +02:00
moneromooo-monero
eac3a11ed3
wallet: more user friendly print_ring
...
It can now take a txid (to display rings for all its inputs),
and will print rings in a format that set_ring understands
2018-03-16 12:07:45 +00:00
moneromooo-monero
798535149d
wallet2_api: add key reuse mitigations API
2018-03-16 12:07:42 +00:00
moneromooo-monero
b057a21d56
wallet2_api: add ring api
2018-03-16 10:33:05 +00:00
moneromooo-monero
d32ef7b0f2
ringdb: factor ring addition code
2018-03-16 10:33:02 +00:00
moneromooo-monero
a7da8208f5
wallet2_api: add blackball api
2018-03-16 10:32:59 +00:00
moneromooo-monero
504428ab4a
ringdb: use the genesis block as a db name
...
This will avoid careless forkers polluting the shared database
even if they make their own chain. They'll then automatically
start using another subdb, and any key-reusing fork of those
forks will reuse their subdbs.
2018-03-16 10:32:54 +00:00
moneromooo-monero
b09e5181cc
wallet: add a set_ring command
...
This is so one can set rings for spent key images in case the
attackers don't merge the ring matching patch set.
2018-03-16 10:32:51 +00:00
moneromooo-monero
db10dd6d83
wallet: make ringdb an object with database state
2018-03-16 10:32:42 +00:00
moneromooo-monero
d29ea0455a
wallet: add an output blackball list to avoid using those in rings
2018-03-16 10:32:37 +00:00
moneromooo-monero
18eaf19489
wallet: key reuse mitigation options
...
If a pre-fork output is spent on both Monero and attack chain,
any post-fork output can be deduced to be a fake output, thereby
decreasing the effective ring size.
The segregate-per-fork-outputs option, on by default, allows
selecting only pre-fork outputs in this case, so that the same
ring can be used when spending it on the other side, which does
not decrease the effective ring size.
This is intended to be SET when intending to spend Monero on the
attack fork, and to be UNSET if not intending to spend Monero
on the attack fork (since it leaks the fact that the output being
spent is pre-fork).
If the user is not certain yet whether they will spend pre-fork
outputs on a key reusing fork, the key-reuse-mitigation2 option
should be SET instead.
If you use this option and intend to spend Monero on both forks,
then spend real Monero first.
2018-03-16 10:32:34 +00:00
moneromooo-monero
5f146873c5
wallet: add shared ring database
...
This maps key images to rings, so that different forks can reuse
the rings by key image. This avoids revealing the real inputs like
would happen if two forks spent the same outputs with different
rings. This database is meant to be shared with all Monero forks
which don't bother making a new chain, putting users' privacy at
risk in the process. It is placed in a shared data directory by
default ($HOME/.shared-ringdb on UNIX like systems). You may
use --shared-ringdb-dir to override this location, and should
then do so for all Monero forks for them to share the database.
2018-03-16 10:32:29 +00:00
moneromooo-monero
41f727ce42
add RPC to get a histogram of outputs of a given amount
2018-03-16 10:32:26 +00:00
Dimitris Apostolou
57c0b1ed9f
Fix typos in various files
2018-03-15 18:25:38 +02:00
stoffu
a7266d6d7b
wallet2+cli+rpc: eliminate redundant m_http_client from cli/rpc and delegate calls to wallet2
2018-03-15 22:01:51 +09:00
Leon Klingele
80d2f8007c
wallet2: Update function parameter documentation
...
This completes and fixes various parameters docs
2018-03-14 16:41:24 +01:00
stoffu
71d186566e
replace invoke_http_json("/json_rpc",...) with invoke_http_json_rpc("/json_rpc",methodname,...) to reduce boilerplate
2018-03-14 23:23:59 +09:00
Riccardo Spagni
a69c713f8e
Merge pull request #3398
...
c577abab
2018-03-14 16:18:15 +02:00
Riccardo Spagni
2fe1504c03
Merge pull request #3399
...
1d39b265
2018-03-14 16:17:59 +02:00
Riccardo Spagni
8b90e3141a
Merge pull request #3386
...
9abeff59
2018-03-14 16:10:00 +02:00
Riccardo Spagni
7a44301675
Merge pull request #3385
...
ec41006c
2018-03-14 16:09:40 +02:00
stoffu
4405e4fc73
wallet2: check_tx_key() shouldn't require hardware encryption
2018-03-14 21:00:18 +09:00
stoffu
27a196b126
device: untangle cyclic depenency
...
When #3303 was merged, a cyclic dependency chain was generated:
libdevice <- libcncrypto <- libringct <- libdevice
This was because libdevice needs access to a set of basic crypto operations
implemented in libringct such as scalarmultBase(), while libringct also needs
access to abstracted crypto operations implemented in libdevice such as
ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct
into libringct_basic and libringct, where the basic crypto ops previously in
libringct are moved into libringct_basic. The cyclic dependency is now resolved
thanks to this separation:
libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct
This eliminates the need for crypto_device.cpp and rctOps_device.cpp.
Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and
get_subaddress_secret_key() were previously implemented in libcryptonote_basic
(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,
which is odd because libdevice is supposed to be independent of libcryptonote_basic.
Therefore, those functions were moved to device_default.cpp.
2018-03-14 21:00:15 +09:00
stoffu
c9b38b4765
device: made function prototypes consistent with pre-#3303 codebase
2018-03-14 21:00:06 +09:00
Riccardo Spagni
f2e8e8d23c
Merge pull request #3377
...
aa8bef0c
2018-03-14 13:38:50 +02:00
Riccardo Spagni
3bc2537f5a
Merge pull request #3369
...
1979d53d
2018-03-14 13:37:14 +02:00
Riccardo Spagni
0f2d6d40b4
Merge pull request #3360
...
1ff35fda
2018-03-14 13:37:00 +02:00
Riccardo Spagni
117cf12509
Merge pull request #3355
...
0bbd521f
2018-03-14 13:36:36 +02:00
Riccardo Spagni
33158f089d
Merge pull request #3354
...
ffe70b8f
2018-03-14 13:36:25 +02:00
Riccardo Spagni
2dfb4f098e
Merge pull request #3353
...
73dd883d
2018-03-14 13:36:14 +02:00
Riccardo Spagni
cfc5a3d4d4
Merge pull request #3345
...
e0cda74a
2018-03-14 13:35:53 +02:00
Riccardo Spagni
67978b78ce
Merge pull request #3337
...
91d97dd45f85cc7e
2018-03-14 13:35:41 +02:00
Riccardo Spagni
3fed788603
Merge pull request #3315
...
649a1b7a
2018-03-14 13:35:11 +02:00
moneromooo-monero
5f85cc7e3d
wallet2: guard against overflowing of subaddress indices
2018-03-14 11:34:06 +00:00
stoffu
1d39b26556
wallet2: fix use_fork_rules() when querying version that is defined but not enabled yet
2018-03-14 19:02:21 +09:00
stoffu
c577abab61
wallet: fix auto low priority so that it takes effect only when saved default is 0
2018-03-14 18:33:43 +09:00
Cédric
73dd883d51
Ledger HW Bug fixes
...
Fix the way the REAL mode is handle:
Let create_transactions_2 and create_transactions_from construct the vector of transactions.
Then iterate on it and resign.
We just need to add 'outs' list in the TX struct for that.
Fix default secret keys value when DEBUG_HWDEVICE mode is off
The magic value (00...00 for view key and FF..FF for spend key) was not correctly set
when DEBUG_HWDEVICE was off. Both was set to 00...00.
Add sub-address info in ABP map in order to correctly display destination sub-address on device
Fix DEBUG_HWDEVICE mode:
- Fix compilation errors.
- Fix control device init in ledger device.
- Add more log.
Fix sub addr control
Fix debug Info
2018-03-12 10:43:06 +01:00
moneromooo-monero
9abeff5911
wallet2: handle no blocks returned in refresh to mean no new blocks
...
This is not a possible return from the daemon, but I want this in
now so all wallets handle this when the daemon starts doing so.
2018-03-11 21:16:15 +00:00
moneromooo-monero
ec41006cad
node_rpc_proxy: fix target height caching
2018-03-11 13:11:49 +00:00
Leon Klingele
649a1b7ae6
wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets
...
Previously, a file containing the unencrypted Monero address was
created by default in the wallet's directory. This file might pose
as a privacy risk. The creation of this file is now opt-in and can
be enabled by providing
--create-address-file
2018-03-10 16:28:23 +01:00
cryptochangements34
aa8bef0cb3
fix error message typo in wallet2.cpp
2018-03-09 17:22:26 -05:00
Riccardo Spagni
e9f41e405f
Merge pull request #3368
...
38657fd0
2018-03-08 18:47:41 +02:00
Riccardo Spagni
3a12f2588a
Merge pull request #3365
...
55a65f32
2018-03-08 18:44:18 +02:00
Riccardo Spagni
60c8544e77
Merge pull request #3347
...
9a6be3da
2018-03-08 18:42:24 +02:00
moneromooo-monero
1979d53d78
wallet: fixes and tweaks to the save_watch_only command
...
- save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly
- catch any exception (eg, I/O errors) and error out
- print the new keys filename in simplewallet
2018-03-07 14:24:14 +00:00
moneromooo-monero
38657fd0e9
Bump min ring size from 5 to 7 from v7
2018-03-07 13:19:04 +00:00
stoffu
55a65f3269
Wallet API: corrected testnet/mainnet ordering
2018-03-07 13:56:17 +09:00
stoffu
1ff35fda7c
Wallet API: make nettype non-defaulted to disambiguate from deprecated versions (and make libwallet_api_tests compilable)
2018-03-06 21:14:52 +09:00
stoffu
0bbd521fa2
libwallet_merged: added missing libdevice
2018-03-06 02:36:37 +09:00
cryptochangements34
ffe70b8f61
Make mixin optional with default for rpc transfer
2018-03-05 12:27:22 -05:00
Riccardo Spagni
237f0179b7
Merge pull request #3313
...
43026822
2018-03-05 19:15:54 +02:00
Riccardo Spagni
baf640887d
Merge pull request #3343
...
3d452367
2018-03-05 19:14:03 +02:00
Riccardo Spagni
5b25cbb5a7
Merge pull request #3314
...
71bff546
2018-03-05 19:12:24 +02:00
Riccardo Spagni
4f93f74528
Merge pull request #3277
...
0e7ad2e2af773211cc9a0bee55f8d917450306a0#3318 (stoffu)
9f9e095a#3261 (Jean Pierre Dudey)
2018-03-05 19:11:20 +02:00
Riccardo Spagni
033ead4bad
Merge pull request #3273
...
f3b74e75
2018-03-05 19:11:07 +02:00
Edward Betts
fbcc91c2a4
Correct spelling mistakes.
2018-03-05 17:00:40 +00:00
cryptochangements34
3d452367b0
allow using ring size instead of mixin for rpc transfer
2018-03-05 10:10:35 -05:00
stoffu
0e7ad2e2c9
Wallet API: generalize 'bool testnet' to 'NetworkType nettype'
2018-03-05 23:59:16 +09:00
stoffu
9a6be3da25
wallet_manager: fixed typo deviuce/device.hpp
2018-03-05 11:57:30 +09:00
stoffu
af773211cb
Stagenet
2018-03-05 11:55:05 +09:00
moneromooo-monero
e0cda74ace
wallet2_api: add info/error/warning entry points
2018-03-04 18:07:30 +00:00
cslashm
e745c1e38d
Code modifications to integrate Ledger HW device into monero-wallet-cli.
...
The basic approach it to delegate all sensitive data (master key, secret
ephemeral key, key derivation, ....) and related operations to the device.
As device has low memory, it does not keep itself the values
(except for view/spend keys) but once computed there are encrypted (with AES
are equivalent) and return back to monero-wallet-cli. When they need to be
manipulated by the device, they are decrypted on receive.
Moreover, using the client for storing the value in encrypted form limits
the modification in the client code. Those values are transfered from one
C-structure to another one as previously.
The code modification has been done with the wishes to be open to any
other hardware wallet. To achieve that a C++ class hw::Device has been
introduced. Two initial implementations are provided: the "default", which
remaps all calls to initial Monero code, and the "Ledger", which delegates
all calls to Ledger device.
2018-03-04 12:54:53 +01:00
stoffu
71bff546d3
wallet api: when restoring from EnglishOld, set language to English
2018-02-25 22:04:36 +09:00
rbrunner7
430268224d
Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows
2018-02-25 12:57:58 +01:00
Riccardo Spagni
2ac3da1251
Merge pull request #3256
...
df5273de
2018-02-20 17:53:38 +02:00
Riccardo Spagni
cfa3af4078
Merge pull request #3247
...
89ad162af2c4c399
2018-02-20 17:46:40 +02:00
Riccardo Spagni
6920fdaf4f
Merge pull request #3246
...
3c33e1310133b348
2018-02-20 17:46:29 +02:00
Riccardo Spagni
0fc5eec9cd
Merge pull request #3235
...
6866ed46
2018-02-20 17:46:00 +02:00
moneromooo-monero
89ad162a3f
wallet2: remove unused m_subaddresses_inv
2018-02-16 17:13:09 +00:00
moneromooo-monero
f2c4c39971
wallet2: speed up subaddress generation (by about a third)
2018-02-16 17:13:06 +00:00
Howard Chu
f3b74e75b0
Fix refresh height estimation
...
Since commit b0426d4c
2018-02-16 14:17:36 +00:00
Riccardo Spagni
9c4428e583
Merge pull request #3214
...
214d251c
2018-02-16 14:22:41 +01:00
Riccardo Spagni
9681a885d1
Merge pull request #3207
...
a99ef17677125096
2018-02-16 14:21:59 +01:00
Riccardo Spagni
b23578e473
Merge pull request #3197
...
f90c76be3cb65b3f
2018-02-16 14:21:00 +01:00
Riccardo Spagni
82599ef0e3
Merge pull request #3175
...
3be98036
2018-02-16 14:19:24 +01:00
Riccardo Spagni
5d36ed6613
Merge pull request #3094
...
a85dbb3f
2018-02-16 14:17:46 +01:00
moneromooo-monero
df5273def5
wallet2: fix auto_low_priority field name typo on load
2018-02-13 00:33:55 +00:00
stoffu
3c33e1317b
wallet2: don't store invalid key image when watch-only
2018-02-12 20:36:15 +09:00
stoffu
0133b3481a
wallet2: don't throw when spent amount is inconsistent
2018-02-10 12:59:25 +09:00
stoffu
214d251c48
wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrown
2018-02-08 08:02:12 +09:00
Michał Sałaban
6866ed469a
Add default value to max_height, otherwise it's 0
2018-02-05 23:39:37 +01:00
moneromooo-monero
19ff243f52
wallets: reorg 61 more days on testnet
2018-01-31 15:52:43 +00:00
moneromooo-monero
c70f03cacf
blockchain: move bulletproofs to v8
...
and set v7 height to 1057027 on testnet (one block earlier)
This is to easily dump current nodes since we're going to change
the v7 rules with this.
2018-01-31 15:52:39 +00:00
stoffu
a99ef17695
wallet-rpc: take subaddress account as arg for get_transfer_by_txid
2018-01-31 17:53:02 +09:00
stoffu
7712509644
wallet-rpc: rename *_INDEX_OUTOFBOUND into *_INDEX_OUT_OF_BOUNDS
2018-01-31 17:52:31 +09:00
Maxithi
a85dbb3f2f
Fixed typos and wording tweaks
2018-01-29 12:13:23 +01:00
Michał Sałaban
f90c76beb4
Return appropriate error code when there's no connection to daemon
2018-01-29 08:28:25 +01:00
Michał Sałaban
3cb65b3f69
Return appropriate error code when not enough money for tx
2018-01-28 12:52:05 +01:00
stoffu
30c44bce06
wallet: automatically use low priority if safe (no backlog & recent blocks not full)
2018-01-28 11:04:52 +09:00
moneromooo-monero
2f5a9b6bb3
wallet2: split estimate_backlog to allow for raw fee levels
2018-01-28 10:52:16 +09:00
Riccardo Spagni
d061c312fb
Merge pull request #3116
...
269ba252
2018-01-27 17:27:07 -08:00
Riccardo Spagni
1506f33075
Merge pull request #3142
...
a9cae0ab
2018-01-27 17:25:25 -08:00
Riccardo Spagni
5603d5aaea
Merge pull request #3141
...
3160a9307d1088d3bc1ee2c2
2018-01-27 17:25:15 -08:00
Riccardo Spagni
d3e1244466
Merge pull request #3121
...
6fbb0b06
2018-01-27 17:24:57 -08:00
Riccardo Spagni
e1ba5b95c1
Merge pull request #3118
...
ca336c62
2018-01-27 17:24:34 -08:00
Riccardo Spagni
92ea8af34d
Merge pull request #3114
...
fb5c971c
2018-01-27 17:24:26 -08:00
Riccardo Spagni
73a19e0b06
Merge pull request #3113
...
ffc2e570
2018-01-27 17:24:15 -08:00
Riccardo Spagni
087a773247
Merge pull request #3104
...
939629e8
2018-01-27 17:24:08 -08:00
xmr-eric
84a7f6a482
Readd copyright starting date
2018-01-26 10:03:20 -05:00
xmr-eric
18216f19dd
Update 2018 copyright
2018-01-26 10:03:20 -05:00
stoffu
a9cae0abe7
Wallet API: remove unused enum Priority from UnsignedTransaction
2018-01-26 10:59:49 +09:00
stoffu
3160a93027
wallet2: remove {set|get}_default_decimal_point and use the same funcs under cryptonote:: instead
2018-01-26 10:59:32 +09:00
stoffu
7d1088d337
wallet2: make scan_output const and omit keys arg
2018-01-26 10:59:31 +09:00
stoffu
bc1ee2c2ee
wallet2: make member functions const when possible
2018-01-26 10:59:30 +09:00
stoffu
ffc2e5705d
wallet rpc: show fees when querying incoming transfers
2018-01-26 10:58:23 +09:00
stoffu
ca336c62e3
simplewallet: check file overwrite when exporting stuff
2018-01-26 10:57:13 +09:00
Riccardo Spagni
09d19c9139
Merge pull request #3130
...
5ae617d5c1d19f3c
2018-01-25 16:57:03 -08:00
Riccardo Spagni
f31f5c9a3e
Merge pull request #3093
...
d188840c
2018-01-25 16:49:54 -08:00
Riccardo Spagni
66a2751d68
Merge pull request #3065
...
3e635a3c
2018-01-25 16:47:08 -08:00
Riccardo Spagni
008b492963
Merge pull request #3047
...
fa5c0bab#3045 , fixing RPC snakecases (Nick Johnson)
2018-01-25 16:45:45 -08:00
Riccardo Spagni
153e319cd4
Merge pull request #3038
...
eb39a3d7
2018-01-25 16:44:23 -08:00
Riccardo Spagni
b2ce5739df
Merge pull request #3028
...
a4b006f9
2018-01-25 16:42:06 -08:00
Riccardo Spagni
960b32ba70
Merge pull request #3027
...
6d40a920
2018-01-25 16:40:59 -08:00
Riccardo Spagni
f077bbb4f1
Merge pull request #3010
...
07da9c80
2018-01-25 16:32:40 -08:00
Maximilian Lupke
3be98036e7
wallet-cli: Do not ask for scan_from_height if it explicitly is set to zero.
...
Fixes #3080
2018-01-24 18:01:08 +01:00
m2049r
939629e837
Wallet API: all recover options with password
...
also renamed memo => mnemonic in api method parms
2018-01-17 18:46:31 +01:00
moneromooo-monero
c1d19f3c84
wallet2: fix sweep_all sending an atomic unit
2018-01-15 15:54:19 +00:00
redfish
6fbb0b065d
cmake: set API header install path to what Qt wallet expects
2018-01-14 20:14:07 -05:00
Jaquee
269ba25228
wallet2::import_blockchain fix import loop
2018-01-14 20:30:35 +01:00
Michał Sałaban
fb5c971cc6
Allow retrieving spend key via RPC
2018-01-14 06:23:12 +01:00
stoffu
6d40a92026
Reserve proof
2018-01-10 20:37:18 +09:00
Riccardo Spagni
00f4ff26c8
Merge pull request #3021
...
dc6729a6
2018-01-10 11:55:19 +01:00
Riccardo Spagni
990389f09d
Merge pull request #3002
...
9996d5e9eadaa6aa
2018-01-10 11:54:11 +01:00
Riccardo Spagni
f9c66ba67c
Merge pull request #2990
...
2d17feb0
2018-01-10 11:53:05 +01:00
Riccardo Spagni
6c7eb5109d
Merge pull request #2989
...
66eeeaa1
2018-01-10 11:52:49 +01:00
Riccardo Spagni
ab8a32429a
Merge pull request #2985
...
6d8b29effdd4c5e540ab12a7
2018-01-10 11:50:58 +01:00
Riccardo Spagni
3ce7f2bead
Merge pull request #2983
...
6fc4fc85
2018-01-10 11:50:36 +01:00
Riccardo Spagni
420a803ff8
Merge pull request #2973
...
277a5aef
2018-01-10 11:48:42 +01:00
moneromooo-monero
fdd4c5e577
move memwipe to epee to avoid common<->crypto circular dependencies
2018-01-10 01:57:54 +00:00
moneromooo-monero
40ab12a773
epee: remove dependency on common
2018-01-10 01:57:51 +00:00
Maxithi
d188840cc2
Improved terminology from create to generate
2018-01-09 21:46:44 +01:00
Nick Johnson
fa5c0bab44
Implement #3045 , fixing RPC snakecases
2018-01-06 15:11:36 -06:00
moneromooo-monero
3e635a3cef
wallet2: allow failing parse_tx_extra
...
It can fail if it fails to parse extra, while still having filled
the returned data with partial contents
2018-01-04 15:38:49 +00:00
Riccardo Spagni
803f54b9fd
Merge pull request #2967
...
55556fab
2018-01-02 00:31:30 +02:00
Riccardo Spagni
ee02c7ab03
Merge pull request #2962
...
14c29814
2018-01-02 00:30:01 +02:00
Riccardo Spagni
eb617be8f4
Merge pull request #2960
...
5cbcf0aa
2018-01-02 00:29:36 +02:00
moneromooo-monero
eb39a3d7d3
wallet_api: make this optional but not built by default
...
It means it can still be built with make -C build/debug wallet_api
but still not DoS us while debugging
2017-12-31 11:14:20 +00:00
stoffu
a4b006f965
wallet2 bugfix: initialize subaddress table when generating from keys
2017-12-29 15:53:28 +09:00
moneromooo-monero
dc6729a66a
wallet2: std::unordered_set ctor is sometimes explicit
2017-12-28 10:20:12 +00:00
Riccardo Spagni
5f562cf9e6
Merge pull request #2941
...
d0d38dc8
2017-12-28 08:58:30 +02:00
stoffu
6fc4fc850e
sweep_below: do not prematurely exclude subaddresses set
2017-12-28 07:52:53 +09:00
Michał Sałaban
07da9c806d
Resolve addresses in get_transfers
2017-12-27 01:35:48 +01:00
stoffu
e3530789d3
wallet-api: added Utils::onStartup
2017-12-26 08:23:32 +09:00
Riccardo Spagni
40df4905fd
Merge pull request #3006
...
7e7b1a82
2017-12-25 22:08:56 +02:00
moneromooo-monero
7e7b1a8252
Revert "return subaddress in get_bulk_payments"
...
This reverts commit b60f48f0e3
2017-12-25 20:04:40 +00:00
Riccardo Spagni
ca8c7e863f
Merge pull request #2895
...
5ad312a11e5491e9
2017-12-25 22:00:44 +02:00
Riccardo Spagni
0a5bfa7c73
Merge pull request #2938
...
aaae94f0
2017-12-25 21:42:22 +02:00
moneromooo-monero
5ad312a1c3
wallet2: switch to chacha20 instead of chacha8
...
Wallet caches and keys files are loaded with chacha8 as needed,
but only saved with chacha20. Other data (eg, cold wallet data
files, etc) will be incompatible.
2017-12-25 19:28:06 +00:00
moneromooo-monero
1e5491e942
Add a chacha20 variant to go with chacha8
2017-12-25 19:28:03 +00:00
Riccardo Spagni
409e9bb029
Merge pull request #2931
...
04349492
2017-12-25 21:21:00 +02:00
Riccardo Spagni
db09247c68
Merge pull request #2926
...
6b5bd129
2017-12-25 21:19:33 +02:00
Riccardo Spagni
2b00899bb2
Merge pull request #2920
...
bd5cce07e0a6129924f584d9b1634aa38e60b81c213e326cb51dc566f0568ca6b49ddc762305bf26a4240d9f45a1c4c056fa6ce1b4524892c2ed8618187a6ab2061789b5ba2fefb938c8f4e0d753d716fe568db846d6fa3525584f86490a5d41
2017-12-25 21:17:52 +02:00
Riccardo Spagni
8b40bc27a2
Merge pull request #2916
...
a9217641
2017-12-25 21:17:16 +02:00
