4rkal/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-16 13:26:31 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
9,117 Commits 9 Branches 69 Tags 249 MiB
1a6e7bd40f
Commit Graph

1909 Commits

Author SHA1 Message Date
moneromooo-monero
b750fb27b0
Pruning 
The blockchain prunes seven eighths of prunable tx data.
This saves about two thirds of the blockchain size, while
keeping the node useful as a sync source for an eighth
of the blockchain.

No other data is currently pruned.

There are three ways to prune a blockchain:

- run monerod with --prune-blockchain
- run "prune_blockchain" in the monerod console
- run the monero-blockchain-prune utility

The first two will prune in place. Due to how LMDB works, this
will not reduce the blockchain size on disk. Instead, it will
mark parts of the file as free, so that future data will use
that free space, causing the file to not grow until free space
grows scarce.

The third way will create a second database, a pruned copy of
the original one. Since this is a new file, this one will be
smaller than the original one.

Once the database is pruned, it will stay pruned as it syncs.
That is, there is no need to use --prune-blockchain again, etc.
 2019-01-22 20:30:51 +00:00
moneromooo-monero
9d58749b85
wallet2: fix hashchain going out of sync on refresh error 2019-01-19 16:47:13 +00:00
Riccardo Spagni
4e72384318
Merge pull request #5008 
c6d38718 core: include a dummy encrypted payment id when no payment is used (moneromooo-monero)
b7441c4a core, wallet: remember original text version of destination address (moneromooo-monero)
a9b1c04a crptonote_core: do not error out sending unparsable extra field (moneromooo-monero)
 2019-01-18 19:12:58 +02:00
Riccardo Spagni
8ba36cf6d4
Merge pull request #5049 
0a29660f message_store: init me field (moneromooo-monero)
 2019-01-18 19:01:23 +02:00
moneromooo-monero
b7441c4a32
core, wallet: remember original text version of destination address 2019-01-18 16:58:47 +00:00
moneromooo-monero
0debe7d7d3
wallet2: remember which output keys map to which key images 
This allows filling in transfer_details when a cold signed tx
gets seen in a block next
 2019-01-16 19:58:13 +00:00
Riccardo Spagni
c84d559fb1
Merge pull request #5034 
13785ec9 wallet api/device: set estimated restore height if none is provided (selsta)
 2019-01-16 21:40:20 +02:00
Riccardo Spagni
3eb96fa512
Merge pull request #5027 
9092fc4b wallet: do not display daemon controlled text if untrusted (moneromooo-monero)
 2019-01-16 21:38:15 +02:00
Riccardo Spagni
00090aae7f
Merge pull request #5012 
d7354c78 wallet_rpc_server: add all field to export_key_images (moneromooo-monero)
 2019-01-16 21:31:40 +02:00
Riccardo Spagni
e0c107ee51
Merge pull request #5004 
de9dcdd1 wallet2: finalize_multisig now rejects non N-1/N multisig wallets (moneromooo-monero)
 2019-01-16 19:28:51 +02:00
Riccardo Spagni
8e04070d9d
Merge pull request #4995 
99765b21 Remove unused hash in export_key_images (doy-lee)
 2019-01-16 19:08:48 +02:00
Riccardo Spagni
538043bdcd
Merge pull request #4987 
841a6acd wallet2: fix accessing unwound stack on exception (moneromooo-monero)
 2019-01-16 19:07:13 +02:00
Riccardo Spagni
63b5c933ef
Merge pull request #4985 
808a1f1e wallet2: cut down on the number of useless derivation threads (moneromooo-monero)
 2019-01-16 19:06:31 +02:00
Riccardo Spagni
a193f1e236
Merge pull request #4980 
219548f2 Sync hashchain bug fixed (naughtyfox)
 2019-01-16 19:05:09 +02:00
Riccardo Spagni
b565115c84
Merge pull request #4979 
611db08a Wallet: Initialize members without default ctor. (Tadeas Moravec)
 2019-01-16 19:04:45 +02:00
selsta
b8c5f550c1
wallet api: don't truncate address in subaddress_account 
Same behaviour as subaddress.cpp now.
 2019-01-15 22:19:50 +01:00
moneromooo-monero
96e35506e9
wallet2: fix incorrect patch for determining fork rules 
Half of the patch was correct, but half was introducing another bug,
where a wallet asking for a fork that the daemon does not know about
yet would decide to use those rules.
 2019-01-13 14:48:16 +00:00
moneromooo-monero
2112060d03
wallet2: fix duplicate tx notifications for pool txes 2019-01-13 14:47:42 +00:00
moneromooo-monero
8258a9e7a9
wallet: do not check txpool in background mode 
This avoids the constant message about needed to run refresh
to enter a password.
Also mention the txpool when asking for the password if the
reason is a pool tx.
 2019-01-09 11:21:39 +00:00
Riccardo Spagni
094b0c4d00
Merge pull request #5045 
050ee521 wallet_api: fix usage of LOG_ERROR (moneromooo-monero)
 2019-01-07 21:27:34 +02:00
Riccardo Spagni
53fba1455c
Merge pull request #5007 
68f095f0 message_store: fix error message adding const char * with offset (moneromooo-monero)
 2019-01-07 21:26:52 +02:00
moneromooo-monero
0a29660f5c
message_store: init me field 
Coverity 190651
 2019-01-07 16:41:34 +00:00
moneromooo-monero
050ee52162
wallet_api: fix usage of LOG_ERROR 2019-01-07 11:57:10 +00:00
Riccardo Spagni
b67eb481a7
Merge pull request #4956 
2d7b0236 wallet2: clear all payments on soft rescan_bc (moneromooo-monero)
 2019-01-06 20:40:06 +02:00
selsta
13785ec96b
wallet api/device: set estimated restore height if none is provided 2019-01-02 11:25:49 +01:00
moneromooo-monero
5dc590cbdb
wallet2: speedup output tracking 
It can get heavy for large wallets
 2018-12-31 23:57:54 +00:00
moneromooo-monero
db3f2a91fa
wallet: optionally keep track of owned outputs uses 2018-12-31 23:57:51 +00:00
luigi1111
9c2d671397
Merge pull request #4945 
e37154a build: protobuf dependency fixes, libusb build (ph4r05)
 2018-12-31 15:53:59 -06:00
moneromooo-monero
9092fc4bfd
wallet: do not display daemon controlled text if untrusted 2018-12-30 01:32:57 +00:00
moneromooo-monero
d7354c7864
wallet_rpc_server: add all field to export_key_images 
To use if you want all key images, not just the ones for
recently imported outputs
 2018-12-24 13:00:29 +00:00
moneromooo-monero
68f095f059
message_store: fix error message adding const char * with offset 2018-12-22 15:52:10 +00:00
moneromooo-monero
de9dcdd179
wallet2: finalize_multisig now rejects non N-1/N multisig wallets 2018-12-21 23:41:16 +00:00
doy-lee
99765b218e Remove unused hash in export_key_images 2018-12-19 14:45:13 +11:00
Dusan Klinec
e37154a879
build: protobuf dependency fixes, libusb build 
- docker protobuf dependencies, cross-compilation
- device/trezor protobuf build fixes, try_compile
- libusb built under all platforms, used by trezor for direct connect
 2018-12-18 16:50:19 +01:00
moneromooo-monero
808a1f1e8a
wallet2: cut down on the number of useless derivation threads 2018-12-16 18:31:10 +00:00
moneromooo-monero
841a6acda2
wallet2: fix accessing unwound stack on exception 2018-12-16 18:30:02 +00:00
naughtyfox
219548f299 Sync hashchain bug fixed 2018-12-14 17:42:11 +03:00
Tadeas Moravec
611db08a00
Wallet: Initialize members without default ctor. 
Found by Coverity (188336 in Anonimal's Coverity account).
 2018-12-14 13:45:41 +00:00
rbrunner7
1ebcd7b9b0 MMS (Multisig Messaging System): Initial version 2018-12-12 21:49:20 +01:00
Riccardo Spagni
0b31baf6e4
Merge pull request #4839 
d71f89e2 device/trezor: device/trezor: correct device initialization, status check (Dusan Klinec)
65b9bca7 device/trezor: python2 compatibility - bundle dependencies (Dusan Klinec)
9cf636af device/trezor: ask for KI sync on first refresh (Dusan Klinec)
d21dad70 device: enable to use multiple independent device wallets (Dusan Klinec)
318cc784 device/trezor: passphrase entry on host (Dusan Klinec)
 2018-12-12 11:53:42 +02:00
moneromooo-monero
2d7b0236eb
wallet2: clear all payments on soft rescan_bc 
They'll get duplicated otherwise
 2018-12-08 10:39:54 +00:00
Dusan Klinec
9cf636af69
device/trezor: ask for KI sync on first refresh 
When doing a first refresh on HW-token based wallet KI sync is required if money were received. Received money may indicate wallet was already used before the restore I.e., some transaction could have been already sent from the wallet. The spent UTXO would not be detected as spent which could lead to double spending errors on submitting a new transaction.

Thus if the wallet is HW-token based with the cold signing protocol and the first refresh detected received money the user is asked to perform the key image sync.
 2018-12-04 18:38:17 +01:00
Dusan Klinec
d21dad70dd
device: enable to use multiple independent device wallets 
- adds a new option `--hw-device-deriv-path` to the simple wallet. Enables to specify wallet derivation path / wallet code (path avoided so it can be misinterpreted as a file path).
- devices can use different derivation mechanisms. Trezor uses standard SLIP-10 mechanism with fixed SLIP-44 prefix for Monero
- Trezor: when empty, the default derivation mechanism is used with 44'/128'/0'. When entered the derivation path is 44'/128'/PATH.
- Trezor: the path is always taken as elements are hardened (1<<31 bit turned on)
 2018-12-04 18:38:16 +01:00
Riccardo Spagni
81418cb281
Merge pull request #4894 
aee7a4e3 wallet_rpc_server: do not use RPC data if the call failed (moneromooo-monero)
1a0733e5 windows_service: fix memory leak (moneromooo-monero)
0dac3c64 unit_tests: do not rethrow a copy of an exception (moneromooo-monero)
5d9915ab cryptonote: fix get_unit for non default settings (moneromooo-monero)
d4f50cb1 remove some unused code (moneromooo-monero)
61163971 a few minor (but easy) performance tweaks (moneromooo-monero)
30023074 tests: slow_memmem now returns size_t (moneromooo-monero)
 2018-12-04 17:33:19 +02:00
Riccardo Spagni
6e74aa9a6c
Merge pull request #4885 
b5573fc2 wallet2: resume processing when tx extra is partially broken (stoffu)
 2018-12-04 17:31:27 +02:00
Riccardo Spagni
1bebe99496
Merge pull request #4884 
56e616e8 wallet2: add n_vouts to capture list (moneromooo-monero)
 2018-12-04 17:31:15 +02:00
Riccardo Spagni
c00ac446fd
Merge pull request #4854 
bd98e99c Removed a lot of unnecessary includes (Martijn Otto)
 2018-12-04 17:08:42 +02:00
Riccardo Spagni
398f7076bb
Merge pull request #4853 
2b3595d0 various: do not propagate exception through dtor (moneromooo-monero)
 2018-12-04 17:07:51 +02:00
Riccardo Spagni
94288d7d1d
Merge pull request #4845 
6732fc7f Fix issue 4793 - M/N multisig transaction signature (naughtyfox)
 2018-12-04 17:06:04 +02:00
Dusan Klinec
318cc78457
device/trezor: passphrase entry on host 
- simple device callback object added. Device can request passphrase/PIN entry via the callback or notify user some action is required
- callback is routed to wallet2, which routes the callback to i_wallet_callback so CLI or GUI wallets can support passphrase entry for HW tokens
- wallet: device open needs wallet callback first - passphrase protected device needs wallet callback so user can enter passphrase
 2018-11-29 04:33:41 +01:00
Riccardo Spagni
58ce16d4d9
Merge pull request #4821 
fc98f7a0 rpc: speedup get_outs.bin (moneromooo-monero)
 2018-11-26 21:51:27 +02:00
moneromooo-monero
fc98f7a0a1
rpc: speedup get_outs.bin 2018-11-26 18:56:23 +00:00
Riccardo Spagni
eccb9b08c4
Merge pull request #4825 
b9b307d1 rpc: speedup get_output_distribution (moneromooo-monero)
 2018-11-26 20:28:02 +02:00
Riccardo Spagni
cc1ea0b651
Merge pull request #4816 
1a4d1603 wallet2: remove redundant chacha key generation in store_keys (stoffu)
 2018-11-26 20:25:39 +02:00
moneromooo-monero
aee7a4e364
wallet_rpc_server: do not use RPC data if the call failed 
Found by codacy.com
 2018-11-23 15:38:00 +00:00
moneromooo-monero
d4f50cb109
remove some unused code 
Found by codacy.com
 2018-11-23 15:37:36 +00:00
moneromooo-monero
611639710d
a few minor (but easy) performance tweaks 
Found by codacy.com
 2018-11-23 15:36:48 +00:00
stoffu
b5573fc231
wallet2: resume processing when tx extra is partially broken 
Motivated by https://monero.stackexchange.com/questions/10483

Some exchanges appear to have customized the wallet software
in an inappropriate way, making the tx extra field partially
unreadable. PR #3716 changed the wallet behavior disallowing
such partially valid tx extra.

An example tx reported by the user is
e87c675a85f34ecac58a8846613d25062f1813e1023c552b705afad32b972c38
where the normal tx pubkey appears again with the aditional
tx pubkeys tag `04` which is inappropriate.
 2018-11-22 14:51:35 +09:00
moneromooo-monero
56e616e855
wallet2: add n_vouts to capture list 2018-11-22 01:45:45 +00:00
naughtyfox
6732fc7fde Fix issue 4793 - M/N multisig transaction signature 2018-11-20 16:50:41 +03:00
moneromooo-monero
b9b307d11a
rpc: speedup get_output_distribution 
and decrease the amount of data carried around
 2018-11-20 10:11:25 +00:00
Riccardo Spagni
056abf980e
Merge pull request #4801 
7ae36e91 wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed (stoffu)
 2018-11-16 11:13:09 +02:00
Riccardo Spagni
f9c60736b8
Merge pull request #4794 
e198b06e Fix: out_of_hashchain_bounds_error in refresh (Hasan Pekdemir)
 2018-11-16 11:10:20 +02:00
Riccardo Spagni
9aff9a5372
Merge pull request #4790 
177a9d76 wallet: warn if lockable memory limit is too low (moneromooo-monero)
 2018-11-16 11:08:07 +02:00
Riccardo Spagni
20bf9b93dd
Merge pull request #4789 
0afdb00b wallet2: fix print_ring printing double entries for transactions (moneromooo-monero)
 2018-11-16 11:07:40 +02:00
Riccardo Spagni
c8cc65f30a
Merge pull request #4788 
8f3963d2 wallet2: demote a few uninteresting recurring logs to TRACE (moneromooo-monero)
 2018-11-16 11:07:21 +02:00
Riccardo Spagni
4561119846
Merge pull request #4784 
1c04c21d wallet_rpc_server: include additional tx keys in sign_transfer response (stoffu)
 2018-11-16 11:05:31 +02:00
Riccardo Spagni
95d96d139d
Merge pull request #4764 
1598f01c wallet2: use padded bulletproofs for multisig signing (stoffu)
 2018-11-16 10:58:29 +02:00
Martijn Otto
bd98e99c80
Removed a lot of unnecessary includes 2018-11-15 17:29:34 +01:00
moneromooo-monero
2b3595d0fe
various: do not propagate exception through dtor 
Coverity 189689, 189690, 189692, 189695
 2018-11-15 15:53:21 +00:00
Riccardo Spagni
33ad6fb4c1
Merge pull request #4761 
6e1282b6 wallet2: fix off by one in output picking (moneromooo-monero)
 2018-11-14 21:34:51 +02:00
Riccardo Spagni
59e8a4c306
Merge pull request #4753 
157054b8 hardfork: initialize current_fork_index in ctor (moneromooo-monero)
2362baf7 network_throttle: initialize m_last_sample_time in ctor (moneromooo-monero)
d9400f69 serializtion: add missing mainnet and stagenet fields for 0mq (moneromooo-monero)
cbe0122b wallet2: initialize amount to 0 in tx_scan_info_t ctor (moneromooo-monero)
 2018-11-14 21:33:02 +02:00
Riccardo Spagni
dd42b642ee
Merge pull request #4746 
f3019efe wallet-rpc: add on_restore_deterministic RPC call. (Hasan Pekdemir)
 2018-11-14 21:31:08 +02:00
Riccardo Spagni
8534f71eed
Merge pull request #4814 
840bf155 build: fix Ubuntu 16.04 (GCC 5.4.0) compilation (xiphon)
 2018-11-07 15:02:56 +02:00
stoffu
ba2055a220
api/wallet: fix compile errors made in #4720 2018-11-07 15:12:24 +09:00
stoffu
1a4d160311
wallet2: remove redundant chacha key generation in store_keys 2018-11-07 10:47:10 +09:00
xiphon
840bf155a0 build: fix Ubuntu 16.04 (GCC 5.4.0) compilation 2018-11-06 21:45:00 +00:00
Riccardo Spagni
a9e03ebc6a
Merge pull request #4809 
1fd017cf Fix build of monero-gui by adding device_trezor to wallet_merged (buricl)
 2018-11-06 21:35:08 +02:00
Riccardo Spagni
a369a13928
Merge pull request #4743 
9335d5a2 wallet2: save ring in the ringdb once a tx is created (moneromooo-monero)
 2018-11-06 21:33:22 +02:00
Riccardo Spagni
d210d6fb45
Merge pull request #4738 
107f3398 wallet2: fix ring reuse breaking when using histogram (moneromooo-monero)
 2018-11-06 21:31:32 +02:00
Riccardo Spagni
164ba3ef1c
Merge pull request #4731 
f26ce08c wallet: add a non destructive blockchain rescan (moneromooo-monero)
 2018-11-06 21:30:12 +02:00
Riccardo Spagni
b789f7e10d
Merge pull request #4729 
e86af52e wallet2: rewrite keys file in a safer manner (Nathan Dorfman)
 2018-11-06 15:09:45 +02:00
Riccardo Spagni
1667d41064
Merge pull request #4728 
1f35de23 simplewallet: display locked/unlocked state in show_transfers (moneromooo-monero)
 2018-11-06 14:54:17 +02:00
buricl
1fd017cf77 Fix build of monero-gui by adding device_trezor to wallet_merged 2018-11-06 00:17:22 +01:00
moneromooo-monero
6e1282b600
wallet2: fix off by one in output picking 
and take into account wallet level minimum spend age
 2018-11-05 20:13:00 +00:00
stoffu
7ae36e91f6
wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed 
Followup on #4653
 2018-11-05 12:13:15 +09:00
moneromooo-monero
8d71b2b1b3
wallet2: only export necessary outputs and key images 
and disable annoying test that requires ridiculous amounts
of skullduggery every time some format changes
 2018-11-04 22:27:01 +00:00
moneromooo-monero
769ae42a7b
wallet2: faster output and key image import/export 2018-11-04 22:26:59 +00:00
Riccardo Spagni
7e2483e1d5
Merge pull request #4702 
70877b1d wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc (Paul Shapiro)
 2018-11-04 20:47:25 +02:00
Riccardo Spagni
ae919a1e15
Merge pull request #4691 
7f0dd094 wallet2: sanity check rct output distribution from the daemon (moneromooo-monero)
 2018-11-04 20:45:59 +02:00
Riccardo Spagni
0c7086bf7f
Merge pull request #4687 
6097472a Update ZMQ fee estimate and add ZMQ output distribution (Lee Clagett)
 2018-11-04 20:44:49 +02:00
Riccardo Spagni
d394c50f7b
Merge pull request #4686 
cf646e3a wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr (Paul Shapiro)
 2018-11-04 20:44:27 +02:00
Riccardo Spagni
9cf0e67978
Merge pull request #4685 
76681b9b wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args (Paul Shapiro)
 2018-11-04 20:44:00 +02:00
Hasan Pekdemir
e198b06e7a Fix: out_of_hashchain_bounds_error in refresh 
15:43 < hahsun> Im on stagenet and I suddenly get this exception: 2018-11-04 14:42:52.416 [RPC0] ERROR wallet.wallet2 src/wallet/wallet2.cpp:2070 !m_blockchain.is_in_bounds(current_index). THROW EXCEPTION: error::out_of_hashchain_bounds_error
16:01 <+moneromooo> OK, possibly because the blckchain is always seeded with the genesis block hash...
16:02 <+moneromooo> So that case should be allowed, assuming it doesn't break the code around it.
16:05 <+moneromooo> OK if stop_height == size || (size==1 && stop_heigt ==0)
16:05 <+moneromooo> Throw if not that.
16:06 < hahsun> k
 2018-11-04 17:07:30 +01:00
moneromooo-monero
177a9d76f9
wallet: warn if lockable memory limit is too low 2018-11-03 20:09:28 +00:00
moneromooo-monero
f26ce08c8a
wallet: add a non destructive blockchain rescan 2018-11-03 15:04:37 +00:00
moneromooo-monero
8f3963d200
wallet2: demote a few uninteresting recurring logs to TRACE 2018-11-03 11:51:03 +00:00
moneromooo-monero
0afdb00b9d
wallet2: fix print_ring printing double entries for transactions 
When a tx gets from unconfirmed to conirmed, the rings for that
transaction were being added twice
 2018-11-03 11:50:38 +00:00
Dusan Klinec
29ffb6bba8
device/trezor: trezor support added 2018-11-02 21:36:39 +01:00
stoffu
1c04c21d6e
wallet_rpc_server: include additional tx keys in sign_transfer response 
Followup on #4552
 2018-11-02 21:42:02 +09:00
Riccardo Spagni
3ceeac50da
Merge pull request #4653 
ade369f9 Add RPC error code for non-deterministic wallet (Michał Sałaban)
 2018-11-01 22:33:20 +02:00
stoffu
1598f01caf
wallet2: use padded bulletproofs for multisig signing 
Analogous to #4540
 2018-10-31 20:01:25 +09:00
Hasan Pekdemir
f3019efe1b wallet-rpc: add on_restore_deterministic RPC call. 2018-10-29 18:19:42 +01:00
moneromooo-monero
cbe0122bf1
wallet2: initialize amount to 0 in tx_scan_info_t ctor 
It seems the more prudent thing to do here. It will not catch
attempts to use that value before it is initialized when using
ASAN or valgrind, but in a case where it does, it will have
smaller repercussions.

So it seems appropriate in this particular case.

Coverity 182498
 2018-10-29 16:22:55 +00:00
Nathan Dorfman
e86af52e2f wallet2: rewrite keys file in a safer manner 2018-10-28 09:58:54 -06:00
moneromooo-monero
9335d5a297
wallet2: save ring in the ringdb once a tx is created 
Even if it is never relayed, it ensures a daemon supplying
fake outs on demand will never be asked for a set with the
real input being the only intersecting member (only a problem
with people who trust their privacy to some stranger's node,
but it seems to be a massively common thing, even in Monero)
 2018-10-27 17:59:56 +00:00
moneromooo-monero
107f33985d
wallet2: fix ring reuse breaking when using histogram 2018-10-27 14:35:00 +00:00
Riccardo Spagni
fc06c5daf8
Merge pull request #4617 
3ffbec15 rpc: init m_rpc_version in Message ctor (moneromooo-monero)
bfa2dce1 rpc: remove unused ctors (moneromooo-monero)
7cc39845 account: init creation timestamp to 0 (moneromooo-monero)
32123789 wallet2: initialize some scalar fields in ctor where appropriate (moneromooo-monero)
4eca42b2 blockchain_db: initialize m_hardfork in ctor just in case (moneromooo-monero)
 2018-10-26 22:39:00 +02:00
Riccardo Spagni
148d14164e
Merge pull request #4615 
a7960542 WalletAPI: rescanBlockchain, rescanBlockchainAsync (mmitkevich)
 2018-10-26 22:38:41 +02:00
Riccardo Spagni
c761bee764
Merge pull request #4561 
04ddf02e Return appropriate RPC error code when key image signature check fails (Michał Sałaban)
 2018-10-26 22:33:35 +02:00
Riccardo Spagni
169e6e9074
Merge pull request #4552 
67e76aa0 wallet_rpc_server: optionally return tx keys in sign_transfer (moneromooo-monero)
 2018-10-26 22:32:34 +02:00
Riccardo Spagni
659cf52a61
Merge pull request #4539 
977fc1bc wallet_rpc_server: add describe_transfer RPC (moneromooo-monero)
 2018-10-26 22:20:57 +02:00
moneromooo-monero
1f35de2300
simplewallet: display locked/unlocked state in show_transfers 
it doesn't display the details, which are already displayed
in show_transfer
 2018-10-25 23:02:42 +00:00
Lee Clagett
6097472a19 Update ZMQ fee estimate and add ZMQ output distribution 2018-10-23 23:46:31 -04:00
moneromooo-monero
61f83316b3
wallet2: extend fake out picks away from the gamma pick 
in order to unbias selection from blocks with few txes
 2018-10-23 09:06:47 +00:00
Paul Shapiro
70877b1d91 wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc 2018-10-22 18:51:45 -05:00
moneromooo-monero
7f0dd094e7
wallet2: sanity check rct output distribution from the daemon 2018-10-22 14:01:46 +00:00
Paul Shapiro
76681b9bda wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args 2018-10-21 12:44:22 -05:00
Paul Shapiro
cf646e3afe wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr 2018-10-21 12:43:31 -05:00
Riccardo Spagni
ed4b953bb7
Merge pull request #4518 
92a0827e wallet2: make fake out selection messages less spammy (moneromooo-monero)
 2018-10-20 20:39:36 +02:00
Michał Sałaban
ade369f96f Add RPC error code for non-deterministic wallet 2018-10-18 23:14:06 +02:00
moneromooo-monero
99cd6f961a
Rename "blackball" for clarity 
Apparently some people seem to think it's a censorship list...
 2018-10-18 18:45:45 +00:00
Riccardo Spagni
c5be5ca6b4
Merge pull request #4623 
99d45a95 wallet_rpc_server: fix change_wallet_password RPC (moneromooo-monero)
 2018-10-16 18:23:30 +02:00
moneromooo-monero
99d45a9578
wallet_rpc_server: fix change_wallet_password RPC 2018-10-16 15:19:05 +00:00
moneromooo-monero
0cdd4b074e
wallet2_api: fix generating new wallet in the GUI 
It was creating a new wallet without a password first (this should
be fixed), then not changing the password correctly
 2018-10-16 14:46:17 +00:00
moneromooo-monero
3212378912
wallet2: initialize some scalar fields in ctor where appropriate 
Coverity 188336
 2018-10-16 11:58:48 +00:00
mmitkevich
a7960542a9 WalletAPI: rescanBlockchain, rescanBlockchainAsync 2018-10-16 14:58:22 +03:00
Riccardo Spagni
544413de8f
Merge pull request #4577 
d886b97f SOFTWARE is the default wallet device (m2049r)
 2018-10-15 13:31:29 +02:00
m2049r
d886b97fe2
SOFTWARE is the default wallet device 2018-10-13 09:25:49 +02:00
moneromooo-monero
e736964a0c
Remove epee header dependency on cryptonote_core 2018-10-12 17:16:44 +00:00
Michał Sałaban
04ddf02e3a Return appropriate RPC error code when key image signature check fails 2018-10-11 18:12:17 +02:00
moneromooo-monero
67e76aa06c
wallet_rpc_server: optionally return tx keys in sign_transfer 2018-10-10 15:55:35 +00:00
moneromooo-monero
92a0827eea
wallet2: make fake out selection messages less spammy 2018-10-09 21:46:33 +00:00
moneromooo-monero
8833aec083
wallet2: fix cold signing using non padded bulletproofs 
This code was deciding which bulletproof configuration to use
based on ptx which weren't created yet.
 2018-10-09 14:32:38 +00:00
moneromooo-monero
977fc1bceb
wallet_rpc_server: add describe_transfer RPC 
for unsigned tx sets using a view only wallet
 2018-10-09 10:47:32 +00:00
Riccardo Spagni
e19652df51
Merge pull request #4036 
9acf42d3 Multisig M/N functionality core tests added (naughtyfox)
9f3963e8 Arbitrary M/N multisig schemes: * support in wallet2 * support in monero-wallet-cli * support in monero-wallet-rpc * support in wallet api * support in monero-gen-trusted-multisig * unit tests for multisig wallets creation (naughtyfox)
 2018-10-07 19:57:26 +02:00
Guillaume LE VAILLANT
977df6315f Fix some calls to the translation function 
Some strings were not detected by lupdate because "tr() cannot be called without
context".
 2018-10-06 10:26:06 +02:00
Riccardo Spagni
c9fc61dbb5
Merge pull request #4495 
34a85e0c wallet2: disable height based segregation (moneromooo-monero)
 2018-10-05 23:13:15 +02:00
moneromooo-monero
c5928bdec6
wallet2_api: fix build with C++14 2018-10-04 13:42:01 +00:00
moneromooo-monero
34a85e0cc3
wallet2: disable height based segregation 
It can still be enable via DNS if a key reusing fork pops up
 2018-10-03 20:44:48 +00:00
Riccardo Spagni
932a17018a
Merge pull request #4490 
bccd88dd wallet2: clear found out for every tx key (doy-lee)
 2018-10-02 22:41:24 +02:00
Riccardo Spagni
6cb9c815d4
Merge pull request #4484 
2c74b1a1 wallet_rpc_server: include all transfer records for a txid (moneromooo-monero)
 2018-10-02 22:40:51 +02:00
Riccardo Spagni
66094dee00
Merge pull request #4482 
25e5890d wallet: fix --generate-from-json using wrong password (moneromooo-monero)
 2018-10-02 22:39:57 +02:00
doy-lee
bccd88ddf5
wallet2: clear found out for every tx key 
Avoids triggering the sanity check
 2018-10-02 08:53:28 +00:00
naughtyfox
9f3963e823 Arbitrary M/N multisig schemes: 
* support in wallet2
* support in monero-wallet-cli
* support in monero-wallet-rpc
* support in wallet api
* support in monero-gen-trusted-multisig
* unit tests for multisig wallets creation
 2018-10-01 19:16:56 +03:00
moneromooo-monero
2c74b1a1c4
wallet_rpc_server: include all transfer records for a txid 
Since subaddresses were added, a tx can now create more than
one payment
 2018-10-01 14:47:26 +00:00
moneromooo-monero
25e5890d37
wallet: fix --generate-from-json using wrong password 2018-10-01 12:32:26 +00:00
moneromooo-monero
6da36ea057
wallet2_api: blackball/unblackball now take two parameters 
amount and offset (instead of pubkey)
 2018-09-30 08:10:30 +00:00
Riccardo Spagni
83d8f03c23
Merge pull request #4333 
73403004 add --block-notify to monerod and --tx-notify to monero-wallet-{cli,rpc} (moneromooo-monero)
 2018-09-29 22:20:44 +02:00
Riccardo Spagni
4a2664f743
Merge pull request #4461 
7dd11711 wallet2: fix transfers between subaddresses hitting the sanity check (moneromooo-monero)
 2018-09-29 22:20:41 +02:00
Riccardo Spagni
effcbf2060
Merge pull request #4459 
bcf3f6af fuzz_tests: catch unhandled exceptions (moneromooo-monero)
3ebd05d4 miner: restore stream flags after changing them (moneromooo-monero)
a093092e levin_protocol_handler_async: do not propagate exception through dtor (moneromooo-monero)
1eebb82b net_helper: do not propagate exceptions through dtor (moneromooo-monero)
fb6a3630 miner: do not propagate exceptions through dtor (moneromooo-monero)
2e2139ff epee: do not propagate exception through dtor (moneromooo-monero)
0749a8bd db_lmdb: do not propagate exceptions in dtor (moneromooo-monero)
1b0afeeb wallet_rpc_server: exit cleanly on unhandled exceptions (moneromooo-monero)
418a9936 unit_tests: catch unhandled exceptions (moneromooo-monero)
ea7f9543 threadpool: do not propagate exceptions through the dtor (moneromooo-monero)
6e855422 gen_multisig: nice exit on unhandled exception (moneromooo-monero)
53df2deb db_lmdb: catch error in mdb_stat calls during migration (moneromooo-monero)
e67016dd blockchain_blackball: catch failure to commit db transaction (moneromooo-monero)
661439f4 mlog: don't remove old logs if we failed to rename the current file (moneromooo-monero)
5fdcda50 easylogging++: test for NULL before dereference (moneromooo-monero)
7ece1550 performance_test: fix bad last argument calling add_arg (moneromooo-monero)
a085da32 unit_tests: add check for page size > 0 before dividing (moneromooo-monero)
d8b1ec8b unit_tests: use std::shared_ptr to shut coverity up about leaks (moneromooo-monero)
02563bf4 simplewallet: top level exception catcher to print nicer messages (moneromooo-monero)
c57a65b2 blockchain_blackball: fix shift range for 32 bit archs (moneromooo-monero)
 2018-09-29 22:20:38 +02:00
Riccardo Spagni
9a54d0033e
Merge pull request #4458 
921b0fb1 use default create_address_file argument (m2049r)
 2018-09-29 22:20:35 +02:00
Riccardo Spagni
e951258543
Merge pull request #4456 
06d05c21 device: set device name correctly if key_on_device is set (Dusan Klinec)
 2018-09-29 22:20:27 +02:00
Riccardo Spagni
54d883d826
Merge pull request #4427 
83debef9 wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero)
 2018-09-29 22:19:58 +02:00
Riccardo Spagni
cd5638f894
Merge pull request #4417 
a21da905 Wallet: use unique_ptr for WalletImpl members (oneiric)
 2018-09-29 22:19:40 +02:00
Riccardo Spagni
e4130e6ae6
Merge pull request #4409 
7a056f44 WalletAPI: multisigSignData bug fixed (naughtyfox)
 2018-09-29 22:19:36 +02:00
Riccardo Spagni
402349760f
Merge pull request #4407 
43a06350 ringdb: use cursors to be a bit faster (moneromooo-monero)
 2018-09-29 22:19:32 +02:00
Riccardo Spagni
ff0d7a7678
Merge pull request #4406 
7964d4f8 wallet2: handle corner case in picking fake outputs (moneromooo-monero)
 2018-09-29 22:09:46 +02:00
Riccardo Spagni
f2eee1eb8c
Merge pull request #4438 
e350cc5a wallet2: fix duplicate output making it to the RPC (moneromooo-monero)
bf9a0f4c epee: fix stack overflow on crafted input (moneromooo-monero)
45683ee0 epee: fix invalid memory write reading an array entry (moneromooo-monero)
 2018-09-25 13:33:37 +02:00
moneromooo-monero
e350cc5ad5
wallet2: fix duplicate output making it to the RPC 2018-09-25 11:28:39 +00:00
Riccardo Spagni
e67789d075
Merge pull request #4422 
6e270fbd wallet2_api: fix for latest code changes (moneromooo-monero)
 2018-09-25 12:13:34 +02:00
Riccardo Spagni
cd8c7f6e78
Merge pull request #4433 
b35beaa8 wallet_rpc_server: include account index in incoming_transfers RPC (moneromooo-monero)
 2018-09-25 12:12:14 +02:00
moneromooo-monero
b35beaa8d6
wallet_rpc_server: include account index in incoming_transfers RPC 2018-09-24 19:42:26 +00:00
moneromooo-monero
6e270fbd29
wallet2_api: fix for latest code changes 2018-09-22 23:00:34 +00:00
moneromooo-monero
83907f8829
wallet_rpc_server: fix --run-as-service on Windows 
Thanks iDunk for the windows testing
 2018-09-22 11:56:30 +00:00
moneromooo-monero
e03402b0c7
wallet_rpc_server: fix build for windows 
Thanks iDunk for building patches on windows
 2018-09-21 18:50:05 +00:00
Riccardo Spagni
85110b42ab
Merge pull request #4401 
66901901 README: harmonize command formatting inside README.md (Andrea)
8cd98408 disable AES on s390x architecture (Tuan M. Hoang)
4ed30bab wallet: implement coin splitting for sweep_* 'outputs' option (whythat)
24f52396 wallet: add 'outputs' option for sweep_* commands (whythat)
52e19d69 README: Compile boost with cxxflags=-fPIC cflags=-fPIC (Italocoin Project)
0c77523d README: fill in libsodium package name for Arch (phloatingman)
 2018-09-21 20:46:22 +02:00
Riccardo Spagni
63eeb9df80
Merge pull request #4394 
b7660149 node_rpc_proxy: return a non empty error string on connection failure (moneromooo-monero)
 2018-09-21 20:44:48 +02:00
m2049r
bce474be7d
query backing device 2018-09-19 18:25:38 +02:00
Riccardo Spagni
2371a814cf
Merge pull request #4387 
6e6ffc06 wallet2_api: bring up to latest wallet api (moneromooo-monero)
 2018-09-18 17:59:44 +02:00
Riccardo Spagni
535bd0eb7e
Merge pull request #4361 
26971d46 WalletAPI: 'hasMultisigPartialKeyImages' function added (naughtyfox)
 2018-09-18 17:58:53 +02:00
Riccardo Spagni
08f0c60ffc
Merge pull request #4360 
7a76354c wallet2: import_multisig forward refresh exception (naughtyfox)
 2018-09-18 17:58:14 +02:00
Riccardo Spagni
580497d5f9
Merge pull request #4306 
56b50faa wallet: use wipeable_string in more places where a secret is used (moneromooo-monero)
07ec748c wipeable_string: add hex_to_pod function (moneromooo-monero)
 2018-09-18 17:32:11 +02:00
Riccardo Spagni
b174527f1d
Merge pull request #4302 
ba8dd347 api/wallet: properly disable key encryption (stoffu)
 2018-09-18 17:31:35 +02:00
Riccardo Spagni
b4a9ebad6c
Merge pull request #4299 
f9b22a7b hw_device: support for multiple devices added [for review] (Dusan Klinec)
 2018-09-18 17:29:26 +02:00
whythat
4ed30bab50
wallet: implement coin splitting for sweep_* 'outputs' option 
Implemented strategy splits total amount into N equal parts,
where N is a specified number of outputs. If N > 1, dummy
change output is NOT created.

rebased by moneromooo
 2018-09-18 11:02:03 +00:00
whythat
24f5239693
wallet: add 'outputs' option for sweep_* commands 
'outputs' option allows to specify the number of
separate outputs of smaller denomination that will
be created by sweep operation.

rebased by moneromooo
 2018-09-18 11:01:59 +00:00
stoffu
ba8dd3479d
api/wallet: properly disable key encryption 2018-09-17 22:15:29 +09:00
moneromooo-monero
b766014933
node_rpc_proxy: return a non empty error string on connection failure 
This makes it easier to avoid bugs on the caller side if errors are
represented by non empty strings.

This fixes the refresh height setting in new wallets when no daemon
is running.
 2018-09-17 11:03:46 +00:00
moneromooo-monero
6e6ffc0650
wallet2_api: bring up to latest wallet api 2018-09-16 13:24:48 +00:00
jcktm
c336d0f217 add daemonizer to rpc wallet 2018-09-15 06:24:27 +10:00
Dusan Klinec
f9b22a7b01
hw_device: support for multiple devices added [for review] 
- device name is a new wallet property
- full device name is now a bit more structured so we can address particular device vendor + device path. Example: 'Ledger', 'Trezor:udp', 'Trezor:udp:127.0.0.1:21324', 'Trezor:bridge:usb01'. The part before ':' identifies HW device implementation, the optional part after ':' is device path to look for.
- new --hw-device parameter added to the wallet, can name the hardware device
- device reconnect added
 2018-09-14 16:02:00 +02:00
Riccardo Spagni
d743994086
Merge pull request #4324 
44259e56 wallet: ask-password can now ask without encrypting the secret spend key (moneromooo-monero)
 2018-09-14 13:15:41 +02:00
moneromooo-monero
44259e560e
wallet: ask-password can now ask without encrypting the secret spend key 2018-09-14 11:14:21 +00:00
Riccardo Spagni
fd194aaa4d
Merge pull request #4347 
df0e7c2f wallet2: fix secondary partially signed multisig txes (moneromooo-monero)
 2018-09-14 13:06:38 +02:00
Riccardo Spagni
7850541074
Merge pull request #4337 
97764bae wallet_rpc_server: error out if wallet-file and wallet-dir are both used (moneromooo-monero)
 2018-09-14 13:06:22 +02:00
Riccardo Spagni
b182dc8262
Merge pull request #4336 
5f8f5631 wallet2.get_reserve_proof: throw when specified amount is zero (stoffu)
 2018-09-14 13:06:06 +02:00
Riccardo Spagni
dd2fc3afe3
Merge pull request #4332 
20171746 wallet2: factor the creation of a new wallet keys file (moneromooo-monero)
be6acfd5 wallet2: factor new blockchain setup (moneromooo-monero)
 2018-09-14 13:05:43 +02:00
Riccardo Spagni
1396b65bbc
Merge pull request #4331 
88fbc4a5 wallet2: fill in v2 height for stagenet (moneromooo-monero)
 2018-09-14 13:05:02 +02:00
Riccardo Spagni
5f9374c735
Merge pull request #4329 
45c85c89 remove unused fields from relay_tx RPC (el00ruobuob)
 2018-09-14 13:03:46 +02:00
Riccardo Spagni
239a7e10ff
Merge pull request #4253 
be001326 remove obsolete daemon selection of fake outs and old tx construction (moneromooo-monero)
 2018-09-14 12:54:25 +02:00
moneromooo-monero
be001326d1
remove obsolete daemon selection of fake outs and old tx construction 2018-09-14 10:51:45 +00:00
Riccardo Spagni
c74d9057f8
Merge pull request #4260 
a54dbaee blockchain_blackball: add --force-chain-reaction-pass flag (moneromooo-monero)
44439c32 record blackballs as amount/offset, and add export ability (moneromooo-monero)
4bce935b blockchain_blackball: more optimizations (moneromooo-monero)
b66ba783 blockchain_blackball: do not process duplicate blockchains parts (moneromooo-monero)
639a3c01 blockchain_blackball: make it clear secondary passes are not incremental (moneromooo-monero)
eb8a51be blockchain_blackball: detect spent outputs by partial ring reuse (moneromooo-monero)
d6d276c6 blockchain_blackball: fix chain reaction phase in incremental mode (moneromooo-monero)
2b2a681b blockchain_blackball: avoid false positives for different amounts (moneromooo-monero)
80e4fef3 blockchain_blackball: set transaction looping txn to read only (moneromooo-monero)
4801d6b5 blockchain_blackball: add stats (moneromooo-monero)
846190fd blockchain_blackball: support pre-v2 databases (moneromooo-monero)
daa6cc7d blockchain_blackball: use LMDB for the cache (moneromooo-monero)
50cb370d ringdb: allow blackballing many outputs at once (moneromooo-monero)
 2018-09-14 12:45:18 +02:00
Riccardo Spagni
438781afc4
Merge pull request #4221 
62511df6 wallet2: fix refresh retry when a block/tx fails to parse (moneromooo-monero)
b219c24c wallet2: trim hash chain after fast refresh of hashes (moneromooo-monero)
5b6bcca3 wallet2: fix checking the wrong vector when adding hashes (moneromooo-monero)
 2018-09-14 12:38:36 +02:00
moneromooo-monero
56b50faab2
wallet: use wipeable_string in more places where a secret is used 2018-09-12 09:26:11 +00:00
Riccardo Spagni
157690caaa
Merge pull request #4352 
0664a984 wallet_rpc_server: remove some unused code (moneroexamples)
 2018-09-11 21:26:50 +02:00
moneromooo-monero
ac4f71c200
wallet2: bump testnet rollback to account for coming reorg 2018-09-11 13:38:35 +00:00
moneromooo-monero
a1359ad43c
Check inputs to addKeys are in range 
Reported by QuarksLab.
 2018-09-11 13:38:09 +00:00
moneromooo-monero
5ffb2ff9b7
v8: per byte fee, pad bulletproofs, fixed 11 ring size 2018-09-11 13:38:07 +00:00
moneromooo-monero
2a8fcb421b
Bulletproof aggregated verification and tests 
Also constrains bulletproofs to simple rct, for simplicity
 2018-09-11 13:37:37 +00:00
moneromooo-monero
9ce9f8caf6
bulletproofs: add multi output bulletproofs to rct 2018-09-11 13:37:28 +00:00
naughtyfox
26971d46fc WalletAPI: 'hasMultisigPartialKeyImages' function added 2018-09-10 19:33:08 +03:00
naughtyfox
7a76354c8b wallet2: import_multisig forward refresh exception 2018-09-10 18:45:37 +03:00
moneromooo-monero
44439c3208
record blackballs as amount/offset, and add export ability 2018-09-10 09:04:18 +00:00
moneroexamples
0664a98421
wallet_rpc_server: remove some unused code 2018-09-09 12:37:01 +00:00
moneromooo-monero
50cb370d5b
ringdb: allow blackballing many outputs at once 
It cuts down on txn commits, and speeds up blackballing substantially
 2018-09-09 12:01:43 +00:00
moneromooo-monero
df0e7c2feb
wallet2: fix secondary partially signed multisig txes 2018-09-08 23:12:06 +00:00
moneromooo-monero
97764bae3a
wallet_rpc_server: error out if wallet-file and wallet-dir are both used 2018-09-08 20:54:14 +00:00
Guillaume LE VAILLANT
54b859bea5 wallet rpc: Add close_wallet RPC 
And close the current wallet automatically if necessary when opening another
wallet.
 2018-09-05 16:52:16 +02:00
luigi1111
77ed11e627
Merge pull request #4270 
29dea03 epee: resize vectors where possible in serialization (moneromooo-monero)
76affd9 epee: some speedup in parsing (moneromooo-monero)
dc6c069 db_lmdb: speedup the get_output_distribution common case (moneromooo-monero)
76ac5a8 wallet2: ask for a binary output distribution, for speed (moneromooo-monero)
 2018-09-04 13:19:58 -05:00
luigi1111
59e6fb06f9
Merge pull request #4269 
3d5abbe [#4027] add change_wallet_password wallet rpc command (artyomsol)
 2018-09-04 13:17:40 -05:00
luigi1111
5f1bbe3bce
Merge pull request #4268 
1f2409e Do memwipe for critical secret keys copied to rct::key (stoffu)
 2018-09-04 13:16:04 -05:00
luigi1111
085b6ba98e
Merge pull request #4263 
5ed6669 wallet_rpc_server: remove unused amount_keys field in transfer RPC (moneromooo-monero)
 2018-09-04 13:12:48 -05:00
luigi1111
6d4d4ddb68
Merge pull request #4252 
ac09cfa wallet2: remove obsolete pruned/unpruned case (moneromooo-monero)
 2018-09-04 13:05:12 -05:00
stoffu
5f8f56315c
wallet2.get_reserve_proof: throw when specified amount is zero 2018-09-04 13:00:38 +09:00
moneromooo-monero
20171746de
wallet2: factor the creation of a new wallet keys file 2018-09-03 11:27:46 +00:00
moneromooo-monero
be6acfd5be
wallet2: factor new blockchain setup 2018-09-03 11:27:43 +00:00
moneromooo-monero
88fbc4a567
wallet2: fill in v2 height for stagenet 2018-09-03 11:26:28 +00:00
el00ruobuob
45c85c89de
remove unused fields from relay_tx RPC 2018-09-02 23:50:31 +02:00
stoffu
8ca1215f25
wallet: store trusted-daemon flag in wallet2 2018-08-23 14:55:09 +09:00
luigi1111
1db7a29e12
Merge pull request #4247 
10475ab node_rpc_proxy: fix fork earliest height caching [RYO backport] (fireice-uk)
 2018-08-22 21:04:34 -05:00
luigi1111
2e7bfd0de5
Merge pull request #4242 
6fcdc9e rpc-wallet: refresh command added (ph4r05)
 2018-08-22 21:00:10 -05:00
luigi1111
6e8e4fb3b7
Merge pull request #4202 
8439306 wallet2: do not divide by 0 on invalid daemon response (moneromooo-monero)
 2018-08-22 20:42:20 -05:00
Dusan Klinec
6fcdc9e0b2
rpc-wallet: refresh command added 2018-08-22 16:57:55 +02:00
moneromooo-monero
62511df622
wallet2: fix refresh retry when a block/tx fails to parse 
It would switch to a new set of blocks and fail, getting out of sync
with the hash chain in the process
 2018-08-22 09:57:46 +00:00
moneromooo-monero
b219c24c3a
wallet2: trim hash chain after fast refresh of hashes 
This ensures it can't end up filled with the actual placeholders
 2018-08-22 09:57:42 +00:00
moneromooo-monero
5b6bcca32a
wallet2: fix checking the wrong vector when adding hashes 
The two vectors should be the same size anyway, so add an assert
to catch any case where they aren't
 2018-08-22 09:57:39 +00:00
moneromooo-monero
76ac5a8fbe
wallet2: ask for a binary output distribution, for speed 2018-08-19 15:58:25 +00:00
artyomsol
3d5abbe86b [#4027] add change_wallet_password wallet rpc command 2018-08-17 09:54:26 +03:00
stoffu
1f2409e9e2
Do memwipe for critical secret keys copied to rct::key 2018-08-16 22:26:30 +09:00
moneromooo-monero
ab74dc277a
crypto: make secret_key automatically mlock 2018-08-16 11:57:49 +00:00
moneromooo-monero
e9ffa91257
store secret keys encrypted where possible 
The secret spend key is kept encrypted in memory, and
decrypted on the fly when needed.

Both spend and view secret keys are kept encrypted in a JSON
field in the keys file. This avoids leaving the keys in
memory due to being manipulated by the JSON I/O API.
 2018-08-16 11:57:43 +00:00
moneromooo-monero
ea37614efe
wallet: wipe seed from memory where appropriate 2018-08-16 09:17:52 +00:00
stoffu
a64f57fe42
wallet2: make --restricted-rpc available for wallet RPC only 2018-08-16 09:54:23 +09:00
luigi1111
e69e0e9e34
Merge pull request #4194 
0f75717 wallet2: avoid using arbitrary random values when unknown (moneromooo-monero)
 2018-08-15 17:56:23 -05:00
luigi1111
1c55a3756b
Merge pull request #4193 
4520cfd wallet2: guard against bad outputs in import_outputs (moneromooo-monero)
 2018-08-15 17:54:49 -05:00
luigi1111
8d2e454929
Merge pull request #4188 
a3fe1c5 simplewallet: add set_tx_key for importing tx keys from 3rd party wallets (stoffu)
 2018-08-15 17:47:05 -05:00
luigi1111
7aa2030cee
Merge pull request #4174 
ff37bd0 wallet2: fix O(n^2) behaviour in import_key_images (moneromooo-monero)
 2018-08-15 17:40:55 -05:00
luigi1111
a68143bc52
Merge pull request #4171 
9127a8b wallet-rpc: filter getbalance response by address index (stoffu)
 2018-08-15 17:37:23 -05:00
luigi1111
564e9c3b5f
Merge pull request #4170 
1c6cfd3 wallet-rpc: add get_address_index command (stoffu)
 2018-08-15 17:35:49 -05:00
luigi1111
e7328ed5b7
Merge pull request #4158 
7db7ec8 wallet rpc: support making integrated address of given standard address (stoffu)
 2018-08-15 17:25:19 -05:00
luigi1111
5e795ee7af
Merge pull request #4153 
37f0799 wallet: distinguish coinbase from other txes in show_transfers (moneromooo-monero)
 2018-08-15 17:23:56 -05:00
luigi1111
2a44c2defd
Merge pull request #4150 
f2e65c6 wallet2: consider minimum fee when testing if balance is sufficient (stoffu)
 2018-08-15 17:22:36 -05:00
luigi1111
1d2c08610b
Merge pull request #4136 
4307489 wallet: disable core dumps on startup in release mode (moneromooo-monero)
 2018-08-15 17:15:49 -05:00
luigi1111
017e07a035
Merge pull request #4103 
bcab579 wallet: allow adjusting number of rounds for the key derivation function (stoffu)
 2018-08-15 17:09:52 -05:00
luigi1111
4cde4cb946
Merge pull request #3528 
34d4b79 wallet2: use a gamma distribution to pick fake outs (moneromooo-monero)
 2018-08-15 17:00:32 -05:00
moneromooo-monero
5ed6669130
wallet_rpc_server: remove unused amount_keys field in transfer RPC 2018-08-15 12:47:33 +00:00
fireice-uk
10475ab23f node_rpc_proxy: fix fork earliest height caching [RYO backport] 
xref https://github.com/ryo-currency/ryo-currency/pull/86
 2018-08-13 22:16:17 +02:00
moneromooo-monero
ac09cfa6be
wallet2: remove obsolete pruned/unpruned case 
All daemons will not support pruned blocks
 2018-08-13 13:17:27 +00:00
moneromooo-monero
4307489147
wallet: disable core dumps on startup in release mode 2018-08-12 16:28:10 +00:00
stoffu
bcab579864
wallet: allow adjusting number of rounds for the key derivation function 2018-08-08 01:56:54 +09:00
moneromooo-monero
37f0799284
wallet: distinguish coinbase from other txes in show_transfers 2018-08-03 12:48:16 +00:00
moneromooo-monero
8439306212
wallet2: do not divide by 0 on invalid daemon response 2018-07-31 14:26:00 +00:00
stoffu
1c6cfd34f4
wallet-rpc: add get_address_index command 2018-07-31 21:36:12 +09:00
stoffu
9127a8b79f
wallet-rpc: filter getbalance response by address index 2018-07-31 20:45:41 +09:00
moneromooo-monero
0f757177fe
wallet2: avoid using arbitrary random values when unknown 2018-07-30 13:34:15 +01:00
moneromooo-monero
4520cfd978
wallet2: guard against bad outputs in import_outputs 
also some minor speedup
 2018-07-30 13:21:58 +01:00
stoffu
a3fe1c56ee
simplewallet: add set_tx_key for importing tx keys from 3rd party wallets 2018-07-30 20:50:05 +09:00
luigi1111
f739a3cbb8
Merge pull request #4109 
2951436 wallet: warn when payment IDs are used (moneromooo-monero)
 2018-07-27 14:27:47 -05:00
luigi1111
92b5d6c204
Merge pull request #4091 
a4272de wallet2: unlock keys file before calling verify_password (needed for Windows) (stoffu)
 2018-07-27 14:22:34 -05:00
moneromooo-monero
ff37bd00bc
wallet2: fix O(n^2) behaviour in import_key_images 
That takes a lot of time for even not so large wallets
 2018-07-24 14:34:19 +01:00
stoffu
7db7ec8591
wallet rpc: support making integrated address of given standard address 2018-07-20 21:33:36 +09:00
luigi1111
702a41034d
Merge pull request #4088 
8c4db68 node_rpc_proxy: factor a few RPC calls using get_info (moneromooo-monero)
 2018-07-19 14:15:16 -05:00
luigi1111
5c102c60dc
Merge pull request #4087 
d6440ab wallet2: recover from index out of hashchain bounds error (moneromooo-monero)
 2018-07-19 14:14:10 -05:00
luigi1111
f6d7e87b67
Merge pull request #4075 
438d52d remove epee from link lines where it's redundant (moneromooo-monero)
 2018-07-19 14:10:20 -05:00
luigi1111
be81a27fa4
Merge pull request #4071 
d6d78f1 Allow fractional outputs to be ignored (stoffu)
 2018-07-19 14:06:54 -05:00
luigi1111
9315e12d34
Merge pull request #4033 
3e46db9 rpc: add a non binary get_transaction_pool_hashes RPC (moneromooo-monero)
 2018-07-19 13:55:37 -05:00
stoffu
f2e65c6e50
wallet2: consider minimum fee when testing if balance is sufficient 2018-07-19 20:31:07 +09:00
moneromooo-monero
d6440ab319
wallet2: recover from index out of hashchain bounds error 
This can happen when there's a very large reorg on the daemon
(ie, on testnet)
 2018-07-16 23:13:56 +01:00
moneromooo-monero
2951436704
wallet: warn when payment IDs are used 
Subaddresses are better for privacy
 2018-07-12 19:37:29 +01:00
moneromooo-monero
fc39d3b23c
wallet2: ensure outputs are processed only once 
This should be proof against any way one might get to multiple
processing, such as generating the same derivation from the
same pubkey, etc
 2018-07-08 12:56:51 +01:00
moneromooo-monero
34d4b798d4
wallet2: use a gamma distribution to pick fake outs 
as per "An Empirical Analysis of Linkability in the Monero
Blockchain", by Miller et al.
 2018-07-03 18:10:48 +01:00
Riccardo Spagni
40f85f478e
Merge pull request #3985 
58cceaad wallet2: fix double counting outs if the tx pubkey is duplicated (moneromooo-monero)
 2018-07-03 15:51:41 +02:00
Riccardo Spagni
f449dbe8eb
Merge pull request #4041 
df9d50a8 wallet2: fix read buffer overflow in import_key_images (moneromooo-monero)
 2018-07-03 15:20:42 +02:00
Riccardo Spagni
94803bad01
Merge pull request #4035 
66df13a5 wallet-rpc.getaddress: throw if index is out of bound (stoffu)
 2018-07-03 15:19:54 +02:00
Riccardo Spagni
97f5a130d6
Merge pull request #4028 
2a19697b wallet2: fix double header in unsigned transfer file (moneromooo-monero)
 2018-07-03 15:19:24 +02:00
Riccardo Spagni
e451c76181
Merge pull request #4005 
b85acb4c Fix RPC crashes that didn't check for an open wallet (Howard Chu)
 2018-07-03 15:18:05 +02:00
Riccardo Spagni
27ca6ca594
Merge pull request #4004 
bc443494 wallet2: fix out of sync account tag cache (moneromooo-monero)
 2018-07-03 15:16:37 +02:00
moneromooo-monero
58cceaad71
wallet2: fix double counting outs if the tx pubkey is duplicated 2018-07-03 14:16:30 +01:00
stoffu
a4272de797
wallet2: unlock keys file before calling verify_password (needed for Windows) 
Also added notes to WalletManager::verifyWalletPassword (which afaik seems unused
by anyone at the moment) regarding the need to unlock the keys file beforehand.
 2018-07-03 18:07:20 +09:00
stoffu
d6d78f157b
Allow fractional outputs to be ignored 2018-07-03 18:04:31 +09:00
moneromooo-monero
8c4db68ff7
node_rpc_proxy: factor a few RPC calls using get_info 
Takes advantage of caching
 2018-07-02 17:59:44 +01:00
moneromooo-monero
438d52deaf
remove epee from link lines where it's redundant 
For some reason, this confuses and kills ASAN on startup
as it thinks const uint8_t ipv4_network_address::ID is
defined multiple times.
 2018-06-28 16:45:22 +01:00
luigi1111
a9b83f5a6e
Merge pull request #4067 
9a39b7d wallet2: fix build for windows (std::max again) (moneromooo-monero)
 2018-06-27 21:28:34 -05:00
stoffu
29254fc06e
api/wallet: add missing arg to wallet2::refresh() 2018-06-28 10:24:05 +09:00
luigi1111
ba0a7294d0
Merge pull request #4000 
4510f41 Wallet API: add some missing override keyword (stoffu)
 2018-06-27 20:18:41 -05:00
luigi1111
4c6de54ee2
Merge pull request #3994 
1d17647 epee.string_tools: add conversion between UTF-8 and UTF-16 (stoffu)
59de6f8 util: add file_locker class (stoffu)
3d623a8 wallet: prevent the same wallet file from being opened by multiple processes (stoffu)
 2018-06-27 20:17:25 -05:00
stoffu
4510f417f9
Wallet API: add some missing override keyword 
Also remove dust() from UnsignedTransactionImpl (already in PendingTransactionImpl)
 2018-06-28 09:59:09 +09:00
stoffu
3d623a86d1
wallet: prevent the same wallet file from being opened by multiple processes 2018-06-28 09:41:43 +09:00
moneromooo-monero
9a39b7dd7f
wallet2: fix build for windows (std::max again) 2018-06-28 00:47:48 +01:00
moneromooo-monero
9b38551c3c
wallet_rpc_server: fix build - forgot to build rpc version 2018-06-27 23:34:02 +01:00
luigi1111
2329d2f4c8
Merge pull request #3907 
dcbc17e wallet: include a suggested number of confirmations based on amount (moneromooo-monero)
 2018-06-27 16:32:33 -05:00
luigi1111
8a27caeb22
Merge pull request #3998 
8db23df wallet: on first refresh, start off with a quantized height (moneromooo-monero)
 2018-06-27 16:30:38 -05:00
luigi1111
9453573581
Merge pull request #3995 
0a5292c wallet2: use decoded amount when reporting repeated output key (stoffu)
 2018-06-27 16:28:57 -05:00
luigi1111
c28a2b0d7d
Merge pull request #3992 
25c15dc wallet2: use correct fee for split txes (stoffu)
 2018-06-27 16:26:23 -05:00
luigi1111
5eb2e01216
Merge pull request #3991 
798dfcf wallet: allow unspendable unmixable outputs to be discarded (stoffu)
 2018-06-27 16:25:03 -05:00
luigi1111
3ad4ecd4ff
Merge pull request #3982 
08b85a8 cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X (stoffu)
0cf80ba net_node: resolve host for node addresses given via command line flags (stoffu)
 2018-06-27 15:38:23 -05:00
moneromooo-monero
dcbc17e97e
wallet: include a suggested number of confirmations based on amount 
This is based on how much an attacking miner stands to lose in block
rewardy by mining a private chain which double spends a payment.
This is not foolproof, since mining is based on luck, and breaks
down as the attacking miner nears 50% of the network hash rate,
and the estimation is based on a constant block reward.
 2018-06-27 21:38:21 +01:00
luigi1111
a844844cda
Merge pull request #3716 
a2b557f 6795bd0 209ec96 ed2c81e a830db2 57ea902 31a895e ba8331c f7f1917 41be339 f025ae9 ef2cb63 dcfd299 5d3e702 2704624 2771a18 0e4c7d0 (moneromooo-monero)
 2018-06-27 15:33:01 -05:00
moneromooo-monero
0e4c7d0fae
wallet2: cache ringdb key while refreshing 
Speeds up syncing with a lot of outgoing outputs as key generation
runs Cryptonight.
 2018-06-26 22:15:38 +01:00
moneromooo-monero
2771a18e85
threadpool: allow leaf functions to run concurrently 
Decrease the number of worker threads by one to account
for the fact the calling thread acts as a worker thread now
 2018-06-26 22:15:22 +01:00
moneromooo-monero
2704624eae
wallet2: remove unneeded divisions 2018-06-26 22:15:20 +01:00
moneromooo-monero
5d3e70229e
wallet2: remove old blockchain size cache hack 2018-06-26 22:15:18 +01:00
moneromooo-monero
dcfd299239
wallet2: speedup refresh 
key derivation and checking for incoming outputs are threaded
in batch before adding blocks to the local blockchain. Other
minor bits and bobs are also cached.
 2018-06-26 22:15:16 +01:00
moneromooo-monero
f025ae9760
wallet2: avoid re-parsing blocks when refreshing in a loop 2018-06-26 22:15:12 +01:00
moneromooo-monero
41be339655
wallet2: avoid duplicate parsing of tx extra 2018-06-26 22:15:10 +01:00
moneromooo-monero
f7f1917ed4
wallet2: remove useless device locking 2018-06-26 22:14:35 +01:00
moneromooo-monero
ba8331ce41
wallet2: parse blocks in the RPC thread, not the processing thread 
Processing typically is the bottleneck
 2018-06-26 22:14:33 +01:00
moneromooo-monero
31a895e876
wallet2: simplify/speedup process_blocks 2018-06-26 22:14:31 +01:00
moneromooo-monero
57ea90285c
wallet: don't process miner tx if we're refreshing with no-coinbase 2018-06-26 22:14:26 +01:00
moneromooo-monero
ed2c81ed95
replace std::list with std::vector on some hot paths 
also use reserve where appropriate
 2018-06-26 22:14:21 +01:00
moneromooo-monero
6795bd0d4e
rpc: add option to skip coinbase info in get_blocks.bin 2018-06-26 22:14:16 +01:00
moneromooo-monero
a2b557fe5c
wallet2: use std::move on containers where appropriate 2018-06-26 22:14:14 +01:00
luigi1111
506be80601
Merge pull request #3955 
d7a6b72 wallet2: fix bulletproof cold signing (moneromooo-monero)
 2018-06-25 15:09:48 -05:00
luigi1111
26562e9f3c
Merge pull request #3941 
bf26920 wallet2: fix get_approximate_blockchain_height for stagenet (stoffu)
 2018-06-25 14:54:54 -05:00
moneromooo-monero
df9d50a8a4
wallet2: fix read buffer overflow in import_key_images 2018-06-23 09:22:20 +01:00
moneromooo-monero
3e46db97e5
rpc: add a non binary get_transaction_pool_hashes RPC 2018-06-21 09:02:42 +01:00
stoffu
46e90b7780
Wallet API: add support for wallet creation from hardware device 2018-06-21 12:36:27 +09:00
stoffu
8fc0cdb96f
wallet2: lower default for subaddress lookahead when restoring with hardware 2018-06-21 12:35:23 +09:00
stoffu
66df13a58b
wallet-rpc.getaddress: throw if index is out of bound 2018-06-21 10:49:03 +09:00
luigi1111
9a3712541e
Merge pull request #3939 
62c8c07 wallet: do not log by default if we're not asked to log to console (moneromooo-monero)
 2018-06-20 14:52:55 -05:00
luigi1111
51cdd76bbd
Merge pull request #3897 
63d0ab0 mlog: --max-log-files to set the max number of rotated log files (stoffu)
 2018-06-20 14:19:30 -05:00
moneromooo-monero
2a19697bd4
wallet2: fix double header in unsigned transfer file 2018-06-19 22:30:02 +01:00
luigi1111
896512b2b6
Merge pull request #3878 
5a412b7 disable file size sanity check when loading the wallet cache (moneromooo-monero)
 2018-06-19 12:57:59 -05:00
luigi1111
d841339b09
Merge pull request #3829 
4764929 use deterministic viewkey if not supplied (cryptochangements34)
 2018-06-19 12:43:10 -05:00
luigi1111
9226acca4b
Merge pull request #3804 
89e51ec simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet (jcktm)
 2018-06-16 14:15:52 -05:00
luigi1111
4e7897e57c
Merge pull request #3780 
9c2a7b4 wallet-rpc: watch-only and cold wallet features added (ph4r05)
 2018-06-16 14:12:57 -05:00
luigi1111
e3012444fb
Merge pull request #3762 
eb9f3a3 check_spend_proof (itssteven)
 2018-06-16 14:10:11 -05:00
luigi1111
7af0b7fffc
Merge pull request #3735 
4812c06 add .load() to make Boost 1.67 happy with its new is_integral check (Teutone)
 2018-06-16 14:07:25 -05:00
Howard Chu
b85acb4cb8
Fix RPC crashes that didn't check for an open wallet 2018-06-15 20:18:41 +01:00
moneromooo-monero
bc443494f3
wallet2: fix out of sync account tag cache 
This would cause crashes when trying to tag an account that was
just created
 2018-06-15 20:18:12 +01:00
moneromooo-monero
8db23df581
wallet: on first refresh, start off with a quantized height 
for privacy reasons, so an untrusted node can't easily track
wallets from IP address to IP address, etc. The granularity
is 1024 blocks, which is about a day and a half.
 2018-06-13 22:44:27 +01:00
stoffu
63d0ab09b5
mlog: --max-log-files to set the max number of rotated log files 2018-06-13 12:44:27 +09:00
stoffu
798dfcfe79
wallet: allow unspendable unmixable outputs to be discarded 2018-06-13 11:56:40 +09:00
stoffu
0a5292c339
wallet2: use decoded amount when reporting repeated output key 2018-06-13 01:06:44 +09:00
stoffu
25c15dca5c
wallet2: use correct fee for split txes 2018-06-12 12:06:51 +09:00
stoffu
08b85a8e00
cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X 2018-06-11 20:17:02 +09:00
luigi1111
6884db7b31
Merge pull request #3599 
8787fd8 WalletApi: publicMultisigSignerKey method (naughtyfox)
 2018-06-08 14:45:46 -05:00
luigi1111
00635bd68b
Merge pull request #3598 
b21bc00 Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api) (naughtyfox)
 2018-06-08 14:40:06 -05:00
luigi1111
1af890287b
Merge pull request #3890 
f80b157 wallet2: don't ask for pruned txes yet, we still parse the entire tx (moneromooo-monero)
 2018-06-07 12:12:28 -05:00
moneromooo-monero
d7a6b72c15
wallet2: fix bulletproof cold signing 
Cold signing was always using Borromean range proofs, causing
a larger tx, and an incorrect fee
 2018-06-07 12:29:30 +01:00
stoffu
bf26920f27
wallet2: fix get_approximate_blockchain_height for stagenet 2018-06-06 20:33:01 +09:00
moneromooo-monero
62c8c07c47
wallet: do not log by default if we're not asked to log to console 
This means monero-wallet-rpc still does, but the user level program
does not.
 2018-06-06 10:15:13 +01:00
cryptochangements34
4764929ecb use deterministic viewkey if not supplied 2018-06-05 19:32:03 -04:00
Dusan Klinec
9c2a7b4638 wallet-rpc: watch-only and cold wallet features added 
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs

Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx

- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
 2018-06-03 13:21:00 +02:00
luigi1111
503d2693fd
Merge pull request #3640 
f36132a wallet cli/rpc: terminate execution with code 0 when --help or --version is given (stoffu)
 2018-05-31 14:44:54 -05:00
luigi1111
3ee6a1b706
Merge pull request #3635 
c1bda09 wallet_rpc_server: add a get_version RPC (moneromooo-monero)
 2018-05-31 14:43:18 -05:00
luigi1111
b6eb7484d1
Merge pull request #3592 
90a16b1 crypto: fix initialization order issue with random mutex (moneromooo-monero)
6a61f52 unit_tests: add ringdb unit tests (moneromooo-monero)
 2018-05-31 14:41:17 -05:00
luigi1111
3a373c3d3a
Merge pull request #3489 
47fdb74 WalletApi: getMultisigInfo entry for gui wallets... (naughtyfox)
47fdb74 Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings (naughtyfox)
 2018-05-31 14:34:34 -05:00
moneromooo-monero
f80b1571c6
wallet2: don't ask for pruned txes yet, we still parse the entire tx 2018-05-31 16:46:58 +01:00