4rkal/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-16 05:16:32 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,850 Commits 9 Branches 69 Tags 249 MiB
859db52fda
Commit Graph

4091 Commits

Author SHA1 Message Date
rbrunner7
b370ef54b9 Wallet: Descriptions through new commands 'set_description', 'get_description' 2017-10-16 22:24:09 +02:00
binaryFate
b2d416f211 Distinguish "not enough money" and "not enough unlocked money" 
Fix #1530
 2017-10-16 15:14:09 +02:00
kenshi84
ac4018a7e6
wallet2: workaround for lightwallet before supporting subaddress (followup #2656) 2017-10-16 12:03:09 +09:00
kenshi84
4dd05a2f9b
subaddress: change prefix so that it starts with 8 2017-10-16 10:35:59 +09:00
Bertrand Jacquin
52c1381049
blockchain_utilities: Add monero-blockchain-{ex,im}port binaries to 
default install targets

Binaries available to download on https://getmonero.org/downloads/ as
embedding monerod, monero-wallet-{cli,rpc} and
monero-blockchain-{ex,im}port.

This change synchronise download results with a manual build from
source
 2017-10-15 22:19:38 +01:00
Vasil Dimov
4d35ad7603
Fix compiler warnings with Clang 6.0.0. 
monero/src/cryptonote_protocol/block_queue.cpp:208:44: error:
      suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
  static const boost::uuids::uuid uuid0 = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0};
                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                           {                                          }

monero/src/wallet/wallet_rpc_server.cpp:1895:43: error:
      lambda capture 'wal' is not used [-Werror,-Wunused-lambda-capture]
  tools::signal_handler::install([&wrpc, &wal](int) {
                                          ^

monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:40: error:
      lambda capture 'arg' is not used [-Werror,-Wunused-lambda-capture]
    m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
                                       ^

monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:46: error:
      lambda capture 'fluffy_arg' is not used [-Werror,-Wunused-lambda-capture]
    m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
                                             ^

monero/src/blockchain_utilities/blockchain_export.cpp:181:3: error:
      bool literal returned from 'main' [-Werror,-Wmain]
  CHECK_AND_ASSERT_MES(r, false, "Failed to initialize source blockchain storage");
  ^                       ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
      expanded from macro 'CHECK_AND_ASSERT_MES'
  ...fail_ret_val, message)   do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
                                                                  ^      ~~~~~~~~~~~~
monero/src/blockchain_utilities/blockchain_export.cpp:195:3: error:
      bool literal returned from 'main' [-Werror,-Wmain]
  CHECK_AND_ASSERT_MES(r, false, "Failed to export blockchain raw data");
  ^                       ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
      expanded from macro 'CHECK_AND_ASSERT_MES'
  ...fail_ret_val, message)   do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
                                                                  ^      ~~~~~~~~~~~~
 2017-10-15 22:02:24 +03:00
Riccardo Spagni
97c11caf07 Merge pull request #2656 
3492de01 fix lightwallet and subaddresses conflict (Jaquee)
329f149e remove reference to cryptonote::null_hash (Jaquee)
 2017-10-15 19:32:18 +02:00
Jaquee
3492de010b fix lightwallet and subaddresses conflict 2017-10-15 19:19:40 +02:00
Jaquee
329f149e95 remove reference to cryptonote::null_hash 2017-10-15 19:19:40 +02:00
Riccardo Spagni
b293ad9a1a
Merge pull request #2640 
22b51e06 db_lmdb: include chain height when failing to find an output key (moneromooo-monero)
5db433b3 blockchain: avoid exceptions in output verification (moneromooo-monero)
 2017-10-15 18:59:45 +02:00
Riccardo Spagni
344c01c712
Merge pull request #2638 
529a6a4a core: guard against a mined block not finding all txes in the pool (moneromooo-monero)
 2017-10-15 18:58:57 +02:00
Riccardo Spagni
845afb5191
Merge pull request #2613 
2051f89f cmake: build tests last (redfish)
 2017-10-15 18:58:31 +02:00
Riccardo Spagni
73f0c16743
Merge pull request #2606 
4090e8c6 simplewallet: add get/set for refresh-from-height (moneromooo-monero)
 2017-10-15 18:51:11 +02:00
Riccardo Spagni
d5ab55b8d7
Merge pull request #2604 
0a872798 protocol: kick idle peers by dropping them (moneromooo-monero)
 2017-10-15 18:50:32 +02:00
Riccardo Spagni
f1bee553b1
Merge pull request #2602 
bc1b9333 frob level 1 logs a bit for consistency (moneromooo-monero)
 2017-10-15 18:49:48 +02:00
Riccardo Spagni
f484b162db
Merge pull request #2599 
b776c725 daemon: use @N syntax to output_histogram for specific amounts (moneromooo-monero)
 2017-10-15 18:48:19 +02:00
Riccardo Spagni
e50bf5f811
Merge pull request #2597 
c4136134 miner: always update block template when starting (moneromooo-monero)
 2017-10-15 18:47:43 +02:00
Riccardo Spagni
5c3275ddbe
Merge pull request #2596 
06fb9bcf wallet2: fix refresh height calc for new wallets (moneromooo-monero)
 2017-10-15 18:47:16 +02:00
Riccardo Spagni
71253c1dcd
Merge pull request #2592 
dc19659d Remove network_address_base which has been merged with ipv4_network_address in 8b006877 (Michał Sałaban)
2183ade0 Don't try to create wallet-dir when it's not given, don't crash if wallet-dir already exists. (Michał Sałaban)
 2017-10-15 18:39:13 +02:00
Riccardo Spagni
1280ba4f5b
Merge pull request #2589 
8f0cea63 add a command_line function to check for defaulted options (moneromooo-monero)
 2017-10-15 18:38:46 +02:00
Riccardo Spagni
3eac7ab94f
Merge pull request #2587 
cba34494 rpc: out_peers now works again (moneromooo-monero)
 2017-10-15 18:38:12 +02:00
Riccardo Spagni
50f0c1f0e0
Merge pull request #2586 
7b8d3ec6 wallet-cli: add --do-not-relay option (stoffu)
 2017-10-15 18:37:38 +02:00
Riccardo Spagni
1740f0a13e
Merge pull request #2583 
27fdaaa4 Fix building with -DARCH=default -DNO_AES=ON (moneromooo-monero)
 2017-10-15 18:37:14 +02:00
Riccardo Spagni
147ecb6b7a
Merge pull request #2573 
7e7acdc3 daemon: catch out of range exceptions too when calling stoll/stoi (moneromooo-monero)
 2017-10-15 18:34:48 +02:00
Riccardo Spagni
1e577e8fbf
Merge pull request #2571 
8028dde7 block_queue: use boost::uuids::nil_uuid where appropriate (moneromooo-monero)
 2017-10-15 18:34:26 +02:00
Riccardo Spagni
27ed7419bb
Merge pull request #2570 
f139a6ca wallet2: fix backlog being off by 1 (moneromooo-monero)
 2017-10-15 18:33:51 +02:00
Riccardo Spagni
1039b5e813
Merge pull request #2569 
b5b4abb8 simplewallet: fix setting default-ring-size to 0 (moneromooo-monero)
 2017-10-15 18:32:41 +02:00
Riccardo Spagni
c45f3ac4d9
Merge pull request #2568 
7130cf0c Add tools::on_startup, and warn about glibc 2.25 bug if found (moneromooo-monero)
 2017-10-15 18:32:09 +02:00
Riccardo Spagni
2babd2e0a3
Merge pull request #2567 
54940d8c blockchain_import: remove a few commented out obsolete lines (moneromooo-monero)
 2017-10-15 18:29:18 +02:00
Riccardo Spagni
1c546e0d81
Merge pull request #2565 
452d4fae tests: fix hashchain unit tests (moneromooo-monero)
 2017-10-15 18:27:08 +02:00
Riccardo Spagni
960886aa04
Merge pull request #2109 
97c2e449 wallet2+API: use separate callbacks for lightwallets (Jaquee)
d9261867 walletAPI: correct confirmations in txHistory for unsynced wallets (Jaquee)
9442b043 walletAPI: lightwallet exceptions (Jaquee)
fc922934 walletAPI: add lightwallet login() and importWalletRequest() (Jaquee)
79207743 walletAPI: init() lightwallet and SSL support (Jaquee)
dde5a1fc walletAPI: add tx unlock_time (Jaquee)
bba5cbed wallet2: remove obsolete get_num_rct_outputs() call from create_transactions_2 (Jaquee)
7a482f30 wallet2: create_transactions_2 lightwallet support (Jaquee)
ce61b818 wallet2: get_outs lightwallet support (Jaquee)
1197cb71 wallet2: commit_tx() lightwallet support (Jaquee)
43b57804 wallet2: refactor is_tx_spendtime_unlocked() (Jaquee)
32e2b003 wallet2: add lightwallet exceptions to common functions (Jaquee)
2e692fc0 wallet2: refresh() lightwallet support (Jaquee)
f44d156c my/openmonero API functions (Jaquee)
288d3c75 wallet2: add remove_obsolete_pool_txs() (Jaquee)
2c6aad7e wallet2: add on_pool_tx_removed callback (Jaquee)
ff7c30aa wallet2: light wallet member variables (Jaquee)
e2a276cb wallet2: add ssl option to init() (Jaquee)
a13540be add string_tools::validate_hex() (Jaquee)
fd773d88 refactor cryptonote_basic::add_tx_pub_key_to_extra (Jaquee)
8bfa6c2d lightwallet rpc server commands (Jaquee)
76961ddc Serializer: string to integer conversion for MyMonero compatibility (Jaquee)
1cf940f2 epee http_client SSL support (Jaquee)
eec10137 CMakeLists.txt - Add openssl include dir (Jaquee)
 2017-10-15 18:25:08 +02:00
Jaquee
97c2e449ce wallet2+API: use separate callbacks for lightwallets 2017-10-15 17:58:28 +02:00
Jaquee
d92618675b walletAPI: correct confirmations in txHistory for unsynced wallets 2017-10-15 17:58:28 +02:00
Jaquee
9442b04302 walletAPI: lightwallet exceptions 2017-10-15 17:57:45 +02:00
Jaquee
fc9229342d walletAPI: add lightwallet login() and importWalletRequest() 2017-10-15 17:57:43 +02:00
Jaquee
79207743b8 walletAPI: init() lightwallet and SSL support 2017-10-15 17:56:35 +02:00
Jaquee
dde5a1fc36 walletAPI: add tx unlock_time 2017-10-15 17:54:17 +02:00
Jaquee
bba5cbed8f wallet2: remove obsolete get_num_rct_outputs() call from create_transactions_2 2017-10-15 17:54:14 +02:00
Jaquee
7a482f302b wallet2: create_transactions_2 lightwallet support 2017-10-15 17:51:20 +02:00
Jaquee
ce61b8189b wallet2: get_outs lightwallet support 2017-10-15 17:50:03 +02:00
Jaquee
1197cb71e9 wallet2: commit_tx() lightwallet support 2017-10-15 17:48:45 +02:00
Jaquee
43b57804f8 wallet2: refactor is_tx_spendtime_unlocked() 2017-10-15 17:48:45 +02:00
Jaquee
32e2b0030e wallet2: add lightwallet exceptions to common functions 2017-10-15 17:48:41 +02:00
Jaquee
2e692fc05a wallet2: refresh() lightwallet support 2017-10-15 17:42:50 +02:00
Jaquee
f44d156cbd my/openmonero API functions 2017-10-15 17:42:29 +02:00
Jaquee
288d3c75c3 wallet2: add remove_obsolete_pool_txs() 2017-10-15 17:39:54 +02:00
Jaquee
2c6aad7ea7 wallet2: add on_pool_tx_removed callback 2017-10-15 17:35:15 +02:00
Jaquee
ff7c30aadc wallet2: light wallet member variables 2017-10-15 17:35:08 +02:00
Riccardo Spagni
56ea442fd3
Merge pull request #2555 
a4b4651c dns_utils: allow an optional DNS server IP in DNS_PUBLIC (moneromooo-monero)
 2017-10-15 17:33:09 +02:00
Riccardo Spagni
d316b3d266
Merge pull request #2554 
d74336d5 wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstr (stoffu)
 2017-10-15 17:32:30 +02:00
Jaquee
e2a276cbb5 wallet2: add ssl option to init() 2017-10-15 17:32:13 +02:00
Jaquee
fd773d88cd refactor cryptonote_basic::add_tx_pub_key_to_extra 2017-10-15 17:32:09 +02:00
Riccardo Spagni
d8bc28cc36
Merge pull request #2552 
69ce33f2 core: fix failure to sync when a tx is already in the pool (moneromooo-monero)
 2017-10-15 17:31:37 +02:00
Riccardo Spagni
62629541a5
Merge pull request #2550 
735fafec simplewallet: allow 1/yes/y as well as true for start_mining options (moneromooo-monero)
 2017-10-15 17:31:14 +02:00
Riccardo Spagni
ce1016254a
Merge pull request #2549 
bf2d9113 simplewallet: fix --restore-from-height being ignored (moneromooo-monero)
 2017-10-15 17:30:53 +02:00
Jaquee
8bfa6c2d9f lightwallet rpc server commands 2017-10-15 17:30:23 +02:00
Riccardo Spagni
5df4ecbb83
Merge pull request #2528 
551a8ea6 mnemonics: new Lojban word list (Wei Tang)
 2017-10-15 17:27:58 +02:00
Riccardo Spagni
5ea20d6944
Merge pull request #2469 
7adceee6 precomputed block hashes are now in blocks of N (currently 256) (moneromooo-monero)
 2017-10-15 17:23:50 +02:00
moneromooo-monero
118a1bed28
rpc: make get_coinbase_tx_sum a restricted RPC 
It's pretty slow and I/O intensive
 2017-10-14 09:49:24 +01:00
moneromooo-monero
7130cf0c61
Add tools::on_startup, and warn about glibc 2.25 bug if found 
https://sourceware.org/bugzilla/show_bug.cgi?id=21778
 2017-10-14 09:12:28 +01:00
moneromooo-monero
22b51e0672
db_lmdb: include chain height when failing to find an output key 
To help debugging logs.
 2017-10-12 13:28:28 +01:00
moneromooo-monero
5db433b3f7
blockchain: avoid exceptions in output verification 
This can happen if we get a bad tx, so let's not spam the log.
 2017-10-12 13:27:20 +01:00
moneromooo-monero
529a6a4af8
core: guard against a mined block not finding all txes in the pool 
This can happen for several reasons, but mainly if another block
was received, which took that tx off the pool.
 2017-10-11 13:00:49 +01:00
moneromooo-monero
a4b4651cb0
dns_utils: allow an optional DNS server IP in DNS_PUBLIC 
tcp://a.b.c.d
 2017-10-10 12:29:05 +01:00
moneromooo-monero
6bd4dac6e2
util: ignore SIGPIPE 
In practice, this seems to cause monero-wallet-rpc to exit
when ^C quits whatever its output is piped into (such as tee),
but it saves, while it did not before.
 2017-10-09 21:46:01 +01:00
moneromooo-monero
7dbf76d0da
Fix an object lifetime bug in net load tests 
The commands handler must not be destroyed before the config
object, or we'll be accessing freed memory.

An earlier attempt at using boost::shared_ptr to control object
lifetime turned out to be very invasive, though would be a
better solution in theory.
 2017-10-09 16:46:42 +01:00
redfish
2051f89fbe cmake: build tests last 
Keep -Werror for src, contrib and do not pass it for tests/
 2017-10-08 20:47:50 -04:00
binaryFate
93ad1f8723 Fix #2559: more flexible print_tx daemon command 2017-10-08 22:35:35 +02:00
moneromooo-monero
4090e8c6e5
simplewallet: add get/set for refresh-from-height 2017-10-08 10:14:44 +01:00
moneromooo-monero
0a872798bc
protocol: kick idle peers by dropping them 
This is safer, as we don't risk break expectations (eg, requesting
block hashes and then receiving a late set of blocks). Dropping a
connection means another will be attempted in a fresh state.

Also bump the kick timeout to 5 minutes, to ensure we only kick
really idle peers.
 2017-10-07 20:29:11 +01:00
moneromooo-monero
bc1b93333e
frob level 1 logs a bit for consistency 
Level 1 logs map to INFO, so setting log level to 1 should
show these. Demote some stuff to DEBUG to avoid spam, though.
 2017-10-07 20:03:42 +01:00
Michał Sałaban
dc19659d16 Remove network_address_base which has been merged with ipv4_network_address in 8b006877 2017-10-07 19:29:30 +02:00
moneromooo-monero
b776c72568
daemon: use @N syntax to output_histogram for specific amounts 
Makes debugging tx verification easier
 2017-10-07 16:45:54 +01:00
moneromooo-monero
c413613416
miner: always update block template when starting 
This fixes using the previous address when starting mining,
then stopping and restarting with a different address
 2017-10-07 11:32:36 +01:00
moneromooo-monero
06fb9bcfcc
wallet2: fix refresh height calc for new wallets 2017-10-07 11:21:11 +01:00
kenshi84
53ad5a0f42
Subaddresses 2017-10-07 13:06:21 +09:00
stoffu
7b8d3ec6ba
wallet-cli: add --do-not-relay option 2017-10-07 12:46:09 +09:00
stoffu
d74336d5c9
wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstr 2017-10-07 12:45:32 +09:00
Michał Sałaban
2183ade0c4 Don't try to create wallet-dir when it's not given, don't crash if wallet-dir already exists. 2017-10-07 02:04:33 +02:00
Riccardo Spagni
86e9de588c
Merge pull request #2548 
7d4ef258 rpc: fix getting txpool transactions (moneromooo-monero)
 2017-10-06 23:00:43 +04:00
Riccardo Spagni
09ccd07bbc
Merge pull request #2542 
180a848c wallet2: Missing underflow check on low heights (landergate)
 2017-10-06 23:00:24 +04:00
Riccardo Spagni
e8a7291d12
Merge pull request #2541 
15e62581 connection_context: initialize m_callback_request_count to 0 (moneromooo-monero)
5fa199c6 copyable_atomic: add a ctor with initial value (moneromooo-monero)
 2017-10-06 22:58:54 +04:00
Riccardo Spagni
2ff832c576
Merge pull request #2540 
71c7f8d0 core: fix logging the one time public key on error (moneromooo-monero)
 2017-10-06 22:58:20 +04:00
Riccardo Spagni
fb7dcb6ec0
Merge pull request #2539 
93ed9321 cmake: add libversion and libcheckpoints to libwallet_merged (redfish)
 2017-10-06 22:57:20 +04:00
Riccardo Spagni
4a20a5b5ea
Merge pull request #2537 
269a2a01 blockchain: fix off by one getting blocks (moneromooo-monero)
 2017-10-06 22:56:17 +04:00
Riccardo Spagni
478b14b565
Merge pull request #2534 
4e115a3a core: remove out sorting from v7 rules (moneromooo-monero)
 2017-10-06 22:55:00 +04:00
Riccardo Spagni
6cf36b4e96
Merge pull request #2530 
cbc5508b construct_tx_and_get_tx_key: return sorted sources for print_ring_memebrs to work properly (stoffu)
 2017-10-06 22:54:19 +04:00
Riccardo Spagni
1c044b162c
Merge pull request #2529 
bd937139 wallet2: error check for generate_key_image_helper, removed redundant wallet_generate_key_image_helper (stoffu)
 2017-10-06 22:53:28 +04:00
Riccardo Spagni
c58ec8cdc1
Merge pull request #2468 
986d03d4 simplewallet: allow to set threshold before warning about tx backlog (selsta)
 2017-10-06 22:50:41 +04:00
moneromooo-monero
8f0cea6355
add a command_line function to check for defaulted options 2017-10-06 10:56:18 +01:00
moneromooo-monero
27fdaaa409
Fix building with -DARCH=default -DNO_AES=ON 2017-10-06 08:47:03 +01:00
moneromooo-monero
cba3449415
rpc: out_peers now works again 2017-10-06 08:40:14 +01:00
Lee Clagett
8b00687735 Upgrades to epee::net_utils::network_address 
- internal nullptr checks
  - prevent modifications to network_address (shallow copy issues)
  - automagically works with any type containing interface functions
  - removed fnv1a hashing
  - ipv4_network_address now flattened with no base class
 2017-10-05 11:57:09 -04:00
moneromooo-monero
7e7acdc32b
daemon: catch out of range exceptions too when calling stoll/stoi 
And any other exception, just to be safe
 2017-10-03 17:36:44 +01:00
moneromooo-monero
8028dde7a6
block_queue: use boost::uuids::nil_uuid where appropriate 2017-10-03 11:55:45 +01:00
moneromooo-monero
f139a6cad0
wallet2: fix backlog being off by 1 
We don't want to count "partly filled" blocks in this case
 2017-10-03 11:49:46 +01:00
moneromooo-monero
b5b4abb8a6
simplewallet: fix setting default-ring-size to 0 
It'd be set to the current wallet default instead
 2017-10-03 11:45:02 +01:00
moneromooo-monero
54940d8ca4
blockchain_import: remove a few commented out obsolete lines 2017-10-03 09:15:57 +01:00
moneromooo-monero
452d4fae39
tests: fix hashchain unit tests 
and relax the not-empty safety check to stay more intuitiuve
 2017-10-03 00:51:53 +01:00
stoffu
bd9371395e
wallet2: error check for generate_key_image_helper, removed redundant wallet_generate_key_image_helper 2017-10-03 08:13:00 +09:00
stoffu
cbc5508b15
construct_tx_and_get_tx_key: return sorted sources for print_ring_memebrs to work properly 2017-10-03 08:12:28 +09:00
Riccardo Spagni
5f430cedd8
Merge pull request #2515 
c34093db simplewallet: add privacy warning when using an untrusted demon (moneromooo-monero)
 2017-10-02 23:30:20 +04:00
Riccardo Spagni
87d0516f7d
Merge pull request #2513 
309290d1 Source updates are in a source subdirectory (moneromooo-monero)
 2017-10-02 23:29:25 +04:00
Riccardo Spagni
3bab2676ec
Merge pull request #2512 
792ba4f0 Log categories can now be added to and removed from (moneromooo-monero)
48f92eb6 easylogging++: add categories getter (moneromooo-monero)
f35afe62 epee: factor log level/categories setting (moneromooo-monero)
 2017-10-02 23:28:59 +04:00
Riccardo Spagni
db45291c8d
Merge pull request #2506 
c3de19ed json_object: add missing do_not_relay to tx_in_pool serialization (moneromooo-monero)
 2017-10-02 23:27:21 +04:00
selsta
986d03d4b2 simplewallet: allow to set threshold before warning about tx backlog 2017-10-02 21:23:33 +02:00
Riccardo Spagni
abe24f4429
Merge pull request #2504 
f182acdd dns_utils: query DNS records in parallel (moneromooo-monero)
 2017-10-02 23:21:10 +04:00
Riccardo Spagni
737717c111
Merge pull request #2491 
d5a9edf2 wallet2: fix exception on split txes (moneromooo-monero)
5c5b0fd0 wallet2: print unused indices on a single line (moneromooo-monero)
 2017-10-02 23:17:57 +04:00
Riccardo Spagni
3bf20a77f2
Merge pull request #2470 
2e59f6ea rpc: add new RPCs to get and set limits (MaxXor)
 2017-10-02 23:15:22 +04:00
moneromooo-monero
37c12119ab
wallet2: fix hash chain trimming when the inner chain becomes empty 
It'd prevent further syncing. Recovery of empty hash chains is
automatic, but requires a running daemon
 2017-10-02 12:52:22 +01:00
moneromooo-monero
69ce33f217
core: fix failure to sync when a tx is already in the pool 2017-09-29 21:34:10 +01:00
moneromooo-monero
735fafecb0
simplewallet: allow 1/yes/y as well as true for start_mining options 
Also mention those options in the start_mining help line
 2017-09-29 19:17:25 +01:00
moneromooo-monero
bf2d911365
simplewallet: fix --restore-from-height being ignored 2017-09-29 19:06:14 +01:00
moneromooo-monero
7d4ef25800
rpc: fix getting txpool transactions 2017-09-29 16:29:26 +01:00
moneromooo-monero
4e115a3a4c
core: remove out sorting from v7 rules 
and restore random shuffle of outputs

This turned out to have a flaw (sort order depends on output
index), and this doesn't really bring much anyway
 2017-09-27 12:42:08 +01:00
landergate
180a848cbe wallet2: Missing underflow check on low heights 
Lack of it results in `m_refresh_from_block_height` being < 0 (18446744...) on low heights, which blocks `process_new_blockchain_entry` and never process coins on heights less than blocks_per_month.
Follow-up to #2258
 2017-09-27 14:17:48 +03:00
moneromooo-monero
15e6258136
connection_context: initialize m_callback_request_count to 0 2017-09-27 11:43:12 +01:00
moneromooo-monero
71c7f8d0dc
core: fix logging the one time public key on error 2017-09-27 11:40:05 +01:00
redfish
93ed932143 cmake: add libversion and libcheckpoints to libwallet_merged 
Needed to link monero-core Qt wallet.
 2017-09-27 00:57:02 -04:00
moneromooo-monero
269a2a01ef
blockchain: fix off by one getting blocks 2017-09-27 00:31:49 +01:00
Riccardo Spagni
5f7cddeb53
Merge pull request #2533 
97cdd4c9 core: undo output sorting (moneromooo-monero)
 2017-09-26 15:59:32 +02:00
moneromooo-monero
97cdd4c92f
core: undo output sorting 
It looks like it may be buggy
 2017-09-26 13:23:31 +01:00
Wei Tang
551a8ea60e mnemonics: new Lojban word list 
Word list authored by: sorpaas
Sources:
  lo gimste jo'u lo ma'oste (http://guskant.github.io/lojbo/gismu-cmavo.html)
  N-grams of Lojban corpus (https://mw.lojban.org/papri/N-grams_of_Lojban_corpus)
 2017-09-26 06:42:17 +08:00
Riccardo Spagni
21c2c08041
Merge pull request #2527 
ba6907f6 core: fix creation of v1 txes (moneromooo-monero)
 2017-09-25 23:29:32 +02:00
moneromooo-monero
ba6907f661
core: fix creation of v1 txes 2017-09-25 22:27:30 +01:00
Riccardo Spagni
0c5730b101
Merge pull request #2526 
db215ecd checkpoints: add missing CMakeLists.txt (moneromooo-monero)
 2017-09-25 22:46:46 +02:00
moneromooo-monero
db215ecdb6
checkpoints: add missing CMakeLists.txt 2017-09-25 21:44:53 +01:00
moneromooo-monero
36c3465b98
wallet2: do not keep block hashes below last checkpoint 
This saves a lot of space and load/save time for wallet caches
 2017-09-25 21:16:40 +01:00
moneromooo-monero
cdbbe99c82
checkpoints: add a token checkpoint on testnet (the genesis block) 2017-09-25 21:16:35 +01:00
moneromooo-monero
493fad8053
serialization: add deque serialization 2017-09-25 21:16:32 +01:00
moneromooo-monero
fa54b20584
fix typo in basic and core CMakeLists.txt 2017-09-25 21:16:29 +01:00
moneromooo-monero
5d65a75b69
move checkpoints in a separate library 2017-09-25 21:16:26 +01:00
Riccardo Spagni
85f4b600d2
Merge pull request #2466 
bc429e9c daemon: make this build with boost 1.61 (moneromooo-monero)
 2017-09-25 21:06:47 +02:00
Riccardo Spagni
0d52b1392f
Merge pull request #2525 
8e0670c6 version: fix link to new version strings (moneromooo-monero)
 2017-09-25 20:14:18 +02:00
moneromooo-monero
8e0670c684
version: fix link to new version strings 
p2p uses it, and the cpp file needs to know the symbols should
be public
 2017-09-25 19:01:56 +01:00
moneromooo-monero
2ec928badb
wallet2: simplify tx processing a bit 2017-09-25 18:35:51 +01:00
moneromooo-monero
740e6533a5
wallet2: factor some of the tx scanning code 2017-09-25 16:11:28 +01:00
Riccardo Spagni
74c4f1a563
Merge pull request #2460 
3487d810 cryptonote_protocol: fix needless chain hashes downloads (moneromooo-monero)
 2017-09-25 17:01:53 +02:00
Riccardo Spagni
13be8115e4
Merge pull request #2458 
7f2f6ee1 protocol: remove hop count on block propagation (moneromooo-monero)
 2017-09-25 17:00:47 +02:00
Riccardo Spagni
e5a2cdbfad
Merge pull request #2457 
d2d8a41c Use actual batch size for resize estimates (Howard Chu)
 2017-09-25 16:57:07 +02:00
Riccardo Spagni
32bbe62120
Merge pull request #2456 
91def9a5 daemon, wallet: add --max-log-file-size option (selsta)
 2017-09-25 16:54:08 +02:00
Riccardo Spagni
0e74777071
Merge pull request #2452 
0aaaca29 tx_pool: set the "invalid input" bit when check_tx_inputs fails (moneromooo-monero)
9236823b simplewallet: print tx rejection reason where it was missing (moneromooo-monero)
3dee3301 core_rpc_server: print tx rejection reason at L0 too (moneromooo-monero)
 2017-09-25 16:53:07 +02:00
Riccardo Spagni
c2346c6c59
Merge pull request #2424 
28b72b6e tx_pool: pre-init tvc.m_verifivation_failed before processing (moneromooo-monero)
50a629b2 core_tests: catch (impossible in practice) tx extra api failure (moneromooo-monero)
fee15ef1 wallet2: catch failure to parse address (moneromooo-monero)
1399e26d net_peerlist: remove dead code (moneromooo-monero)
50e09698 tx_pool: guard against failure getting tx hash (moneromooo-monero)
54cc209a wallet_rpc_server: catch failure to create directory (moneromooo-monero)
3e55099c wallet_rpc_server: init m_vm to NULL in ctor (moneromooo-monero)
7d0dde5e wallet_args: remove redundant default value for --log-file (moneromooo-monero)
ed4a3350 wallet2: catch failure to save keys file (moneromooo-monero)
44434c8a wallet2_api: check whether dynamic_cast returns NULL (moneromooo-monero)
92f2f687 core: check return value from parse_hexstr_to_binbuff (moneromooo-monero)
5475692e wallet2_api: remove an unused, uninitialized, field (moneromooo-monero)
a7ba3de1 libwallet_api_tests: initialize newblock_triggered on reset (moneromooo-monero)
b2763ace wallet2_api: init error code to "no error" in the ctor (moneromooo-monero)
b5faac53 get_blockchain_top now returns void (moneromooo-monero)
2e44d8f2 wallet_rpc_server: guard against exceptions (moneromooo-monero)
4230876b simplewallet: guard against I/O exceptions (moneromooo-monero)
06c1e057 daemon: initialize decode_as_json in RPC request (moneromooo-monero)
11f71af5 http_base: init size_t in http_request_info ctor (moneromooo-monero)
 2017-09-25 16:52:27 +02:00
Riccardo Spagni
5953724f69
Merge pull request #2443 
ffe27127 wallet_rpc_server: fix index for newly added address book entry (moneromooo-monero)
 2017-09-25 16:51:07 +02:00
Riccardo Spagni
b911130a46
Merge pull request #2442 
e29282d2 build: auto update version info without manually deleting version.h (stoffu)
 2017-09-25 16:50:35 +02:00
Riccardo Spagni
08ada1fa8b
Merge pull request #2440 
6137a0b9 blockchain: reject unsorted ins and outs from v7 (moneromooo-monero)
16afab90 core: sort ins and outs key key image and public key, respectively (moneromooo-monero)
0c36b9f9 common: add apply_permutation file and function (moneromooo-monero)
 2017-09-25 16:49:01 +02:00
moneromooo-monero
28b72b6ecc
tx_pool: pre-init tvc.m_verifivation_failed before processing 
CID 175316
 2017-09-25 15:48:59 +01:00
moneromooo-monero
fee15ef1a9
wallet2: catch failure to parse address 
CID 175297
 2017-09-25 15:48:48 +01:00
moneromooo-monero
1399e26d7e
net_peerlist: remove dead code 
CID 175290
 2017-09-25 15:48:45 +01:00
moneromooo-monero
50e096987b
tx_pool: guard against failure getting tx hash 
Should be impossible in practice, but easy change

CID 175282
 2017-09-25 15:48:42 +01:00
moneromooo-monero
54cc209a5e
wallet_rpc_server: catch failure to create directory 
CID 175281
 2017-09-25 15:48:39 +01:00
moneromooo-monero
3e55099cb2
wallet_rpc_server: init m_vm to NULL in ctor 
CID 175279
 2017-09-25 15:48:36 +01:00
moneromooo-monero
7d0dde5eb5
wallet_args: remove redundant default value for --log-file 
CID 175265
 2017-09-25 15:48:33 +01:00
moneromooo-monero
ed4a33502d
wallet2: catch failure to save keys file 
CID 161848
 2017-09-25 15:48:30 +01:00
moneromooo-monero
44434c8a37
wallet2_api: check whether dynamic_cast returns NULL 
CID 161844
 2017-09-25 15:48:27 +01:00
moneromooo-monero
92f2f687b9
core: check return value from parse_hexstr_to_binbuff 2017-09-25 15:48:24 +01:00
moneromooo-monero
5475692ed5
wallet2_api: remove an unused, uninitialized, field 
Silences CID 161874
 2017-09-25 15:48:21 +01:00
moneromooo-monero
b2763ace06
wallet2_api: init error code to "no error" in the ctor 
CID 161872
 2017-09-25 15:48:16 +01:00
moneromooo-monero
b5faac5304
get_blockchain_top now returns void 
It was always returning true, and could not be foreseen to
usefully return errors in the future. This silences CID 162652
as well as saves some checking code in a few places.
 2017-09-25 15:48:13 +01:00
moneromooo-monero
2e44d8f23c
wallet_rpc_server: guard against exceptions 
CID 175305
 2017-09-25 15:48:10 +01:00
moneromooo-monero
4230876b31
simplewallet: guard against I/O exceptions 
CID 175308
 2017-09-25 15:48:06 +01:00
moneromooo-monero
06c1e05735
daemon: initialize decode_as_json in RPC request 
CID 161886
 2017-09-25 15:48:03 +01:00
Riccardo Spagni
174f2fb4da
Merge pull request #2428 
054054c9 p2p: disable gray list housekeeping when an exclusive node is given (moneromooo-monero)
 2017-09-25 16:46:26 +02:00
Riccardo Spagni
c2e46edca2
Merge pull request #2398 
e0592e87 dns_utils: remove a few obsolete things (moneromooo-monero)
 2017-09-25 16:44:37 +02:00
Riccardo Spagni
ce37967dd2
Merge pull request #2386 
a15e8583 wallet2: guard against daemon sending txes in the wrong order (moneromooo-monero)
8fe5f609 rpc: order transactions in the order they were requested (moneromooo-monero)
 2017-09-25 16:40:54 +02:00
Riccardo Spagni
216395d43e
Merge pull request #2379 
9c83f806 Do not create file when RPC user/pass is given and use file locking (Lee Clagett)
 2017-09-25 16:40:35 +02:00
Riccardo Spagni
ec0e144e90
Merge pull request #2377 
b5cbdce8 wallet2: correctly handle in/out payments for view-only wallet (stoffu)
 2017-09-25 16:40:16 +02:00
Riccardo Spagni
44ad32fd4a
Merge pull request #2357 
58015df4 Fix getblocktemplate RPC returning wrong reserved_offset (Guillaume LE VAILLANT)
 2017-09-25 16:39:01 +02:00
Riccardo Spagni
40d213154b
Merge pull request #2289 
6ee1116d store is optional during close and defaults to true; except during descruction (m2049r)
 2017-09-25 16:38:14 +02:00
Riccardo Spagni
c6306e75e7
Merge pull request #2257 
651baaec wallet: add encrypted seed functionality (moneromooo-monero)
 2017-09-25 16:37:17 +02:00
m2049r
6ee1116d75 store is optional during close and defaults to true; except during descruction 2017-09-23 00:52:09 +02:00
moneromooo-monero
c34093db58
simplewallet: add privacy warning when using an untrusted demon 2017-09-22 22:19:22 +01:00
moneromooo-monero
309290d1c7
Source updates are in a source subdirectory 
rather than in the same directory as the prebuilt versions
 2017-09-22 21:48:19 +01:00
moneromooo-monero
792ba4f0fe
Log categories can now be added to and removed from 
Also, set_log without parameters now prints the log categories
 2017-09-22 18:08:14 +01:00
moneromooo-monero
c3de19edd6
json_object: add missing do_not_relay to tx_in_pool serialization 2017-09-21 13:37:30 +01:00
Riccardo Spagni
1f9058187c
Merge pull request #2496 
3b8b4be5 tx_pool: drop invalid txes from the pool on startup (moneromooo-monero)
 2017-09-21 12:07:35 +02:00
Riccardo Spagni
8cc9b0e739
Merge pull request #2492 
e457aa51 blockchain: fix crash checking pre-validated txids (moneromooo-monero)
 2017-09-21 12:07:22 +02:00
Riccardo Spagni
bd85a47a29
Merge pull request #2477 
9aeae7a2 db_lmdb: fix use of uninitialized key in for_blocks_range (moneromooo-monero)
 2017-09-21 12:07:08 +02:00
Riccardo Spagni
0f071848a1
Merge pull request #2479 
58908295 Fixes static_assert on arm and ppc builds (Lee Clagett)
 2017-09-21 11:50:34 +02:00
moneromooo-monero
f182acdd36
dns_utils: query DNS records in parallel 2017-09-21 09:23:08 +01:00
Riccardo Spagni
48512acda9
Merge pull request #2324 
c09aa94d daemon: indicate whether  the spent key image is mined or unconfirmed (stoffu)
 2017-09-21 10:12:24 +02:00
Riccardo Spagni
07312a7d6e
Merge pull request #2302 
ef005f5e p2p: add a couple early outs when the stop signal is received (moneromooo-monero)
80d361c7 abstract_tcp_server2: improve tracking/cancelling of early connections (moneromooo-monero)
 2017-09-21 10:11:33 +02:00
stoffu
e29282d208
build: auto update version info without manually deleting version.h 2017-09-21 07:47:37 +09:00
stoffu
c09aa94d34
daemon: indicate whether the spent key image is mined or unconfirmed 2017-09-21 07:46:44 +09:00
stoffu
b5cbdce8a6
wallet2: correctly handle in/out payments for view-only wallet 2017-09-21 07:46:19 +09:00
Riccardo Spagni
a6403846ef
Merge pull request #2441 
fee3c3ed Update wallet2.cpp for misspelling (Matthew Campassi)
 2017-09-20 21:41:33 +02:00
Riccardo Spagni
786a4ae9ea
Merge pull request #2429 
55b91d86 wallet: fix --help and --version erroring out (moneromooo-monero)
 2017-09-20 21:41:09 +02:00
Riccardo Spagni
10d60d2524
Merge pull request #2414 
ea016330 updated clarification bc_dyn_stats (Matthew Campassi)
5aa2f24b clarification bc_dyn_stats (Matthew Campassi)
 2017-09-20 21:37:55 +02:00
Riccardo Spagni
8f1f43163a
Merge pull request #2412 
81fb2f53 Silence more stupid gcc warnings (Howard Chu)
 2017-09-20 21:37:40 +02:00
Riccardo Spagni
8711c355fc
Merge pull request #2410 
20256b7c Fix AC power supply detection on Linux (Guillaume LE VAILLANT)
 2017-09-20 21:36:09 +02:00
Riccardo Spagni
72207fd27a
Merge pull request #2381 
840aed1c monero-wallet-cli: New command 'wallet_info' improved (rbrunner7)
9bdd985c monero-wallet-cli: New command 'wallet_info' (rbrunner7)
 2017-09-20 21:34:48 +02:00
Riccardo Spagni
75563db6e3
Merge pull request #2376 
e3680b69 Rename m_listenning_port to m_listening_port (MaxXor)
a1ea475f Delete UPnP port mapping on exit (MaxXor)
 2017-09-20 21:33:21 +02:00
moneromooo-monero
3b8b4be5cb
tx_pool: drop invalid txes from the pool on startup 
instead of just failing

This is a workaround for bad tx blobs being inserted in the
pool for unknown reasons
 2017-09-20 18:55:16 +01:00
moneromooo-monero
e457aa51f4
blockchain: fix crash checking pre-validated txids 2017-09-20 10:46:13 +01:00
moneromooo-monero
d5a9edf27a
wallet2: fix exception on split txes 2017-09-20 10:35:15 +01:00
moneromooo-monero
5c5b0fd048
wallet2: print unused indices on a single line 
Decreases log spam massively on large wallets
 2017-09-20 10:34:45 +01:00
Lee Clagett
5890829552 Fixes static_assert on arm and ppc builds 2017-09-19 10:57:01 -04:00
moneromooo-monero
9aeae7a224
db_lmdb: fix use of uninitialized key in for_blocks_range 2017-09-19 14:11:24 +01:00
MaxXor
2e59f6ea50 rpc: add new RPCs to get and set limits 2017-09-19 10:30:55 +02:00
moneromooo-monero
7adceee634
precomputed block hashes are now in blocks of N (currently 256) 
This shaves a lot of space off binaries
 2017-09-18 16:29:00 +01:00
Riccardo Spagni
1a73843cec
Merge pull request #2446 
6d0ca7d1 Tweak concurrency limits (Howard Chu)
510d0d47 Use a threadpool (Howard Chu)
 2017-09-18 13:19:26 +02:00
Riccardo Spagni
69e039aa19
Merge pull request #2023 
f761dbae Remove 1.25x multiplier from tx_pool (Nano Akron)
 2017-09-18 13:11:57 +02:00
Riccardo Spagni
591e53445b
Merge pull request #2044 
0299cb77 Fix various oversights/bugs in ZMQ RPC server code (Thomas Winget)
77986023 json serialization for rpc-relevant monero types (Thomas Winget)
5c1e08fe Refactor some things into more composable (smaller) functions (Thomas Winget)
9ac2ad07 DRY refactoring (Thomas Winget)
 2017-09-18 13:08:16 +02:00
moneromooo-monero
bc429e9c6d
daemon: make this build with boost 1.61 2017-09-18 11:24:49 +01:00
moneromooo-monero
6137a0b94d
blockchain: reject unsorted ins and outs from v7 
This ensures no information is leaked by the ordering
 2017-09-18 11:23:15 +01:00
Howard Chu
d2d8a41c47
Use actual batch size for resize estimates 
And optimize import startup:

Remember start_height position during initial count_blocks pass
to avoid having to reread entire file again to arrive at start_height
 2017-09-17 22:08:40 +01:00
moneromooo-monero
3487d81034
cryptonote_protocol: fix needless chain hashes downloads 
The last known hash was calculated incorrectly, causing
further chain hash downloads to restart from the current
chain. When the block queue has close to 10k blocks waiting,
this causes frequent downloads of 10k more hashes, but
with only the last few hashes actually being useful.
 2017-09-17 14:13:59 +01:00
moneromooo-monero
7f2f6ee1c9
protocol: remove hop count on block propagation 
It is unused, as it was apparently a future optimization,
and it leaks some information (though since pools publish
thei blocks they find, that amount seems small).
 2017-09-17 10:26:12 +01:00
selsta
91def9a59b daemon, wallet: add --max-log-file-size option 2017-09-17 04:42:45 +02:00
moneromooo-monero
0aaaca29a2
tx_pool: set the "invalid input" bit when check_tx_inputs fails 2017-09-16 11:27:52 +01:00
moneromooo-monero
9236823bf4
simplewallet: print tx rejection reason where it was missing 2017-09-16 10:33:42 +01:00
moneromooo-monero
3dee3301ba
core_rpc_server: print tx rejection reason at L0 too 2017-09-16 10:32:42 +01:00
Howard Chu
6d0ca7d11f
Tweak concurrency limits 
Create capacity for 2x max, but lie about it
 2017-09-15 00:28:48 +01:00
Howard Chu
510d0d4753
Use a threadpool 
Instead of constantly creating and destroying threads
 2017-09-14 21:42:48 +01:00
Nano Akron
f761dbaeaf Remove 1.25x multiplier from tx_pool 2017-09-14 21:26:19 +01:00
Riccardo Spagni
7abdba0a5c
Merge pull request #2438 
9443eec1 core: guard against exceptions in tx verification worker threads (moneromooo-monero)
 2017-09-14 18:31:46 +02:00
Riccardo Spagni
e0382a8da2
Merge pull request #2417 
a9845cc3 rpc: get_txpool_backlog is now unrestricted (moneromooo-monero)
 2017-09-14 18:26:30 +02:00
Riccardo Spagni
3399c2a257
Merge pull request #2404 
e5238adf update checkpoint hashes (Riccardo Spagni)
d4f56bdf update hardcoded checkpoints (Riccardo Spagni)
ed730511 update checkpoints.dat (Riccardo Spagni)
 2017-09-14 18:25:43 +02:00
Riccardo Spagni
718820cd96
Merge pull request #2396 
dbfef643 tx_pool: catch exceptions in LockedTXN dtor (moneromooo-monero)
 2017-09-14 18:25:28 +02:00
Riccardo Spagni
4c07297dc6
Merge pull request #2392 
6ac61100 Add a --fluffy-blocks option to relay blocks as fluffy blocks (moneromooo-monero)
 2017-09-14 18:25:15 +02:00
moneromooo-monero
ffe2712726
wallet_rpc_server: fix index for newly added address book entry 2017-09-13 11:02:06 +01:00
moneromooo-monero
16afab900d
core: sort ins and outs key key image and public key, respectively 
This avoids leaking some small amount of information
 2017-09-13 09:25:05 +01:00
moneromooo-monero
0c36b9f931
common: add apply_permutation file and function 
This algorithm is adapted from Raymond Chen's code:
https://blogs.msdn.microsoft.com/oldnewthing/20170109-00/?p=95145
 2017-09-13 09:25:01 +01:00
Matthew Campassi
fee3c3ed1e Update wallet2.cpp for misspelling 
Misspelling in wallet2.cpp
 2017-09-12 16:11:45 -05:00
moneromooo-monero
651baaec46
wallet: add encrypted seed functionality 
This uses luigi1111's CN_Add method.
See https://xmr.llcoins.net for details.
 2017-09-12 13:56:01 +01:00
moneromooo-monero
9443eec10f
core: guard against exceptions in tx verification worker threads 2017-09-12 12:07:10 +01:00
moneromooo-monero
a15e858302
wallet2: guard against daemon sending txes in the wrong order 2017-09-11 16:48:28 +01:00
moneromooo-monero
8fe5f609d1
rpc: order transactions in the order they were requested 2017-09-11 16:48:25 +01:00
moneromooo-monero
55b91d8605
wallet: fix --help and --version erroring out 2017-09-10 14:12:32 +01:00
moneromooo-monero
054054c92f
p2p: disable gray list housekeeping when an exclusive node is given 
Exclusive nodes may be used for privacy reasons, and thus we don't
want to connect to other nodes, even for checking connectivity.

See https://github.com/monero-project/monero/issues/2346
 2017-09-10 13:11:42 +01:00
moneromooo-monero
a9845cc344
rpc: get_txpool_backlog is now unrestricted 2017-09-08 23:47:11 +01:00
Matthew Campassi
ea01633024 updated clarification bc_dyn_stats 
updated clarification of required parameter for bc_dyn_stats
 2017-09-08 11:31:58 -05:00
Matthew Campassi
5aa2f24b2a clarification bc_dyn_stats 
clarification of required parameter for bc_dyn_stats
 2017-09-08 11:03:16 -05:00
Howard Chu
81fb2f5347
Silence more stupid gcc warnings 2017-09-08 11:36:49 +01:00
Guillaume LE VAILLANT
20256b7c04 Fix AC power supply detection on Linux 
The /sys/class/power_supply/*/present file usually does not exist for
AC power supplies.
 2017-09-08 11:07:56 +02:00
Riccardo Spagni
e5238adfb3
update checkpoint hashes 2017-09-06 17:32:48 +02:00
Riccardo Spagni
d4f56bdf09
update hardcoded checkpoints 2017-09-06 09:18:46 +02:00
Riccardo Spagni
ed730511dc
update checkpoints.dat 2017-09-06 09:18:40 +02:00
Thomas Winget
0299cb77ca
Fix various oversights/bugs in ZMQ RPC server code 
- Add some RPC commands (and touch up a couple others)
- some bounds checking
- some better pointer management
- const correctness and error handling

-- Thanks @vtnerd for type help with serialization and CMake changes
 2017-09-05 12:20:40 -04:00
Thomas Winget
77986023c3
json serialization for rpc-relevant monero types 
Structured {de-,}serialization methods for (many new) types
which are used for requests or responses in the RPC.

New types include RPC requests and responses, and structs which compose
types within those.

# Conflicts:
#	src/cryptonote_core/blockchain.cpp
 2017-09-05 12:20:27 -04:00
Thomas Winget
5c1e08fe80
Refactor some things into more composable (smaller) functions 
This commit refactors some of the rpc-related functions in the
Blockchain class to be more composable.  This change was made
in order to make implementing the new zmq rpc easier without
trampling on the old rpc.

New functions:
  Blockchain::get_num_mature_outputs
  Blockchain::get_random_outputs
  Blockchain::get_output_key
  Blockchain::get_output_key_mask_unlocked

  Blockchain::find_blockchain_supplement (overload)

functions which previously had this functionality inline now call these
functions as necessary.
 2017-09-05 12:17:32 -04:00
moneromooo-monero
dbfef643ed
tx_pool: catch exceptions in LockedTXN dtor 
This might prevent some calls to terminate when the LockedTXN
dtor is called as part of stack unwinding caused by another
exception in the first place.
 2017-09-04 10:18:38 +01:00
moneromooo-monero
e0592e87d8
dns_utils: remove a few obsolete things 2017-09-04 10:04:31 +01:00
moneromooo-monero
6ac61100a1
Add a --fluffy-blocks option to relay blocks as fluffy blocks 
Defaults to off, but fluffy blocks are forced enabled on testnet
 2017-09-03 11:11:11 +01:00
Howard Chu
1181848748
Use latest height for fork date estimate 2017-09-02 11:44:12 +01:00
Riccardo Spagni
02e5dcd2fa
Merge pull request #2384 
4e0e4e99 blockchain_import: warn for chunks over 500000, not 100000 (moneromooo-monero)
5b29e87f blockchain_import: properly cleanup core/db on exit (moneromooo-monero)
e167c4d9 blockchain_import: do not error out on truncated files (moneromooo-monero)
 2017-09-02 11:32:46 +02:00
Riccardo Spagni
c919ca4f1d
Merge pull request #2374 
e72e625e tx_pool: wrap tx meta updates in a LockedTXN (moneromooo-monero)
 2017-09-02 11:31:19 +02:00
Riccardo Spagni
1e57e48342
Merge pull request #2372 
c867357a cryptonote_protocol: error handling on cleanup_handle_incoming_blocks (moneromooo-monero)
ce901fcb Fix blockchain_import wedge on exception in cleanup_handle_incoming_blocks (moneromooo-monero)
84fa015e core: guard against exceptions in handle_incoming_{block,tx} (moneromooo-monero)
 2017-09-02 11:30:57 +02:00
Riccardo Spagni
ee1a766861
Merge pull request #2370 
3d19ab70 Revert "Cleanup test impact of moving blockchain_db_types()" (Howard Chu)
a95e460c move db specific options to BlockchainDB (moneromooo-monero)
 2017-09-02 11:30:38 +02:00
Riccardo Spagni
eb8dac52df
Merge pull request #2364 
63d8dddc cryptonote_protocol: remove old spans when received as old blocks (moneromooo-monero)
 2017-09-02 11:30:21 +02:00
Riccardo Spagni
e19b68b005
Merge pull request #2362 
adce8ae4 simplewallet: new "fee" command to display fee information (moneromooo-monero)
 2017-09-02 11:30:07 +02:00
Riccardo Spagni
2560948f69
Merge pull request #2342 
2e338ca5 wallet2: account for huge testnet reorgs for estimating height (moneromooo-monero)
 2017-09-02 11:29:53 +02:00
Riccardo Spagni
5551fcf60b
Merge pull request #2329 
e3c4395a p2p: init hashes after deserializing a network address (moneromooo-monero)
 2017-09-02 11:29:40 +02:00
Riccardo Spagni
eec3527e33
Merge pull request #2316 
0c6c3eb3 Silence stupid fallthru warning in gcc 7 (Howard Chu)
 2017-09-02 11:29:11 +02:00
Riccardo Spagni
79a0defad7
Merge pull request #2310 
ea996f91 clarification of parameters for print_coinbase_tx_sum (Matthew Campassi)
 2017-09-02 11:28:41 +02:00
Riccardo Spagni
10da3051c2
Merge pull request #2309 
d58700e0 WalletAPI: only allow trusted daemon when importing key images (Jaquee)
8a9bbd26 WalletAPI: copy wallet data when creating a view only wallet (Jaquee)
d27fe32e wallet2: export/import wallet data functions (Jaquee)
225a25f3 import_key_images - allow importing without being connected to daemon (Jaquee)
 2017-09-02 11:28:25 +02:00
moneromooo-monero
4e0e4e9942
blockchain_import: warn for chunks over 500000, not 100000 
We have a lot of 350000 byte blocks now.
 2017-09-01 22:48:33 +01:00
moneromooo-monero
5b29e87f85
blockchain_import: properly cleanup core/db on exit 2017-09-01 11:59:24 +01:00
moneromooo-monero
e167c4d9a1
blockchain_import: do not error out on truncated files 
This will happen often when downloading from a live file
 2017-09-01 11:58:51 +01:00
MaxXor
e3680b6936 Rename m_listenning_port to m_listening_port 2017-09-01 09:50:22 +02:00
rbrunner7
840aed1cf3 monero-wallet-cli: New command 'wallet_info' improved 2017-08-31 18:01:15 +02:00
Thomas Winget
9ac2ad0744
DRY refactoring 2017-08-31 07:48:27 -04:00
rbrunner7
9bdd985cee monero-wallet-cli: New command 'wallet_info' 2017-08-31 10:11:20 +02:00
Lee Clagett
9c83f8063d Do not create file when RPC user/pass is given and use file locking 2017-08-30 17:39:59 -04:00
MaxXor
a1ea475fff Delete UPnP port mapping on exit 2017-08-29 23:28:23 +02:00
moneromooo-monero
e72e625eb1
tx_pool: wrap tx meta updates in a LockedTXN 2017-08-29 16:35:19 +01:00
moneromooo-monero
adce8ae466
simplewallet: new "fee" command to display fee information 
including expected transaction backlog at different priorities
 2017-08-29 16:28:18 +01:00
moneromooo-monero
c867357adc
cryptonote_protocol: error handling on cleanup_handle_incoming_blocks 2017-08-29 16:11:39 +01:00
moneromooo-monero
ce901fcb31
Fix blockchain_import wedge on exception in cleanup_handle_incoming_blocks 2017-08-29 15:43:32 +01:00
Howard Chu
3d19ab7067 Revert "Cleanup test impact of moving blockchain_db_types()" 
This reverts commit 3dd34a49ef.
 2017-08-29 13:28:16 +01:00
moneromooo-monero
84fa015e77
core: guard against exceptions in handle_incoming_{block,tx} 
When one happens, cleanup must be called or the incoming tx
lock will stay locked
 2017-08-29 13:01:45 +01:00
moneromooo-monero
a95e460c71
move db specific options to BlockchainDB 
Avoids common depending on blockchain_db, which can cause
link errors.
 2017-08-29 11:43:34 +01:00
moneromooo-monero
63d8dddc0a
cryptonote_protocol: remove old spans when received as old blocks 
fixes getting those in a loop
 2017-08-28 00:42:58 +01:00
Riccardo Spagni
72b5f37f58
Merge pull request #2349 
1914c999 txpool: update db tx metadata when it changes (moneromooo)
4dbf29bd txpool: add tx size median to the pool stats (moneromooo)
 2017-08-27 18:15:13 +02:00
Riccardo Spagni
e00238a355
Merge pull request #2347 
5807529e blockchain: cap memory size of retrieved blocks (moneromooo-monero)
c1b10381 rpc: decrease memory usage a bit in getblocks.bin (moneromooo-monero)
 2017-08-27 18:13:50 +02:00
Riccardo Spagni
48f96c18df
Merge pull request #2320 
c656dd0e Fix refresh counter display (Howard Chu)
c088d38a Simplify readline support (Howard Chu)
 2017-08-26 23:44:03 +02:00
Riccardo Spagni
36b978f50e
Merge pull request #2314 
c22d22e2 Cleanup test impact of adding safesyncmode() method (Howard Chu)
9a859844 Toggle SAFE syncmode on and off automatically (Howard Chu)
 2017-08-26 23:43:22 +02:00
Riccardo Spagni
ff0afc196e
Merge pull request #2313 
3dd34a49 Cleanup test impact of moving blockchain_db_types() (Howard Chu)
80344740 More DB support cleanup (Howard Chu)
4c7f8ac0 DB cleanup (Howard Chu)
 2017-08-26 23:43:09 +02:00
Riccardo Spagni
30eae5f150
Merge pull request #2353 
19393115 daemon: fix backlog estimating at max block size (moneromooo-monero)
 2017-08-26 23:37:30 +02:00
moneromooo-monero
5807529e69
blockchain: cap memory size of retrieved blocks 
It helps keep memory usage down when a wallet refreshes through
a string of large blocks
 2017-08-26 20:53:58 +01:00
moneromooo-monero
c1b10381fc
rpc: decrease memory usage a bit in getblocks.bin 2017-08-26 20:53:54 +01:00
Guillaume LE VAILLANT
58015df4cf Fix getblocktemplate RPC returning wrong reserved_offset 
The byte for TX_EXTRA_TAG_PUBKEY is already included in
res.reserved_offset by the call to slow_memmem.
 2017-08-26 18:38:27 +02:00
moneromooo-monero
f906d87e66
wallet: new option to check/confirm txpool backlog when sending 2017-08-26 17:16:30 +01:00
moneromooo-monero
19393115dc
daemon: fix backlog estimating at max block size 
Block size will pretty much never be fully used, unless all txes
are using max fee.
 2017-08-26 17:11:40 +01:00
moneromooo-monero
55bec1f03d
rpc: add a new RPC to get current txpool backlog (sizes and fees) 2017-08-26 16:23:31 +01:00
moneromooo
1914c999c7
txpool: update db tx metadata when it changes 2017-08-25 22:21:51 +01:00
moneromooo
4dbf29bd32
txpool: add tx size median to the pool stats 2017-08-25 22:21:38 +01:00
moneromooo-monero
2e338ca574
wallet2: account for huge testnet reorgs for estimating height 2017-08-25 11:03:51 +01:00
Riccardo Spagni
335681896a
Merge pull request #2311 
df0cffed cryptonote_protocol: warn if we see a higher top version we expect (moneromooo-monero)
317ab21a cryptonote_protocol: less strict check on top version on connect (moneromooo-monero)
cc81a371 cryptonote_protocol: update target height when syncing too (moneromooo-monero)
e2ad372b cryptonote_protocol: simplify and remove unnecessary casts (moneromooo-monero)
727e67ca cryptonote_protocol: print peer top height along with its version (moneromooo-monero)
b5345ef4 crypto: use malloc instead of alloca (moneromooo-monero)
80794b31 thread_group: set thread size to THREAD_STACK_SIZE (moneromooo-monero)
5524bc31 print peer id in 0 padded hex for consistency (moneromooo-monero)
8f8cc09b contrib: add sync_info to rlwrap command set (moneromooo-monero)
70b8c6d7 cryptonote_protocol: misc fixes to the new sync algorithm (moneromooo-monero)
 2017-08-25 00:21:28 +02:00
Riccardo Spagni
944bbdb51e
Merge pull request #2330 
ea15e72d tx_pool: fix crash in stats (Howard Chu)
 2017-08-25 00:18:42 +02:00
Riccardo Spagni
9b4117b401
Merge pull request #2328 
679a5ab8 daemon: print estimated tx backlog in print_pool_stats (moneromooo-monero)
 2017-08-25 00:17:32 +02:00
Riccardo Spagni
65ee63e5bf
Merge pull request #2326 
64ab8844 rpc_client: print destination host/port when failing to connect (moneromooo-monero)
333f7012 http_client: add getters for host and port (moneromooo-monero)
 2017-08-25 00:17:02 +02:00
Howard Chu
ea15e72d73
tx_pool: fix crash in stats 
if tx receive_time == now. supersedes #2322
 2017-08-23 14:22:25 +01:00
moneromooo-monero
df0cffede0
cryptonote_protocol: warn if we see a higher top version we expect 2017-08-23 13:38:18 +01:00
moneromooo-monero
317ab21a03
cryptonote_protocol: less strict check on top version on connect 
This allows peers who synced past a fork on the wrong height
to reorg to the right chain after they updated their software
to include the new version.
 2017-08-23 13:38:15 +01:00
moneromooo-monero
cc81a37155
cryptonote_protocol: update target height when syncing too 2017-08-23 13:38:13 +01:00
moneromooo-monero
e2ad372b87
cryptonote_protocol: simplify and remove unnecessary casts 2017-08-23 13:38:10 +01:00
moneromooo-monero
727e67cada
cryptonote_protocol: print peer top height along with its version 2017-08-23 13:38:06 +01:00
moneromooo-monero
b5345ef4f0
crypto: use malloc instead of alloca 2017-08-23 13:38:03 +01:00
moneromooo-monero
80794b3114
thread_group: set thread size to THREAD_STACK_SIZE 2017-08-23 13:38:00 +01:00
moneromooo-monero
5524bc3151
print peer id in 0 padded hex for consistency 2017-08-23 13:37:56 +01:00
moneromooo-monero
e3c4395ab7
p2p: init hashes after deserializing a network address 
Fixes multiple connections to the same address
 2017-08-23 13:32:02 +01:00
moneromooo-monero
679a5ab85b
daemon: print estimated tx backlog in print_pool_stats 2017-08-23 12:12:06 +01:00
Howard Chu
3dd34a49ef
Cleanup test impact of moving blockchain_db_types() 2017-08-22 15:11:28 +01:00
Howard Chu
c22d22e2db
Cleanup test impact of adding safesyncmode() method 2017-08-22 15:11:09 +01:00
moneromooo-monero
64ab88446a
rpc_client: print destination host/port when failing to connect 2017-08-22 12:00:37 +01:00
Howard Chu
c656dd0ede
Fix refresh counter display 
Suspend readline when refreshing
 2017-08-22 08:30:04 +01:00
moneromooo-monero
70b8c6d77a
cryptonote_protocol: misc fixes to the new sync algorithm 
Fix sync wedge corner case:
It could happen if a connection went into standby mode, while
it was the one which had requested the next span, and that span
was still waiting for the data, and that peer is not on the
main chain. Other peers can then start asking for that data
again and again, but never get it as only that forked peer does.

And various other fixes
 2017-08-21 21:57:19 +01:00
Howard Chu
0c6c3eb3f2
Silence stupid fallthru warning in gcc 7 2017-08-21 10:16:10 +01:00
Jaquee
d58700e003 WalletAPI: only allow trusted daemon when importing key images 2017-08-21 08:11:12 +02:00
Jaquee
8a9bbd26d3 WalletAPI: copy wallet data when creating a view only wallet 2017-08-21 08:11:12 +02:00
Jaquee
d27fe32e4a wallet2: export/import wallet data functions 2017-08-21 08:11:12 +02:00
Howard Chu
9a859844f4
Toggle SAFE syncmode on and off automatically 
If monerod is started with default sync mode, set it to SAFE after
synchronization completes. Set it back to FAST if synchronization
restarts (e.g. because another peer has a longer blockchain).

If monerod is started with an explicit sync mode, none of this
automation takes effect.
 2017-08-20 16:30:28 +01:00
Howard Chu
80344740bd
More DB support cleanup 
Hide DB types from db_types.h - no reason to recompile dependencies
when DB types change.

Also remove lingering in-memory DB references, they've been
obsolete since 9e82b694da
 2017-08-20 13:57:36 +01:00
Howard Chu
4c7f8ac04f
DB cleanup 
Hide LMDB-specific stuff behind blockchain_db.h. Nobody besides blockchain_db.cpp
should ever be including DB-specific headers any more.
 2017-08-19 18:11:38 +01:00
Jaquee
225a25f327 import_key_images - allow importing without being connected to daemon 2017-08-18 16:11:30 +02:00
Matthew Campassi
ea996f91b5 clarification of parameters for print_coinbase_tx_sum 2017-08-18 08:54:32 -05:00
moneromooo-monero
5d989b661a
core: add mainnet v6 fork height at 1400000 2017-08-18 10:03:49 +01:00
Riccardo Spagni
4466b6d1b0
Merge pull request #2303 
5a283078 cryptonote_protocol: large block sync size before v4 (moneromooo-monero)
7b747607 cryptonote_protocol: kick idle synchronizing peers (moneromooo-monero)
 2017-08-17 21:39:44 +02:00
Riccardo Spagni
4859a00134
Merge pull request #2300 
42b34b35 Consistently print peer id in hex and on 16 chars (moneromooo-monero)
 2017-08-17 21:36:15 +02:00
Riccardo Spagni
1d32a5a445
Merge pull request #2291 
b59cd074 befor -> before (Nano Akron)
 2017-08-17 21:35:48 +02:00
Riccardo Spagni
4b2cc123ff
Merge pull request #2287 
827afcb7 protocol: pass blockchain cumulative difficulty when syncing (moneromooo-monero)
 2017-08-17 21:35:02 +02:00
moneromooo-monero
5a283078ec
cryptonote_protocol: large block sync size before v4 2017-08-17 13:11:52 +01:00
moneromooo-monero
7b74760756
cryptonote_protocol: kick idle synchronizing peers 
In case they dropped off downloading for any reason, they'll get
sent to download again.
 2017-08-16 22:24:50 +01:00
moneromooo-monero
ef005f5e72
p2p: add a couple early outs when the stop signal is received 
This avoids quicker exit
 2017-08-16 15:44:52 +01:00
moneromooo-monero
42b34b3545
Consistently print peer id in hex and on 16 chars 2017-08-16 10:56:55 +01:00
Nano Akron
b59cd0745b befor -> before 
Really unique yet consistent spelling mistake
 2017-08-15 23:23:26 +01:00
moneromooo-monero
827afcb7ea
protocol: pass blockchain cumulative difficulty when syncing 
Not used yet.
 2017-08-15 21:03:37 +01:00
Riccardo Spagni
78ecb2ad0b
update major version number 2017-08-15 21:04:37 +02:00
Riccardo Spagni
3ff67323b7
Merge pull request #2288 
c6e200a8 core: add --db-salvage command line flag (moneromooo-monero)
 2017-08-15 20:57:26 +02:00
Riccardo Spagni
061930d6b4
Merge pull request #2293 
dee41efa simplewallet: mnemonic language command-line arg (Eugene Otto)
 2017-08-15 20:57:09 +02:00
Riccardo Spagni
124cbe3cf3
Merge pull request #2292 
cb2d5ac7 mnemonics: new Esperanto word list (moneromooo-monero)
 2017-08-15 20:56:49 +02:00
Riccardo Spagni
9e6bcbc014
Merge pull request #2286 
8655ba04 wallet_rpc_server: adjust small ring sizes to 5 for v6 (moneromooo-monero)
 2017-08-15 20:55:30 +02:00
Riccardo Spagni
7b14a96c03
Merge pull request #2283 
d1f204d6 miner: set thread name before logging (moneromooo-monero)
 2017-08-15 20:54:53 +02:00
Riccardo Spagni
4bfb58328d
Merge pull request #2282 
7fdc178a p2p: fix random peer index being too large (moneromooo-monero)
 2017-08-15 20:54:38 +02:00
Riccardo Spagni
e457cc7891
Merge pull request #2281 
e499ff33 simplewallet: factor out message_writer (moneromooo-monero)
7ed5ab47 scoped_message_writer: pause readline to match simplewallet (moneromooo-monero)
 2017-08-15 20:54:21 +02:00
Riccardo Spagni
a861cbb465
Merge pull request #2279 
359517c7 wallet_rpc_server: fix possible privacy leak in on_import_key_images() (Jaquee)
20495b27 simplewallet: fix possible privacy leak in import_key_images() (Jaquee)
 2017-08-15 20:53:58 +02:00
Riccardo Spagni
53dde37ceb
Merge pull request #2276 
a1891ebe tests: fix tests build (moneromooo-monero)
 2017-08-15 20:53:41 +02:00
Riccardo Spagni
f980b2ca89
Merge pull request #2277 
6ce769c1 p2p: get net log spam down a bit (moneromooo-monero)
 2017-08-15 20:53:27 +02:00
Riccardo Spagni
86cf8cac86
Merge pull request #2275 
88e83f94 cryptonote_protocol_handler: log versions as unsigned ints (moneromooo-monero)
 2017-08-15 20:53:08 +02:00
Riccardo Spagni
74522c7e84
Merge pull request #2236 
cb2d5110 Tweak net logs so we get more info on why networking can't start (moneromooo-monero)
 2017-08-15 20:52:44 +02:00
Riccardo Spagni
fa73d6cbf1
Merge pull request #2274 
7591c528 p2p: fallback on seed nodes if we can't make a connection (moneromooo-monero)
 2017-08-15 20:52:04 +02:00
Riccardo Spagni
1d093eff67
Merge pull request #2273 
0e8d60c0 cryptonote_protocol: fix recv/send idle time before handshake (moneromooo-monero)
 2017-08-15 20:51:50 +02:00
Riccardo Spagni
e0df740bc9
Merge pull request #2272 
f90bbe2a cryptonote_protocol: keep target in sync with dropped connections (moneromooo-monero)
 2017-08-15 20:51:35 +02:00
Riccardo Spagni
b6fc7f283f
Merge pull request #2270 
1307e3cc WalletAPI: add getDefaultDataDir() (Jaquee)
 2017-08-15 20:51:11 +02:00
Riccardo Spagni
1b54bcdc08
Merge pull request #2266 
7007bd14 Change default block sync size from 200 to 20 (moneromooo-monero)
 2017-08-15 20:50:44 +02:00
Riccardo Spagni
973cc7ffdf
Merge pull request #2264 
980e476c cryptonote_basic: fix silly CLANG warning about not emitting function (moneromooo-monero)
 2017-08-15 20:50:27 +02:00
Riccardo Spagni
9721b37bd5
Merge pull request #2258 
74597bd1 wallet2: improve refresh height determination (moneromooo-monero)
 2017-08-15 20:49:56 +02:00
Riccardo Spagni
718941bee0
Merge pull request #2256 
042b86c4 simplewallet: do not ask wallet filename twice when restoring (moneromooo-monero)
 2017-08-15 20:49:26 +02:00
moneromooo-monero
cb2d5110ff
Tweak net logs so we get more info on why networking can't start 
This should prevent "silent" failures to start
 2017-08-15 19:49:25 +01:00
Riccardo Spagni
85211cda22
Merge pull request #2255 
8bbed275 simplewallet: Be explicit about secret keys (Erik de Castro Lopo)
 2017-08-15 20:49:10 +02:00
Riccardo Spagni
085ef96768
Merge pull request #2252 
9707998a wallet2: clear some missing containers in clear() (moneromooo-monero)
 2017-08-15 20:48:31 +02:00
Riccardo Spagni
79479a3614
Merge pull request #2250 
f4f7eeba blockchain: log more info when we reject an orphan (moneromooo-monero)
 2017-08-15 20:48:08 +02:00
Riccardo Spagni
5ee3798da3
Merge pull request #2248 
71e28760 debug_utilities: only build for debug builds (moneromooo-monero)
55e150ff debug_utilities: new object-sizes debug tool (moneromooo-monero)
fbaf5375 cn_deserialize: move to new debug_utilities subdirectory (moneromooo-monero)
 2017-08-15 20:47:49 +02:00
Riccardo Spagni
12c70fedc0
Merge pull request #2246 
d732c73e blockchain: remove a few unused variables (moneromooo-monero)
 2017-08-15 20:47:32 +02:00
Riccardo Spagni
e5a1628c88
Merge pull request #2245 
c8640a3d difficulty: fix misleading comment (Guillaume LE VAILLANT)
 2017-08-15 20:46:48 +02:00
Riccardo Spagni
6f60613ffb
Merge pull request #2240 
b7d6ec83 simplewallet: add (out of sync) or (no daemon) markers in the prompt (moneromooo-monero)
fa23a500 wallet2: add a is_synced function (moneromooo-monero)
f1307bbd node_rpc_proxy: add a proxy for target height (moneromooo-monero)
 2017-08-15 20:46:31 +02:00
Riccardo Spagni
4c24eb050b
Merge pull request #2238 
ad4649ac Enable verifying wallet password with having to load wallet. (m2049r)
 2017-08-15 20:46:09 +02:00
Riccardo Spagni
1cf4665d2a
Merge pull request #2237 
5d4ef719 core: speed up output index unique set calculation (moneromooo-monero)
19d7f568 perf_timer: allow profiling more granular than millisecond (moneromooo-monero)
bda8c598 epee: add nanosecond timer and pause/restart profiling macros (moneromooo-monero)
 2017-08-15 20:45:47 +02:00
Riccardo Spagni
d64b9c1c9e
Merge pull request #2233 
67ce4910 wallet2: store testnet bool in keys file (Jaquee)
 2017-08-15 20:45:19 +02:00
Riccardo Spagni
da2c662cf2
Merge pull request #2232 
87b5ede9 miner: fix ignoring battery from command line (moneromooo-monero)
 2017-08-15 20:45:02 +02:00
Riccardo Spagni
68ccc10b29
Merge pull request #2205 
c97d1bd3 wallet: return unlock_time in get_transfers (moneromooo-monero)
 2017-08-15 20:44:44 +02:00
moneromooo-monero
35e01a6e50
cryptonote_protocol: fix "holes" in block download schedule 2017-08-15 17:49:06 +01:00
moneromooo-monero
3da1edfde5
cryptonote_protocol: fix out of order addition 
This was broken by the reorg fix, since we now have to add blocks
regardless of their starting height. We now check whether we know
the parent for the first block in the next span, or whether it was
requested. If neither, it's an orphan. If it is not known, but was
requested, we wait to get that block.
 2017-08-15 16:54:08 +01:00
moneromooo-monero
6edb1b3e46
block_queue: do not add empty spans 2017-08-15 11:38:59 +01:00
moneromooo-monero
cb2d5ac788
mnemonics: new Esperanto word list 
Word list authored by: Engelberg, ProkhorZ
Sources:
  Baza Radikaro Oficiala
  Reta Vortaro (http://www.reta-vortaro.de/revo/)
  Esperanto Panorama - Esperanto-English Dictionary (http://www.esperanto-panorama.net/vortaro/eoen.htm)
  ESPDIC - Paul Denisowski (http://www.denisowski.org/Esperanto/ESPDIC/espdic.txt)
 2017-08-14 17:46:46 +01:00
Eugene Otto
dee41efa20 simplewallet: mnemonic language command-line arg 
Add `--mnemonic-language` command-line arg so it's possible to generate a wallet
without interacting with the CLI.
 2017-08-13 20:00:25 -07:00
moneromooo-monero
2ec15a6931
daemon: print peers' top height in sync_info 2017-08-12 20:36:31 +01:00
moneromooo-monero
c6e200a8ab
core: add --db-salvage command line flag 
Use to load the database when the primary meta page is corrupted
 2017-08-12 19:04:44 +01:00
moneromooo-monero
8655ba04ba
wallet_rpc_server: adjust small ring sizes to 5 for v6 2017-08-12 12:59:06 +01:00
moneromooo-monero
88e83f9427
cryptonote_protocol_handler: log versions as unsigned ints 
They're interpreted as characters otherwise
 2017-08-12 11:57:05 +01:00
moneromooo-monero
08abb670e1
protocol: fix reorgs while syncing 2017-08-12 11:22:42 +01:00
moneromooo-monero
d1f204d640
miner: set thread name before logging 2017-08-12 09:07:40 +01:00
moneromooo-monero
7fdc178abb
p2p: fix random peer index being too large 2017-08-11 14:29:55 +01:00
moneromooo-monero
e499ff3322
simplewallet: factor out message_writer 2017-08-11 13:38:42 +01:00
moneromooo-monero
7ed5ab47ea
scoped_message_writer: pause readline to match simplewallet 2017-08-11 13:38:18 +01:00
Jaquee
359517c7f5 wallet_rpc_server: fix possible privacy leak in on_import_key_images() 2017-08-11 11:18:21 +02:00
Jaquee
20495b27e8 simplewallet: fix possible privacy leak in import_key_images() 2017-08-11 11:16:30 +02:00
moneromooo-monero
6ce769c123
p2p: get net log spam down a bit 2017-08-10 14:30:42 +01:00
moneromooo-monero
a1891ebea9
tests: fix tests build 
Add get_fork_version and add_ideal_fork_version to core so
cryptonote_protocol does not have to need the Blockchain
class directly, as it's not in its dependencies, and add
those to the fake core classes in tests too.
 2017-08-10 11:12:56 +01:00
moneromooo-monero
7591c528d0
p2p: fallback on seed nodes if we can't make a connection 
This avoids failing to connect to the network in case all
known peers are unavailable (which can happen if the peer
list is small).
 2017-08-09 22:55:25 +01:00
moneromooo-monero
0e8d60c06c
cryptonote_protocol: fix recv/send idle time before handshake 2017-08-09 21:22:05 +01:00
moneromooo-monero
f90bbe2a5c
cryptonote_protocol: keep target in sync with dropped connections 
When a node is dropped, we stop considering its claimed blockchain
height as a factor in the target height calculation. This prevents
a runaway chain from being still thought to be the target even if
the nodes carrying it are dropped.
 2017-08-09 20:49:24 +01:00
moneromooo-monero
3ff5ce63c5
connection_context: initialize state 
Why this was initialized properly before I have no idea, but
it is not anymore. Fix it, which fixes syncing in release mode.
 2017-08-09 19:01:27 +01:00
Riccardo Spagni
f43d59d8b3
Merge pull request #2269 
635929ea protocol: add checks for top block hard fork version (moneromooo-monero)
7482253a epee: fixup KV_SERIALIZE_OPT to work in more cases (moneromooo-monero)
 2017-08-09 14:58:11 +02:00
Jaquee
1307e3cc12 WalletAPI: add getDefaultDataDir() 2017-08-09 12:38:29 +02:00
moneromooo-monero
635929eaca
protocol: add checks for top block hard fork version 
We won't even talk to a peer which claims a wrong version
for its top block. This will avoid syncing to known bad
peers in the first place.
Also add IP fails when failing to verify a block.
 2017-08-09 10:28:41 +01:00
moneromooo-monero
e49f6d439d
net_node: fix m_in_timedsync initialization 
This fixes nodes not being able to connect to nodes which use
recent code. While there, init peer_id too.
 2017-08-08 17:23:02 +01:00
moneromooo-monero
7007bd1489
Change default block sync size from 200 to 20 
With the new sync algorithm, the network overhead will be masked
as the thread adding blocks isn't interrupted by network calls
anymore. This should reduce memory usage a lot during sync.
 2017-08-08 11:05:11 +01:00
moneromooo-monero
980e476c89
cryptonote_basic: fix silly CLANG warning about not emitting function 2017-08-08 00:33:52 +01:00
Riccardo Spagni
bfd2532ea5
Merge pull request #2247 
a839a6fa Wallet API: add tx unlock time (Jaquee)
 2017-08-07 23:34:06 +02:00
Riccardo Spagni
bff9fb9c8b
Merge pull request #2231 
61770ec2 change mixin to ring size in user visible places (moneromooo-monero)
 2017-08-07 22:53:15 +02:00
moneromooo-monero
61770ec2da
change mixin to ring size in user visible places 2017-08-07 21:12:27 +01:00
Riccardo Spagni
14f479bb9c
Merge pull request #2262 
7f7d42f8 core: fix invalid memory access creating tx (moneromooo-monero)
 2017-08-07 22:11:45 +02:00
Riccardo Spagni
62610a3a53
Merge pull request #2225 
5d91b26c blockchain: skip checking tx semantics in embedded block hash range (moneromooo-monero)
 2017-08-07 22:10:09 +02:00
moneromooo-monero
7f7d42f890
core: fix invalid memory access creating tx 2017-08-07 21:09:19 +01:00
Riccardo Spagni
a796cb341e
Merge pull request #2207 
c93b7692 blockchain_import: much faster when verifying with cryptonote::core (moneromooo-monero)
38756d00 core: new API to disable DNS checkpoint lookups (moneromooo-monero)
 2017-08-07 21:40:32 +02:00
Riccardo Spagni
3db039828e
Merge pull request #2254 
e31aac80 walletAPI: add getRefreshFromBlockHeight() (Jaquee)
48c0cb1b wallet api: pause refresh while commiting tx (Jaquee)
f233c01c CMakeLists.txt - ios/xcode fix (Jaquee)
 2017-08-07 16:01:40 +02:00
moneromooo-monero
569b9b2b50
updates: add "misc_log_ex.h" for logs 2017-08-07 14:42:08 +01:00
moneromooo-monero
74628941d5
dns_utils: add <functional> for std::function 2017-08-07 14:35:41 +01:00
moneromooo-monero
c93b7692b4
blockchain_import: much faster when verifying with cryptonote::core 
Quick test with the first 56569 blocks from mainnet

version verify  batch   time
old     0       200     1:16
new     0       200     0:57
old     0       5000    0:53
new     0       5000    0:51
old     1       200     est > 1h
new     1       200     10:21
old     1       5000    est > 1h
new     1       5000    8:27
 2017-08-07 14:32:49 +01:00
moneromooo-monero
38756d00ff
core: new API to disable DNS checkpoint lookups 2017-08-07 14:31:06 +01:00
Riccardo Spagni
c63e9633b5
Merge pull request #2218 
02f13d6c Fix handling of strings & simplify summation of spendkeys (JollyMort)
40fc9d7b Add option to join multisig wallet pieces together (JollyMort)
 2017-08-07 15:28:17 +02:00
Riccardo Spagni
6db8a60a18
Merge pull request #2149 
158c3ecf core: thread most of handle_incoming_tx (moneromooo-monero)
f57ee382 cryptonote_protocol: retry stale spans early (moneromooo-monero)
90df52e1 cryptonote_protocol: light cleanup (moneromooo-monero)
84e23156 cryptonote_protocol: avoid spurious SYNCHRONIZED OK messages (moneromooo-monero)
5be43fcd cryptonote_protocol_handler: sync speedup (moneromooo-monero)
 2017-08-07 15:24:58 +02:00
Riccardo Spagni
05c44db23b
Merge pull request #2244 
328bebbe daemon: some more include cleanup (moneromooo-monero)
 2017-08-07 15:14:12 +02:00
Riccardo Spagni
dc2747439c
Merge pull request #2243 
4d873046 blockchain: add testnet v6 fork height at 971400 (moneromooo-monero)
 2017-08-07 15:13:59 +02:00
Riccardo Spagni
b1af32b48d
Merge pull request #2242 
1c9196b0 cryptonote_protocol: fix days behind calc on testnet (moneromooo-monero)
 2017-08-07 15:13:45 +02:00
Riccardo Spagni
15e895399c
Merge pull request #2239 
600353e2 fix wallet callback signatures (m2049r)
 2017-08-07 15:13:30 +02:00
Riccardo Spagni
ea46a5527a
Merge pull request #2234 
214fd81e some include cleanup (moneromooo-monero)
 2017-08-07 15:13:07 +02:00
Riccardo Spagni
9b3b7f050b
Merge pull request #2230 
5dd722be core: add a message when loading checkpoints at init time (moneromooo-monero)
 2017-08-07 15:12:42 +02:00
Riccardo Spagni
5cc53c7e49
Merge pull request #2226 
14ec6ed8 tx_pool: remove obsolete unused m_config_folder field (moneromooo-monero)
 2017-08-07 15:12:29 +02:00
Riccardo Spagni
1ea75abd72
Merge pull request #2223 
d37e8f88 daemon: add average seconds per block in bc_dyn_stats (moneromooo-monero)
 2017-08-07 15:12:15 +02:00
Riccardo Spagni
a2dd125b1e
Merge pull request #2222 
878205f1 core: fix lock ordering bug at init time (moneromooo-monero)
 2017-08-07 15:11:51 +02:00
Riccardo Spagni
9b0daf49db
Merge pull request #2220 
c6ba7d11 p2p: move m_in_timedsync from connection_context to p2p_connection_context (moneromooo-monero)
 2017-08-07 15:11:37 +02:00
Riccardo Spagni
43c6e452fa
Merge pull request #2219 
04ebfbfe p2p: close connections when exiting (moneromooo-monero)
9a10148c p2p: fix thread leak (moneromooo-monero)
 2017-08-07 15:11:20 +02:00
Riccardo Spagni
8048de268a
Merge pull request #2216 
d8becf2e blockchain: fix cryptonight buffer leak on exit (moneromooo-monero)
91aa90fc blockchain: ensure all blocks get their longhash precalculated (moneromooo-monero)
ff4bcaed blockchain: pass correct height to get_block_longhash (moneromooo-monero)
 2017-08-07 15:11:04 +02:00
Riccardo Spagni
a6ea26e7fa
Merge pull request #2215 
06aea2cf move get_proof_of_trust_hash from util.h to p2p_protocol_defs.h (moneromooo-monero)
 2017-08-07 15:10:42 +02:00
Riccardo Spagni
a963da9001
Merge pull request #2214 
41f935dd network_throttle: remove unneeded heap allocations (moneromooo-monero)
 2017-08-07 15:10:27 +02:00
Riccardo Spagni
1e2d6f898e
Merge pull request #2211 
525975ac wallet-cli: Minor improvement to help output (Erik de Castro Lopo)
 2017-08-07 15:10:13 +02:00
Riccardo Spagni
f5be5b7e7b
Merge pull request #2210 
cb0b5594 Move OpenAlias console input back from libs (moneromooo-monero)
 2017-08-07 15:09:45 +02:00
Riccardo Spagni
61ac6983f2
Merge pull request #2206 
340feede core: randomly shuffle outputs (moneromooo-monero)
 2017-08-07 15:09:31 +02:00
Riccardo Spagni
24dd5e87af
Merge pull request #2203 
0c57df97 wallet2: fix temporarily missing incoming tx when being mined (moneromooo-monero)
 2017-08-07 15:09:17 +02:00
Riccardo Spagni
5a04301b32
Merge pull request #2201 
dc0b312f wallet_rpc_server: optionally return tx blobs on transfer calls (moneromooo-monero)
5eb79983 epee: add a KV_SERIALIZE variant for optional parameters (moneromooo-monero)
 2017-08-07 15:09:03 +02:00
Riccardo Spagni
58621e3f65
Merge pull request #2200 
f1b76c84 cryptonote_protocol: Set send_idle_time in connection_info correctly (rbrunner7)
 2017-08-07 15:08:49 +02:00
Riccardo Spagni
0f36efbded
Merge pull request #2198 
53af9768 blockchain: one off warning when seeing a block with unknown version (moneromooo-monero)
 2017-08-07 15:08:31 +02:00
Riccardo Spagni
52b33b5284
Merge pull request #2196 
16a55347 simplewallet: show payment ids on sign_transfer (moneromooo-monero)
 2017-08-07 15:08:00 +02:00
Riccardo Spagni
b6ae718456
Merge pull request #2195 
599436a4 mlog: default to msgwriter logs only for log level 1 (moneromooo-monero)
58f3fc68 Make msgwriter logs go to file only (moneromooo-monero)
 2017-08-07 15:07:46 +02:00
Riccardo Spagni
8494ffbc37
Merge pull request #2191 
23909bb0 Make successful transfer log message more informative (JollyMort)
 2017-08-07 15:07:33 +02:00
Riccardo Spagni
cf308cfb20
Merge pull request #2188 
a5031a7d core: forbid duplicate ring members from v6 (moneromooo-monero)
 2017-08-07 15:07:16 +02:00
Riccardo Spagni
64ebeb5aa5
Merge pull request #2182 
2fac03e6 Update monerod systemd service file (Erik de Castro Lopo)
51efb217 daemon: Add ability to write a PID file (Erik de Castro Lopo)
 2017-08-07 15:06:59 +02:00
Riccardo Spagni
04591af7fd Merge pull request #2153 
35d68b2c Fix spelling errors (Erik de Castro Lopo)
 2017-08-07 14:49:15 +02:00
Riccardo Spagni
f6ee93e214
Merge pull request #2148 
125f823b Add on_get_alt_blocks_hashes RPC call (moneroexamples)
 2017-08-07 14:48:38 +02:00
Riccardo Spagni
ce52d94cb7
Merge pull request #2147 
94717021 fix on_battery_power for linux (Ryan Mehta)
 2017-08-07 14:47:43 +02:00
Riccardo Spagni
159a6e9669
Merge pull request #2132 
464afd4d Ensure DNSResolver destructor runs on exit (Howard Chu)
 2017-08-07 14:46:26 +02:00
moneromooo-monero
4d87304683
blockchain: add testnet v6 fork height at 971400 2017-08-07 11:34:59 +01:00
moneromooo-monero
158c3ecff3
core: thread most of handle_incoming_tx 2017-08-07 09:33:20 +01:00
moneromooo-monero
f57ee382b8
cryptonote_protocol: retry stale spans early 
Connections can be dropped by the net_node layer,
unbeknownst to cryptonote_protocol, which would then
not flush any spans scheduled to that connection,
which would cause it to be only downloaded again
once it becomes the next span (possibly after a small
delay if it had been requested less than 5 seconds
ago).
 2017-08-07 09:33:17 +01:00
moneromooo-monero
90df52e12f
cryptonote_protocol: light cleanup 2017-08-07 09:33:14 +01:00
moneromooo-monero
84e23156ac
cryptonote_protocol: avoid spurious SYNCHRONIZED OK messages 2017-08-07 09:33:09 +01:00
moneromooo-monero
5be43fcdba
cryptonote_protocol_handler: sync speedup 
A block queue is now placed between block download and
block processing. Blocks are now requested only from one
peer (unless starved).

Includes a new sync_info coommand.
 2017-08-07 09:33:04 +01:00
moneromooo-monero
74597bd15a
wallet2: improve refresh height determination 
As reported by jaquee, the calculation could underflow for very
low heights.
Additionally, we now use the target height too.
 2017-08-06 16:56:51 +01:00
moneromooo-monero
042b86c473
simplewallet: do not ask wallet filename twice when restoring 
It's annoying and pointless (especially as it's the only thing
where the user is asked twice)
 2017-08-06 12:28:00 +01:00
Erik de Castro Lopo
8bbed27573 simplewallet: Be explicit about secret keys 
Previously, the wallet just asked for "Spend key" and "View key" but
now it specifies that these should be the secret versions of these
keys.
 2017-08-06 08:37:18 +10:00
Jaquee
e31aac80e5 walletAPI: add getRefreshFromBlockHeight() 2017-08-05 19:23:55 +02:00
Jaquee
48c0cb1ba6 wallet api: pause refresh while commiting tx 2017-08-05 19:21:23 +02:00
moneromooo-monero
9707998a08
wallet2: clear some missing containers in clear() 2017-08-05 18:09:31 +01:00
Jaquee
67ce4910bc wallet2: store testnet bool in keys file 2017-08-05 17:23:47 +02:00
moneromooo-monero
0c57df9770
wallet2: fix temporarily missing incoming tx when being mined 
When scanning the txpool without having first updated the
blockchain, the tx would be seen as neither in the txpool
nor the chain, and removed, so it'd only reappear once the
chain is refreshed, and the tx seen in a block.
 2017-08-05 12:36:03 +01:00
moneromooo-monero
f4f7eeba80
blockchain: log more info when we reject an orphan 
We want to know what happened when a block is wrongly rejected
 2017-08-04 23:26:55 +01:00
moneromooo-monero
16a5534704
simplewallet: show payment ids on sign_transfer 
Integrated addresses are shown when an encrypted payment id is used
 2017-08-04 19:36:02 +01:00
moneromooo-monero
71e2876033
debug_utilities: only build for debug builds 2017-08-04 14:45:43 +01:00
moneromooo-monero
55e150ff8a
debug_utilities: new object-sizes debug tool 
It prints the size of various interesting types, to make it
easier to match leaks to possible leaked object types
 2017-08-04 14:45:38 +01:00
Jaquee
a839a6fa8a Wallet API: add tx unlock time 2017-08-03 21:37:45 +02:00
moneromooo-monero
fbaf5375c3
cn_deserialize: move to new debug_utilities subdirectory 2017-08-03 16:20:40 +01:00
moneromooo-monero
d732c73e71
blockchain: remove a few unused variables 2017-08-03 11:26:55 +01:00
m2049r
ad4649ac81 Enable verifying wallet password with having to load wallet. 2017-08-03 01:45:45 +02:00
Guillaume LE VAILLANT
c8640a3d74 difficulty: fix misleading comment 2017-08-02 23:59:48 +02:00
moneromooo-monero
328bebbe4b
daemon: some more include cleanup 2017-08-02 22:43:38 +01:00
moneromooo-monero
1c9196b0c5
cryptonote_protocol: fix days behind calc on testnet 2017-08-02 22:34:02 +01:00
moneromooo-monero
b7d6ec8364
simplewallet: add (out of sync) or (no daemon) markers in the prompt 
Should help people who don't realize why they haven't seen their
monero yet.
 2017-08-02 14:44:42 +01:00
moneromooo-monero
fa23a5006d
wallet2: add a is_synced function 2017-08-02 14:44:19 +01:00
moneromooo-monero
f1307bbd7b
node_rpc_proxy: add a proxy for target height 2017-08-02 14:43:47 +01:00
moneromooo-monero
c97d1bd3d4
wallet: return unlock_time in get_transfers 
also show it in simplewallet's show_transfer
 2017-08-02 10:15:27 +01:00
m2049r
600353e2b2 fix wallet callback signatures 2017-08-02 01:23:53 +02:00
moneromooo-monero
41f935ddb2
network_throttle: remove unneeded heap allocations 
This will keep leak traces less noisy, as those were one off
allocations that were technically leaking.
 2017-08-01 18:47:05 +01:00
moneromooo-monero
c6ba7d110f
p2p: move m_in_timedsync from connection_context to p2p_connection_context 
It's got no place in the base class as it's P2P specific field
 2017-08-01 18:41:57 +01:00
moneromooo-monero
5d4ef719b9
core: speed up output index unique set calculation 
A sort+uniq step was done for every tx in a 200 block chunk,
causing a lot of repeated scanning as the size of the offset
map got larger with every added tx. We now do the step only
once at the end of the loop.
Doing it this way potentially uses more memory, but testing
shows that it's currently only about 2% more.
 2017-08-01 14:06:12 +01:00
moneromooo-monero
19d7f568ce
perf_timer: allow profiling more granular than millisecond 2017-08-01 14:05:20 +01:00
moneromooo-monero
214fd81e93
some include cleanup 2017-07-31 16:36:52 +01:00
moneromooo-monero
87b5ede908
miner: fix ignoring battery from command line 2017-07-31 08:36:57 +01:00
moneromooo-monero
5dd722beaa
core: add a message when loading checkpoints at init time 
This uses DNS, which can take a while, so it's useful to know
this is the culprit when loading pauses
 2017-07-31 06:43:13 +01:00
moneromooo-monero
14ec6ed80d
tx_pool: remove obsolete unused m_config_folder field 2017-07-30 12:03:43 +01:00
moneromooo-monero
5d91b26c0f
blockchain: skip checking tx semantics in embedded block hash range 
If the txes are bad, this'll be picked up by the block hash mismatch
since the tx merkle root is part of the block hash.
 2017-07-30 09:48:00 +01:00
moneromooo-monero
d37e8f8868
daemon: add average seconds per block in bc_dyn_stats 2017-07-29 18:43:50 +01:00
moneromooo-monero
878205f143
core: fix lock ordering bug at init time 2017-07-29 12:54:02 +01:00
JollyMort
02f13d6cdf
Fix handling of strings & simplify summation of spendkeys 2017-07-29 13:49:12 +02:00
moneromooo-monero
04ebfbfefa
p2p: close connections when exiting 
This ensures they don't leak if they were in the middle of an
async operation.
 2017-07-29 10:04:36 +01:00
JollyMort
40fc9d7b68
Add option to join multisig wallet pieces together 
Asks user for all the data required to merge secret keys from multisig wallets into one master wallet, which then gets full control of the multisig wallet. The resulting wallet will be the same as any other regular wallet.
 2017-07-29 02:36:21 +02:00
moneromooo-monero
9a10148c01
p2p: fix thread leak 2017-07-28 22:23:05 +01:00
moneromooo-monero
d8becf2ee1
blockchain: fix cryptonight buffer leak on exit 2017-07-28 10:19:17 +01:00
moneromooo-monero
91aa90fc79
blockchain: ensure all blocks get their longhash precalculated 
If the number of blocks to check was not a multiple of the
number of preparation threads, the last few blocks would
not be included in the threaded long hash calculation.
Those would still get calculated when the block gets added
to the chain, however, so this was only a tiny performance
hit, rather than a security bug.
 2017-07-27 18:18:49 +01:00
moneromooo-monero
ff4bcaed81
blockchain: pass correct height to get_block_longhash 2017-07-27 18:18:20 +01:00
moneromooo-monero
06aea2cf0a
move get_proof_of_trust_hash from util.h to p2p_protocol_defs.h 
This avoids having to include p2p_protocol_defs.h in util.h,
as util.h is used a lot, and p2p_protocol_defs.h includes
a lot of other things that most users don't need.
 2017-07-27 15:46:47 +01:00
Erik de Castro Lopo
525975acc4 wallet-cli: Minor improvement to help output 2017-07-27 20:36:28 +10:00
moneromooo-monero
cb0b559451
Move OpenAlias console input back from libs 
Library code should definitely not ask for console input unless
it's clearly an input function. Delegating the user interaction
part to the caller means it can now be used by a GUI, or have a
decision algorithm better adapted to a particular caller.
 2017-07-27 11:30:13 +01:00
moneromooo-monero
dc0b312f8a
wallet_rpc_server: optionally return tx blobs on transfer calls 
also add do_not_relay flag to them, so it now becomes possible
to create a tx without sending it yet
 2017-07-26 10:33:04 +01:00
moneromooo-monero
340feedee2
core: randomly shuffle outputs 
They used to be sorted by amount, which was fine before rct,
but is now suboptimal, since amounts are not known anymore.
In particular, it would give a recipient knowledge of whether
change was higher or lower than the amount received.
 2017-07-25 18:57:57 +01:00
rbrunner7
f1b76c8424 cryptonote_protocol: Set send_idle_time in connection_info correctly 2017-07-24 18:58:39 +02:00
moneromooo-monero
53af9768ce
blockchain: one off warning when seeing a block with unknown version 2017-07-24 15:25:46 +01:00
moneromooo-monero
58f3fc68e4
Make msgwriter logs go to file only 
This was the case for monero-wallet-cli already, but not for
monerod, which was making it pretty spammy as it was duplicating
intended output. Since my original intent was to ensure logs
included command output for debugging, this achieves both.
 2017-07-24 10:34:47 +01:00
JollyMort
23909bb04d
Make successful transfer log message more informative 
"Payment successfully sent" can be misleading if the TX isn't confirmed and drops from TX-pool.
 2017-07-22 23:35:53 +02:00
moneromooo-monero
a5031a7d02
core: forbid duplicate ring members from v6 
This avoids someone adding what amounts to mixin 0 rings in
practice, as there is no other good reason to allow this.
 2017-07-22 12:33:12 +01:00
Erik de Castro Lopo
51efb21713 daemon: Add ability to write a PID file 
The PID file will only be written if the daemon is called with the
`--detach` command line argument and a `--pidfile /some/file/path`
argument.
 2017-07-22 08:34:56 +10:00
Riccardo Spagni
ab594cfee9
Merge pull request #2159 
6955976b Add various readline related fixes (Jethro Grassie)
 2017-07-19 11:52:27 +02:00
Riccardo Spagni
c0f155d3a0
Merge pull request #2170 
c3bb6bec daemon: fix status in command line mode if using restricted rpc (moneromooo-monero)
 2017-07-19 11:51:35 +02:00
Riccardo Spagni
630cc0f9ca
Merge pull request #2169 
f5f985c0 miner: fix background mining options parsing (moneromooo-monero)
 2017-07-19 11:51:09 +02:00
Riccardo Spagni
fed3430b70
Merge pull request #2166 
33d17c37 Don't hardcode /tmp (Howard Chu)
 2017-07-19 11:50:38 +02:00
Riccardo Spagni
921ebdce45
Merge pull request #2165 
8db68a57 Fix #2164 histogram output (Howard Chu)
 2017-07-19 11:50:14 +02:00
Riccardo Spagni
42fc89b672
Merge pull request #2142 
02d66db4 tx_pool: initialize padding in txpool meta structure (moneromooo-monero)
0722aea3 cryptonote_core: initialize checkpoint flag (moneromooo-monero)
 2017-07-19 11:49:42 +02:00
Riccardo Spagni
999d4d83e9
Merge pull request #2135 
5cea3552 simplewallet: lock idle scope when sweeping (moneromooo-monero)
 2017-07-19 11:49:09 +02:00
moneromooo-monero
c3bb6becd9
daemon: fix status in command line mode if using restricted rpc 2017-07-13 10:17:57 +01:00
moneromooo-monero
f5f985c018
miner: fix background mining options parsing 
They were set as uint8_t, which boost was apparently treating
as a character type, rather than a numeric type
 2017-07-12 11:22:50 +01:00
Howard Chu
33d17c37e8
Don't hardcode /tmp 2017-07-11 12:38:51 +01:00
Howard Chu
8db68a57f5
Fix #2164 histogram output 
When there are more than 50txs, the timestamp for the last
bin was printed incorrectly. Subtracting "now" was omitted by mistake
in 3fc22e7b78
 2017-07-10 15:51:03 +01:00
Jethro Grassie
6955976b2d
Add various readline related fixes 
- Add missing unbind key
- Fix colored messages
- Add command completion
- Preserve last command input
- Fix cursor position issues
- Fix trailing whitespace in commands
- Synchronize set_prompt
 2017-07-09 09:50:04 -04:00
Ryan Mehta
94717021ef fix on_battery_power for linux 
fix ac/battery linux
 2017-07-06 10:03:55 -07:00
Erik de Castro Lopo
35d68b2c6d Fix spelling errors 2017-07-05 17:53:16 +10:00
moneroexamples
125f823bda Add on_get_alt_blocks_hashes RPC call 2017-07-04 12:32:44 +08:00
Riccardo Spagni
218f1a1d69
Merge pull request #2125 
f98bf48b Minor cleanup: tab vs. space + logs messages (binaryFate)
 2017-07-03 12:30:46 +02:00
Riccardo Spagni
44e4bbd15c
Merge pull request #2124 
3b599d2b wallet2: get current height from the daemon on creation (moneromooo-monero)
d3bb72ff wallet2: fix infinite loop on future refresh height (moneromooo-monero)
32754784 wallet: fix refresh_from_height setting on new wallet (moneromooo-monero)
 2017-07-03 12:30:16 +02:00
Riccardo Spagni
645c898e2d
Merge pull request #2121 
5a09d79c Fix #2120: return per-tx amount in transfer_split RPC call. (binaryFate)
 2017-07-03 12:28:56 +02:00
Riccardo Spagni
b66420e54d
Merge pull request #2114 
b592cb3f Fix on_transfer RPC incorrect logging info (Mike C)
 2017-07-03 12:27:52 +02:00
Riccardo Spagni
7995dcff94
Merge pull request #2112 
76043b17 monero-wallet-cli: hang on exit in readline code (#2117) (moneromooo-monero)
a73a42a6 monero-wallet-cli: hang on exit in readline code (#2117) (moneromooo-monero)
be9d4f04 Fix multiline wallet cli output with readline (Jethro Grassie)
 2017-07-03 12:27:14 +02:00
Riccardo Spagni
bbdbccfba0
Merge pull request #2110 
7d2c89b6 Add french translation (Guillaume LE VAILLANT)
3255887f simplewallet: typo fixes (Guillaume LE VAILLANT)
 2017-07-03 12:26:02 +02:00
Riccardo Spagni
c577bc8762
Merge pull request #2107 
bdab3436 Fix mismatch of parameter name between header file and implementation for set_user_options() (Julien Klepatch)
 2017-07-03 12:24:16 +02:00
Riccardo Spagni
9e1ded69dd
Merge pull request #2106 
bb708ab8 electrum-words: fix seed mistakenly thought to be old style (moneromooo-monero)
 2017-07-03 12:23:39 +02:00
moneromooo-monero
02d66db4b4
tx_pool: initialize padding in txpool meta structure 2017-07-02 18:45:29 +01:00
moneromooo-monero
0722aea3df
cryptonote_core: initialize checkpoint flag 2017-07-02 18:45:25 +01:00
moneromooo-monero
5cea355232
simplewallet: lock idle scope when sweeping 
This ensures the chain and related structures can't change
while we're using them
 2017-06-30 09:33:37 +01:00
Howard Chu
464afd4d2d
Ensure DNSResolver destructor runs on exit 
Plugs a noisy but benign memory leak
 2017-06-28 22:21:06 +01:00
moneromooo-monero
8f96cfc20a
Remove typeid use in network_address 
Since I had to add an ID to the derived classes anyway,
this can be used instead. This removes an apparently
pointless warning from CLANG too.
 2017-06-28 09:11:24 +01:00
binaryFate
f98bf48b1d Minor cleanup: tab vs. space + logs messages 2017-06-26 12:30:14 +02:00
binaryFate
5a09d79caf Fix #2120: return per-tx amount in transfer_split RPC call. 2017-06-26 12:22:12 +02:00
moneromooo-monero
3b599d2b7e
wallet2: get current height from the daemon on creation 
Use current time to estimate current height only if the daemon
cannot be queried.
 2017-06-26 08:11:14 +01:00
moneromooo-monero
d3bb72fff1
wallet2: fix infinite loop on future refresh height 
If the refresh height is in the future, the current code will
loop till the actual height reaches this. Fix it by bailing out
if we receive only three hashes, which is what we set in the
call parameters.
 2017-06-26 06:58:37 +01:00
moneromooo-monero
32754784db
wallet: fix refresh_from_height setting on new wallet 
The previous patch was based on a wrong premise (that the
daemon height was 0 because the daemon calling code wasn't
yet initialized). In fact, current height approximation
was not setup for testnet. Fix this.
 2017-06-26 06:58:31 +01:00
Jethro Grassie
be9d4f0411
Fix multiline wallet cli output with readline 
monero-wallet-cli commands which have multine output sometimes causes
issues with the readline support. This patch fixes show_transfers,
payments and incoming_transfers.
 2017-06-25 10:48:02 -04:00
Riccardo Spagni
50d8f73f06
Merge pull request #2091 
e4da88a2 Fixed typo in rpc/core_rpc_server.cpp (Julien Klepatch)
 2017-06-24 12:43:28 +02:00
Riccardo Spagni
f31b89012d
Merge pull request #2073 
07c4276c Don't issue a new timedsync while one is already in progress (Howard Chu)
cf3a376c Don't timeout a slow operation that's making progress (Howard Chu)
340830de Fix PR#2039 (Howard Chu)
 2017-06-24 12:41:09 +02:00
Mike C
b592cb3f0a Fix on_transfer RPC incorrect logging info 2017-06-23 11:54:10 -04:00
Guillaume LE VAILLANT
3255887f5e simplewallet: typo fixes 2017-06-23 14:04:44 +02:00
Julien Klepatch
bdab3436d3 Fix mismatch of parameter name between header file and implementation for set_user_options() 2017-06-23 05:16:11 +08:00
moneromooo-monero
bb708ab8c3
electrum-words: fix seed mistakenly thought to be old style 
It'd see "empty" words due to extraneous spaces
 2017-06-22 16:47:07 +01:00
stoffu
d5f1cef73c
simplewallet: removed unneeded LOCK_IDLE_SCOPE() from check_tx_key() 2017-06-22 18:11:20 +09:00
stoffu
8df918f8c7
simplewallet: replace assert(m_wallet) with error out 2017-06-22 18:11:18 +09:00
stoffu
8da82256d4
crypto: moved boost::lock_guard into a smaller scope 2017-06-22 18:11:15 +09:00
stoffu
c9e0e944e9
Signature proving payment to destination by only revealing key derivation, not the actual tx secret key 2017-06-22 18:11:13 +09:00
Riccardo Spagni
ae8841f2ab
Merge pull request #2087 
4e13ab30 wallet_api: fix missing transaction parameter in callback (moneromooo-monero)
 2017-06-18 17:36:55 +02:00
Riccardo Spagni
78f965a9e2
Merge pull request #2082 
235df7f4 blockchain_db: add a txpool tx getter which returns existence (moneromooo-monero)
 2017-06-18 17:36:12 +02:00
Riccardo Spagni
91e1a7e3e2
Merge pull request #2081 
b2319a03 simplewallet: new command to generate a random payment id (moneromooo-monero)
 2017-06-18 17:34:41 +02:00
Riccardo Spagni
f973a2f81a
Merge pull request #2078 
1dd52415 Fix #1991 asm multiply again (Howard Chu)
 2017-06-18 17:32:03 +02:00
Riccardo Spagni
fb7d6db051
Merge pull request #2076 
ac0714dc add simplewallet --generate-new-wallet arg checks (Michael Shick)
 2017-06-18 17:27:52 +02:00
Riccardo Spagni
ae5f7c71d7
Merge pull request #2074 
e1f3dfcc Add readline support to cli (jethro)
 2017-06-18 17:26:08 +02:00
Riccardo Spagni
88b7cb9bda
Merge pull request #2070 
71f8249a Prevent crash if performing certain actions before wallet is initialized (Robby Weinberg)
 2017-06-18 16:43:35 +02:00
Riccardo Spagni
ace1440b65
Merge pull request #2066 
3fc22e7b Add histogram to poolstats (Howard Chu)
d09620b0 Fix PR#2039 (Howard Chu)
 2017-06-18 16:41:42 +02:00
Riccardo Spagni
a0174ad534
Merge pull request #2064 
6fc2dc39 cryptonote_protocol_handler: fix crash in debug log (moneromooo-monero)
 2017-06-18 16:40:52 +02:00
jethro
e1f3dfccc8 Add readline support to cli 
This PR adds readline support to the daemon and monero-wallet-cli. Only
GNU readline is supported (e.g. not libedit) and there are cmake checks
to ensure this.

There is a cmake variable, Readline_ROOT_DIR that can specify a
directory to find readline, otherwise some default paths are searched.

There is also a cmake option, USE_READLINE, that defaults to ON. If set
to ON, if readline is not found, the build continues but without
readline support.

One negative side effect of using readline is that the color prompt in
the wallet-cli now has no color and just uses terminal default. I know
how to fix this but it's quite a big change so will tackle another time.
 2017-06-18 10:08:37 -04:00
Riccardo Spagni
421a6d0340
Merge pull request #2055 
1b75ad91 Add OSX background mining (jethro)
 2017-06-18 14:24:48 +02:00
Riccardo Spagni
a237f90c5b
Merge pull request #2052 
072102cf abstracted nework addresses (moneromooo-monero)
 2017-06-18 14:23:59 +02:00
Julien Klepatch
e4da88a223 Fixed typo in rpc/core_rpc_server.cpp 2017-06-18 16:12:54 +08:00
Howard Chu
07c4276cbe
Don't issue a new timedsync while one is already in progress 
A timedsync is issued every minute on a connection, but the input
tineout is 2 minutes. This means a new sync request could be issued
while a slow sync request was already in progress. The additional
request will further clog the network on a slow connection, and
cause a premature timeout.
 2017-06-15 16:54:03 +01:00
moneromooo-monero
4e13ab306a
wallet_api: fix missing transaction parameter in callback 
It was unused, so harmless

Reported by erikd on IRC
 2017-06-13 19:34:51 +01:00
moneromooo-monero
235df7f484
blockchain_db: add a txpool tx getter which returns existence 
Avoids exception spam for the "nope, not found" case
 2017-06-11 15:36:48 +01:00
moneromooo-monero
b2319a03a6
simplewallet: new command to generate a random payment id 
This is trivial, but often requested, and possibly hard to do
in Windows. That makes it more user friendly.
 2017-06-10 10:08:55 +01:00
Howard Chu
1dd524151d
Fix #1991 asm multiply again 
Tweak temp variables and constraints. Was working before if not inlined
but newer gcc tends to inline it.
 2017-06-08 21:46:40 +01:00
jethro
1b75ad91aa Add OSX background mining 
Implements miner::get_system_times, miner::get_process_time and
miner::on_battery_power for OSX so that background mining works on OSX.
 2017-06-08 09:26:09 -04:00
Michael Shick
ac0714dcd7
add simplewallet --generate-new-wallet arg checks 
Add fail-fast paths that reduce frustration around the misuse of
--wallet-file combined with --restore-deterministic-wallet.  Flow now
gives more descriptive errors and avoids having users type in their
whole seed before the failure condition is noticed.
 2017-06-07 07:46:59 -07:00
Howard Chu
3fc22e7b78
Add histogram to poolstats 2017-06-04 22:48:14 +01:00
Robby Weinberg
71f8249a08 Prevent crash if performing certain actions before wallet is initialized 2017-06-03 19:56:51 -05:00
moneromooo-monero
6fc2dc3927
cryptonote_protocol_handler: fix crash in debug log 2017-06-01 19:42:33 +01:00
Riccardo Spagni
ea286d1a14
Merge pull request #2058 
6bcd3b2d fix get_upper_transaction rename (schnerchi)
 2017-06-01 19:42:37 +02:00
Riccardo Spagni
3d397325bf
Merge pull request #2063 
d17c0fc2 Don't copy blockchain for coinbase_tx_sum (Howard Chu)
 2017-06-01 19:33:43 +02:00
Riccardo Spagni
4a60e9e66e
Merge pull request #2062 
31417d57 tx_pool: add missing blockchain lock in add_tx (moneromooo-monero)
 2017-06-01 19:33:17 +02:00
Howard Chu
5414970dcd
Speedup print_pool_stats 
Since we're just counting txs, there's no reason to deserialize all the blobs.
 2017-06-01 17:34:03 +01:00
Howard Chu
d17c0fc2d0
Don't copy blockchain for coinbase_tx_sum 
Changed Blockchain::for_all_blocks() to for_blocks_range()
Operate on blockchain in-place instead of building a copy first.
 2017-06-01 14:14:24 +01:00
moneromooo-monero
31417d57da
tx_pool: add missing blockchain lock in add_tx 2017-05-31 22:55:13 +01:00
schnerchi
6bcd3b2df1 fix get_upper_transaction rename 2017-05-31 12:26:42 +02:00
Riccardo Spagni
8fbbefb8db
Merge pull request #2053 
05f3dcf7 simplewallet: fix refresh height for new wallets (moneromooo-monero)
 2017-05-30 21:28:40 +02:00
Riccardo Spagni
f5e65452ce
Merge pull request #2042 
740bc24c Wallet API: Set seed lang when recovering form keys (Jaquee)
 2017-05-30 21:24:45 +02:00
Riccardo Spagni
a4c13ea092
Merge pull request #2039 
4b932ff3 changed crypto to cncrypto so it generated libcncrypto (Gentian)
 2017-05-30 21:24:11 +02:00
Riccardo Spagni
4284f1777d
Merge pull request #2038 
89e20bb9 Fix typo (xmr-eric)
 2017-05-30 21:23:25 +02:00
Riccardo Spagni
cd13bcb4d2
Merge pull request #2036 
89b2f306 tests: fix invalid key image test (moneromooo-monero)
a374a522 wallet2: check key image validity domain in import_key_images (moneromooo-monero)
 2017-05-30 21:23:05 +02:00
Riccardo Spagni
9ea7fbed8a
Merge pull request #2032 
dd8e3266 shared libs build (i.e. make debug) (stoffu)
 2017-05-30 21:21:36 +02:00
Riccardo Spagni
907ce14b18
Merge pull request #2026 
a5739201 Update sync time copy (xmr-eric)
 2017-05-30 21:20:39 +02:00
Riccardo Spagni
d621f9e558
Merge pull request #2022 
e2529347 Correct spelling of 'get_upper_transaction_size_limit' (Nano Akron)
3029d0ef Remove the 1.25x multiplier in max transaction size in just the wallet (Nano Akron)
 2017-05-30 21:19:00 +02:00
Riccardo Spagni
62cc3b6447
Merge pull request #2021 
8ac2496c corrected typo in help regarding min-outputs-* (stoffu)
 2017-05-30 21:15:33 +02:00
Riccardo Spagni
024860b49d
Merge pull request #2020 
6cb1ad1f wallet fix: ensure iterator to be valid (stoffu)
 2017-05-30 21:14:24 +02:00
Riccardo Spagni
1555e7673d
Merge pull request #2017 
0a182576 node_rpc_proxy: fix earliest fork height query for unknown forks (moneromooo-monero)
391c918d wallet2: fix sweep_unmixable assuming wrong minimum mixin at v5 (moneromooo-monero)
 2017-05-30 21:13:47 +02:00
Riccardo Spagni
545e2b003c
Merge pull request #1982 
b52abd13 Move txpool to the database (moneromooo-monero)
 2017-05-30 21:12:44 +02:00
moneromooo-monero
05f3dcf738
simplewallet: fix refresh height for new wallets 
With the recent change to wallet creation code, the code was
calling to the daemon before the wallet's daemon address was
initialized, and thus failing. This was causing all new wallets
to refresh from 0 instead of just fetching early block hashes.
 2017-05-28 13:17:32 +01:00
moneromooo-monero
072102cfd2
abstracted nework addresses 
All code which was using ip and port now uses a new IPv4 object,
subclass of a new network_address class. This will allow easy
addition of I2P addresses later (and also IPv6, etc).
Both old style and new style peer lists are now sent in the P2P
protocol, which is inefficient but allows peers using both
codebases to talk to each other. This will be removed in the
future. No other subclasses than IPv4 exist yet.
 2017-05-27 11:35:54 +01:00
moneromooo-monero
0a182576d0
node_rpc_proxy: fix earliest fork height query for unknown forks 2017-05-26 21:34:44 +01:00
moneromooo-monero
b52abd1370
Move txpool to the database 
Integration could go further (ie, return_tx_to_pool calls should
not be needed anymore, possibly other things).

poolstate.bin is now obsolete.
 2017-05-25 22:23:37 +01:00
Jaquee
740bc24c95 Wallet API: Set seed lang when recovering form keys 2017-05-23 14:01:23 +02:00
Gentian
4b932ff314 changed crypto to cncrypto so it generated libcncrypto 
fix a cmakelist
 2017-05-23 07:45:40 -04:00
xmr-eric
89e20bb9af Fix typo 2017-05-19 00:40:51 -04:00
moneromooo-monero
a374a522df
wallet2: check key image validity domain in import_key_images 2017-05-18 09:19:48 +01:00
stoffu
dd8e3266b2
shared libs build (i.e. make debug) 2017-05-17 10:17:08 +09:00
xmr-eric
a57392016b Update sync time copy 2017-05-10 14:34:18 -04:00
Nano Akron
e2529347b6 Correct spelling of 'get_upper_transaction_size_limit' 2017-05-09 16:02:57 +01:00
Nano Akron
3029d0efb3 Remove the 1.25x multiplier in max transaction size in just the wallet 2017-05-09 16:01:11 +01:00
stoffu
8ac2496c5d
corrected typo in help regarding min-outputs-* 2017-05-09 12:06:46 +09:00
stoffu
6cb1ad1fa2
wallet fix: ensure iterator to be valid 2017-05-09 11:54:21 +09:00
moneromooo-monero
391c918d87
wallet2: fix sweep_unmixable assuming wrong minimum mixin at v5 
The bump to minimum mixin 4 was moved from v5 to v6
 2017-05-07 18:27:25 +01:00
Riccardo Spagni
81b370d5a1
Merge pull request #2012 
bbf4c210 Wallet API: add spend/view key getters (Jaquee)
 2017-05-05 11:35:03 +02:00
Riccardo Spagni
c17102c385
Merge pull request #2002 
12fff108 Change Old_English to English_Old - 'Old English' is actually a language (Nano Akron)
533187f0 Change all wallet language names into native names (and scripts) (Nano Akron)
 2017-05-05 11:29:51 +02:00
Riccardo Spagni
ed09652a17
Merge pull request #1701 
8277e67f Add anchor connections (Miguel Herranz)
 2017-05-05 11:26:11 +02:00
Jaquee
bbf4c21048 Wallet API: add spend/view key getters 2017-05-02 16:48:38 +02:00
Nano Akron
12fff108ea
Change Old_English to English_Old - 'Old English' is actually a language 2017-04-24 20:27:12 +01:00
moneromooo-monero
6df83b3efb
wallet: add sweep_below function 
It sweeps all outputs below the given threshold

This is available via the existing sweep_all RPC, by setting
amount_threshold the desired amount (in atomic units)
 2017-04-24 19:50:37 +01:00
Nano Akron
533187f0c3
Change all wallet language names into native names (and scripts) 2017-04-24 11:17:33 +01:00
Riccardo Spagni
9a9fb0483f
Merge pull request #1996 
a6d5bb75 wallet2: refer to triangular distribution for recent zone in comment (moneromooo-monero)
ac1aba90 wallet2: bias fake outs more towards recent outputs (moneromooo-monero)
 2017-04-24 10:55:24 +02:00
Riccardo Spagni
999b0f399d
Merge pull request #1989 
7f4beaa4 wallet2: fix removal of wrong txes from unconfirmed_payments (moneromooo-monero)
 2017-04-24 10:50:54 +02:00
Riccardo Spagni
0385999cda
Merge pull request #1984 
a255a540 simplewallet: allow multiline seed (moneromooo-monero)
5fce581c mnemonics: ignore multiple whitespace between words (moneromooo-monero)
 2017-04-24 10:49:51 +02:00
Riccardo Spagni
e53dd76a49
Merge pull request #1983 
72d113dd Amended software licenses for Portuguese and Spanish (Nano Akron)
54bcd260 Added Simplified Chinese electrum word list (Nano Akron)
 2017-04-24 10:49:24 +02:00
Riccardo Spagni
ae1d816768
Merge pull request #1976 
a7d78dda wallet2: fix --generate-from-json in RPC mode (moneromooo-monero)
 2017-04-24 10:48:56 +02:00
Riccardo Spagni
ed082a747a
Merge pull request #1973 
e9fb44ed wallet cli: removed some inappropriate return-false (kenshi84)
 2017-04-24 10:48:20 +02:00
Riccardo Spagni
865bb03ecf
Merge pull request #1968 
5e5b8512 Fix obsolete OpenSSL API usage (hyc)
6c72d6a0 Fix Android recognition (hyc)
e65d66fe Fix ARM64 identification (hyc)
a4673218 Clean up ARMv8-a aes_expand_key() (hyc)
a3d77901 Fix block_longhash_worker thread (hyc)
 2017-04-24 10:46:23 +02:00
Riccardo Spagni
29a77c9b19
Merge pull request #1961 
89d70756 wallet2: fix spurious output splitting when not merging destinations (moneromooo-monero)
 2017-04-24 10:43:39 +02:00
Riccardo Spagni
0a6da8929d
Merge pull request #1959 
10e137be wallet2: mention escaping/quoting --password in help string (moneromooo-monero)
 2017-04-24 10:43:13 +02:00
Riccardo Spagni
f65d739c41
Merge pull request #1954 
110b6831 Resolve #92 add ability to create wallets thru RPC (Howard Chu)
 2017-04-24 10:42:10 +02:00
Riccardo Spagni
acbe0b4849
Merge pull request #1938 
bff90264 Add expected total reward to RPC "getblocktemplate". Only works from V5 fork onward - returns 0 before that block. (assylias)
 2017-04-24 10:41:32 +02:00
moneromooo-monero
a6d5bb75fe
wallet2: refer to triangular distribution for recent zone in comment 
It was wrongly refering to equiprobable distribution, which I think
I'd originally done, but forgot to update the comment after changing
to triangular

Reported by smooth on IRC
 2017-04-22 11:22:39 +01:00
moneromooo-monero
ac1aba90f8
wallet2: bias fake outs more towards recent outputs 
Two recent papers quantified the real usage bias for the
real output in a ring being the true one, and shows that
the current biasing is much too weak.

While we wait for a better solution, we increase the ratio
of recent-to-total fake outputs, as well as decrease the
time window for recent outputs, so that half the fake outs
are selected within the last 1.8 day. Value plucked from
figure 10, page 11 of An Empirical Analysis of Linkability
in the Monero Blockchain, 2017, Miller et al.

This is also arbitrary, of course, but serves as a stopgap
till a better selection algorithm is chosen.
 2017-04-22 10:29:03 +01:00
assylias
bff90264b8
Add expected total reward to RPC "getblocktemplate". 
Only works from V5 fork onward - returns 0 before that block.
 2017-04-19 18:28:16 +01:00
moneromooo-monero
7f4beaa44a
wallet2: fix removal of wrong txes from unconfirmed_payments 
unconfirmed_payments changed from having the txid as key to
the payment id, and this was not changed to match.
 2017-04-17 19:37:13 +01:00
Nano Akron
72d113dd38
Amended software licenses for Portuguese and Spanish 2017-04-16 12:15:59 +01:00
Nano Akron
54bcd260ff
Added Simplified Chinese electrum word list 2017-04-16 12:06:53 +01:00
moneromooo-monero
a255a5407f
simplewallet: allow multiline seed 
People are likely to enter it in three lines as it is how it
is displayed at creation time
 2017-04-16 11:52:30 +01:00
moneromooo-monero
5fce581ce3
mnemonics: ignore multiple whitespace between words 2017-04-16 11:29:21 +01:00
moneromooo-monero
a7d78dda77
wallet2: fix --generate-from-json in RPC mode 
The daemon address was initialized too late
 2017-04-14 22:12:20 +01:00
hyc
a467321800 Clean up ARMv8-a aes_expand_key() 
The inline asm was lying about its parameters
 2017-04-12 23:53:08 +01:00
hyc
a3d779013d Fix block_longhash_worker thread 
Wasn't getting its stack size initialized; crashes on Android
with a default stack size of 1MB.
 2017-04-12 23:51:18 +01:00
kenshi84
e9fb44ed3c
wallet cli: removed some inappropriate return-false 2017-04-12 21:33:19 +09:00
Lee Clagett
93e10f1cc4 Simplified the implementation and features of span 2017-04-11 16:35:14 -04:00
Lee Clagett
4a8f96f95d Improvements for epee binary to hex functions: 
- Performance improvements
  - Added `span` for zero-copy pointer+length arguments
  - Added `std::ostream` overload for direct writing to output buffers
  - Removal of unused `string_tools::buff_to_hex`
 2017-04-11 16:35:00 -04:00
Howard Chu
110b683152
Resolve #92 add ability to create wallets thru RPC 
Reviewed and squashed. Open/Create is only allowed if no walletfile
was specified at startup.
 2017-04-11 01:22:44 +01:00
Riccardo Spagni
9ed496bbc5
Merge pull request #1956 
eb20f720 daemon: print average fee per byte in print_pool_stats (moneromooo-monero)
37be70bb daemon: add fee/byte when print pool transaction info (moneromooo-monero)
893f5a30 tx_pool: add blob size and fee/byte when logging a new tx (moneromooo-monero)
 2017-04-11 00:34:46 +02:00
Riccardo Spagni
c8dd4c58ce
Merge pull request #1955 
5b632468 core: fix blob size cache, and reenable hash and blob size caches (moneromooo-monero)
 2017-04-11 00:34:03 +02:00
Riccardo Spagni
878c4ee913
Merge pull request #1952 
548075b1 daemon: new relay_tx command and RPC (moneromooo-monero)
 2017-04-11 00:32:30 +02:00
Riccardo Spagni
4be94be168
Merge pull request #1951 
0a7885bf Wallet API: fix Cold signing split tx (Jaquee)
 2017-04-11 00:26:47 +02:00
Riccardo Spagni
e9ca165b1a
Merge pull request #1950 
f5bd3465 IOS CMAKE build settings (Jaquee)
d8a88d05 add IOS CMAKE toolchain (Jaquee)
 2017-04-11 00:26:15 +02:00
Riccardo Spagni
9c2bcabcdd
Merge pull request #1949 
0ee018b4 wallet2: do not go over the target tx size if many destinations (moneromooo-monero)
9ae566d0 simplewallet: fix cold signing of split transactions (moneromooo-monero)
aae14a10 simplewallet: allow setting confirm-missing-payment-id in watch wallets (moneromooo-monero)
 2017-04-11 00:25:09 +02:00
Riccardo Spagni
6353e5b0e5
Merge pull request #1946 
a38343bf miner: add a debug log in pause and resume (moneromooo-monero)
 2017-04-11 00:23:43 +02:00
Riccardo Spagni
17e8ce8c35
Merge pull request #1940 
17c7c62d Add per transaction fee to transfer command (Antti Keränen)
 2017-04-11 00:19:32 +02:00
Riccardo Spagni
2037083b5f
Merge pull request #1937 
64377c90 Add other possible paths of AC power status file on Linux (Guillaume LE VAILLANT)
 2017-04-11 00:15:24 +02:00
Riccardo Spagni
bf665e5991
Merge pull request #1931 
89e100bc wallet cli: remove redundant password confirm in donate command (kenshi84)
 2017-04-11 00:14:02 +02:00
Riccardo Spagni
541e1ff474
Merge pull request #1929 
89949706 simplewallet: factor the per-variable code in set_variable (moneromooo-monero)
 2017-04-11 00:13:40 +02:00
moneromooo-monero
89d707566a
wallet2: fix spurious output splitting when not merging destinations 2017-04-08 11:13:28 +01:00
moneromooo-monero
10e137be3a
wallet2: mention escaping/quoting --password in help string 2017-04-06 21:24:55 +01:00
moneromooo-monero
eb20f7209e
daemon: print average fee per byte in print_pool_stats 2017-04-04 19:00:57 +01:00
moneromooo-monero
37be70bbd7
daemon: add fee/byte when print pool transaction info 2017-04-04 09:04:39 +01:00
moneromooo-monero
893f5a301e
tx_pool: add blob size and fee/byte when logging a new tx 2017-04-04 09:04:11 +01:00
moneromooo-monero
5b63246813
core: fix blob size cache, and reenable hash and blob size caches 2017-04-03 22:19:57 +01:00
Jaquee
f5bd346573
IOS CMAKE build settings 2017-04-03 18:38:50 +02:00
Jaquee
0a7885bf19
Wallet API: fix Cold signing split tx 2017-04-02 14:19:21 +02:00
moneromooo-monero
548075b1f5
daemon: new relay_tx command and RPC 2017-04-02 12:17:35 +01:00
moneromooo-monero
0ee018b407
wallet2: do not go over the target tx size if many destinations 
If using a large input and many destinations, the code would
generate as many outputs as it could using that input, even if
it would bring the resulting tx above the max tx size.
 2017-04-02 11:13:15 +01:00
moneromooo-monero
9ae566d0dd
simplewallet: fix cold signing of split transactions 
They'd be rejected as suspicious as the change goes to more
than one destination. However, split transactions will most
likely include fake zero amount change to random addresses,
so we only consider change with non zero amount for this.
 2017-04-02 11:11:18 +01:00
moneromooo-monero
aae14a107a
simplewallet: allow setting confirm-missing-payment-id in watch wallets 
These can create transactions, even though they cannot sign them.
 2017-04-02 11:10:11 +01:00
Antti Keränen
17c7c62d55
Add per transaction fee to transfer command 
Allows priority argument default/unimportant/normal/elevated/priority to
be used per transaction in CLI wallet's transfer command. Resolves #1913.
 2017-04-01 09:59:15 +03:00
moneromooo-monero
a38343bf68
miner: add a debug log in pause and resume 2017-03-31 20:01:58 +01:00
Guillaume LE VAILLANT
64377c90b5 Add other possible paths of AC power status file on Linux 2017-03-28 11:35:18 +02:00
kenshi84
89e100bc8c
wallet cli: remove redundant password confirm in donate command 2017-03-27 11:02:20 +09:00
Riccardo Spagni
d1530f06bb
update version to 0.10.3.1 tag 2017-03-26 23:29:31 +02:00
moneromooo-monero
899497069b
simplewallet: factor the per-variable code in set_variable 2017-03-26 17:52:36 +01:00
moneromooo-monero
a96f9baeb4
core: disable tx/block hash cache 
Looks like it doesn't work on win64
 2017-03-26 02:21:01 +01:00
Riccardo Spagni
b1313aefd8
Merge pull request #1925 
93b32892 Silence warning about possibly uninitialized pointer (Guillaume LE VAILLANT)
 2017-03-25 17:36:23 +02:00
Riccardo Spagni
f64a0f2243
Merge pull request #1917 
6e679478 mnemonics: sanity checks for word lists (moneromooo-monero)
e98f1114 mnemonics: misc cleanup (moneromooo-monero)
 2017-03-25 17:35:52 +02:00
Guillaume LE VAILLANT
93b32892f7 Silence warning about possibly uninitialized pointer 2017-03-25 13:53:14 +01:00
moneromooo-monero
6e6794786a
mnemonics: sanity checks for word lists 
and a test to go with it

Remember to run the test when changing word lists, or simplewallet
will throw uncaught if that word list is used.
 2017-03-25 12:14:01 +00:00
moneromooo-monero
e98f1114a0
mnemonics: misc cleanup 
Pass relevant information to the base class instead of overwriting
default values later, use objects instead of pointers to objects
to avoid having to new objects unnecessarily.
 2017-03-25 11:51:04 +00:00
moneromooo-monero
a50c4a4fad
wallet: option to merge destinations 
With the change from the original transfer method to the new
algorithm, payments to the same destination were merged. It
seemed like a good idea, optimizing space. However, it is a
useful tool for people who want to split large outputs into
several smaller ones (ie, service providers making frequent
payments, and who do not like a large chunk of their balance
being locked for 10 blocks after each payment).

Default to off, which is a change from the previous behavior.
 2017-03-25 11:44:04 +00:00
Riccardo Spagni
e3d2b135e7
Merge pull request #1924 
6d315459 core: avoid possible reordering bugs wth tx/bloch hash cache (moneromooo-monero)
 2017-03-25 13:29:36 +02:00
Riccardo Spagni
119803f26e
Merge pull request #1921 
2bee92db Fixed typo in v5 hard fork finalized date (Derek Zhang)
d17179d1 Fixed typo in CLI wallet help message (Derek Zhang)
 2017-03-25 13:29:11 +02:00
Riccardo Spagni
4737f61c81
Merge pull request #1919 
0ad87db0 wallet: try to save large outputs when using an unneeded second input (moneromooo-monero)
 2017-03-25 13:28:19 +02:00
moneromooo-monero
6d315459b6
core: avoid possible reordering bugs wth tx/bloch hash cache 2017-03-25 09:18:53 +00:00
Derek Zhang
2bee92dbd0 Fixed typo in v5 hard fork finalized date 2017-03-24 18:06:55 -07:00
Derek Zhang
d17179d14b Fixed typo in CLI wallet help message 2017-03-24 18:05:05 -07:00
Roy Jacobs
5a4827ae21 Add Dutch mnemonics wordlist 2017-03-25 00:58:35 +01:00
moneromooo-monero
0ad87db01f
wallet: try to save large outputs when using an unneeded second input 
When a single input is enough to satisfy a transfer, the code would
previously try to add a second input, to match the "canonical" makeup
of a transaction with two inputs and two outputs. This would cause
wallets to slowly merge outputs till all the monero ends up in a
single output, which causes trouble when making two transactions
one after the other, since change is locked for 10 blocks, and an
increasing portion of the remaining balance would end up locked on
each transaction.

There are two new settings (min-output-count and min-output-value)
which can control when to stop adding such unneeded second outputs.
The idea is that small "dust" outputs will still get added, but
larger ones will not.

Enable with, eg:

set min-output-count 10
set min-output-value 30

to avoid using an unneeded second output of 30 monero or more, if
there would be less than 10 such outputs left.

This does not invalidate any other reason why such outputs would
be used (ie, when they're really needed to satisfy a transfer, or
when randomly picked in the normal course of selection). This may
be improved in the future.
 2017-03-24 21:04:08 +00:00
Riccardo Spagni
11e24bb2ba
Merge pull request #1916 
5a798358 blockchain: offset v5 addition date on testnet (moneromooo-monero)
 2017-03-24 14:36:44 +02:00
Riccardo Spagni
92c2d79d10
Merge pull request #1915 
a8646b09 Wallet API: add hard fork info functions (Jaquee)
 2017-03-24 14:34:55 +02:00
Riccardo Spagni
20387386b9
Merge pull request #1914 
31616af3 Fixes #1850 - Add French mnemonics wordlist (assylias)
 2017-03-24 14:34:07 +02:00
Riccardo Spagni
f543377789
Merge pull request #1894 
8bbcbcfb wallet rpc: enable solo mining (stoffu)
 2017-03-24 14:33:47 +02:00
moneromooo-monero
5a7983585e
blockchain: offset v5 addition date on testnet 
to silence the update warning, since v5 was done very early
on testnet
 2017-03-24 10:01:15 +00:00
Jaquee
a8646b0957
Wallet API: add hard fork info functions 2017-03-24 09:59:26 +01:00
assylias
31616af33d Fixes #1850 - Add French mnemonics wordlist 2017-03-23 21:53:20 +00:00
Riccardo Spagni
16f12f0628
Merge pull request #1912 
00cbf720 ringct: move ge_frombytes_vartime failure error to warning (moneromooo-monero)
 2017-03-23 11:47:26 +02:00
Riccardo Spagni
a73a886cb1
Merge pull request #1911 
91d41090 tx_pool: ensure txes loaded from poolstate.bin have their txid cached (moneromooo-monero)
aaeb164c tx_pool: remove transactions if they're in the blockchain (moneromooo-monero)
558cfc31 core, wallet: faster tx pool scanning (moneromooo-monero)
f065234b core: cache tx and block hashes in the respective classes (moneromooo-monero)
 2017-03-23 11:46:57 +02:00
Riccardo Spagni
7432f13898
Merge pull request #1910 
9bccf1b1 Transfer help (Akademik Prokhor Zakharov)
 2017-03-23 11:46:29 +02:00
Riccardo Spagni
8188f6bfe8
Merge pull request #1908 
c94f8fac daemon: better error reporting in commands (moneromooo-monero)
 2017-03-23 11:45:49 +02:00
Riccardo Spagni
4ec8a4c2b6
Merge pull request #1905 
2242d8eb tx_pool: silence use of uninitialized warning (moneromooo-monero)
 2017-03-23 11:45:00 +02:00
moneromooo-monero
91d4109023
tx_pool: ensure txes loaded from poolstate.bin have their txid cached 
The txid is not saved, and we want to make sure the transactions
have their txid cached while in the pool, since get_transactions
copies the transaction object, so any txid calculation on those
copies would not benefit any later caller, since the original tx
would be left without a cached txid.
 2017-03-23 09:25:33 +00:00
moneromooo-monero
aaeb164cf6
tx_pool: remove transactions if they're in the blockchain 
When starting up, if the pool state was not saved, the pool
might contain transactions which made it into the blockchain,
so these need removing
 2017-03-23 09:25:29 +00:00
moneromooo-monero
558cfc31ca
core, wallet: faster tx pool scanning 
Includes a new RPC to get tx pool hashes fast.
 2017-03-23 09:25:22 +00:00
moneromooo-monero
f065234b71
core: cache tx and block hashes in the respective classes 
An idea from smooth
 2017-03-23 09:25:17 +00:00
moneromooo-monero
00cbf72064
ringct: move ge_frombytes_vartime failure error to warning 
Avoids scaring people when seeing some invalid txes
 2017-03-22 21:26:38 +00:00
Akademik Prokhor Zakharov
9bccf1b11e Transfer help 
New pull request because I couldn't figure out how to change the previous one.
1. For clarity, I want to focus the help text for the 'transfer' command on the most typical use case (a single payment). 
2. New users will prefer to use 'transfer', so the older method 'transfer_original' should refer to 'transfer' rather than the other way around.
 2017-03-22 14:10:34 +01:00
moneromooo-monero
c94f8facf5
daemon: better error reporting in commands 2017-03-21 19:21:00 +00:00
moneromooo-monero
2242d8ebd6
tx_pool: silence use of uninitialized warning 
The result is not actually used when uninitialized
 2017-03-21 12:21:19 +00:00
Riccardo Spagni
4b34531307
Merge pull request #1897 
44a5b038 create a foreground non-interactive mode (Noah Watkins)
 2017-03-21 14:10:36 +02:00
Riccardo Spagni
70e71a1845
Merge pull request #1904 
995969b1 wallet: fix set_log not handling 0,xxx style settings (moneromooo-monero)
 2017-03-21 14:09:42 +02:00
Riccardo Spagni
7769a6e757
Merge pull request #1903 
350e99ae wallet2: cache which pool txes were scanned already (moneromooo-monero)
 2017-03-21 14:09:19 +02:00
Riccardo Spagni
9d157b519d
Merge pull request #1899 
c1e9ccc7 wallet2: speed up transactions using remote nodes (moneromooo-monero)
 2017-03-21 14:08:36 +02:00
moneromooo-monero
995969b190
wallet: fix set_log not handling 0,xxx style settings 2017-03-21 11:17:05 +00:00
moneromooo-monero
350e99ae57
wallet2: cache which pool txes were scanned already 
This massively speeds up the wallet updating the pool on mainnet,
where the tx backlog is more than 500 txes.
 2017-03-21 10:30:25 +00:00
moneromooo-monero
7c03349869
blockchain: lower the relay fee by 2% 
This ensures we accept txes with a fee that's slightly too small,
to accomodate blockchain median jitter
 2017-03-20 19:14:12 +00:00
moneromooo-monero
266492e919
tx_pool: use new filling algorithm from v5 only 2017-03-20 18:46:57 +00:00
moneromooo-monero
5b7c6ced80
wallet2: start using new fee priorities at v5, not 14 days laer 
Waiting would mean the fee used is 1x base, but the base will
have suddenly dropped
 2017-03-20 18:34:56 +00:00
moneromooo-monero
c1e9ccc794
wallet2: speed up transactions using remote nodes 
Asking for a full histogram from a remote node (since it's
untrusted) is pretty slow, and spams the remote node, so
we replace it by only adding a second input if we have rct
ones, which are for all intents and purposes always mixable.
 2017-03-20 08:44:28 +00:00
stoffu
8bbcbcfb0d
wallet rpc: enable solo mining 2017-03-20 09:47:16 +09:00
Riccardo Spagni
73e8510717
Merge pull request #1896 
a6f1d8fc core: call {prepare|cleanup}_handle_incoming_blocks when adding a mined block (moneromooo-monero)
 2017-03-19 23:03:18 +02:00
Riccardo Spagni
dbfbd3b698
Merge pull request #1895 
d3aaf740 Partial fix #1876, check thread in block_txn_start() (Howard Chu)
 2017-03-19 23:02:32 +02:00
Riccardo Spagni
45fa27b56a
Merge pull request #1892 
df810a82 wallet-rpc bugfix: get_transfer_by_txid previously checking against payment id (kenshi84)
 2017-03-19 22:58:55 +02:00
Riccardo Spagni
c97005723c
Merge pull request #1890 
50cd179a Removed boost/asio.hpp include from epee/string_tools.h (Lee Clagett)
 2017-03-19 22:55:39 +02:00
Riccardo Spagni
4a6fc007c6
Merge pull request #1889 
24ae7140 wallet: increase node_rpc_proxy timeout to match wallet2 (moneromooo-monero)
 2017-03-19 22:55:10 +02:00
moneromooo-monero
a6f1d8fc4c
core: call {prepare|cleanup}_handle_incoming_blocks when adding a mined block 
This ensures that a batch can't also be started/stopped out of
sync by another thread and us getting in the middle
 2017-03-19 12:40:26 +00:00
Howard Chu
d3aaf74080
Partial fix #1876, check thread in block_txn_start() 
Don't allow use of existing batch txn if it's from the wrong thread
 2017-03-19 12:27:03 +00:00
kenshi84
df810a8250
wallet-rpc bugfix: get_transfer_by_txid previously checking against payment id 2017-03-19 17:45:39 +09:00
Lee Clagett
50cd179a60 Removed boost/asio.hpp include from epee/string_tools.h 2017-03-18 22:05:14 -04:00
moneromooo-monero
24ae71404f
wallet: increase node_rpc_proxy timeout to match wallet2 2017-03-18 23:06:06 +00:00
Riccardo Spagni
df140d90ee
Merge pull request #1887 
c5316d29 update version to 0.10.3.0 (Riccardo Spagni)
 2017-03-18 21:56:56 +02:00
moneromooo-monero
d5fbfd677c
daemon: fix missing close parenthesis in alt_chain_info output 
Reported by assylias_ on IRC
 2017-03-18 19:19:32 +00:00
Riccardo Spagni
c5316d2929
update version to 0.10.3.0 2017-03-18 20:34:52 +02:00
Riccardo Spagni
82411cdf3a
Merge pull request #1886 
f9a2b527 simplewallet: allow setting tx priority in watch wallets (moneromooo-monero)
 2017-03-18 20:31:37 +02:00
Riccardo Spagni
a48e41787b
Merge pull request #1885 
63d7cd88 daemon: alt_chain_info now prints fork depth (moneromooo-monero)
 2017-03-18 20:31:12 +02:00
Riccardo Spagni
a6f1959d1c
Merge pull request #1884 
e9175cec wallet_rpc_server: make a few RPCs unavailable in restricted mode (moneromooo-monero)
 2017-03-18 20:30:50 +02:00
Riccardo Spagni
f33a696ec7
Merge pull request #1883 
d0238313 use const references in catch blocks (moneromooo-monero)
 2017-03-18 20:30:19 +02:00
Riccardo Spagni
9aac64c238
Merge pull request #1882 
3fa59755 wallet2: call is_key_image_spent in blocks in rescan_spent (moneromooo-monero)
9d134e86 wallet_rpc_server: add a rescan_spent RPC (moneromooo-monero)
 2017-03-18 20:29:22 +02:00
Riccardo Spagni
4fb39a9d20
Merge pull request #1881 
1a666c30 simplewallet: catch case where no transactions are made (moneromooo-monero)
 2017-03-18 20:28:45 +02:00
Riccardo Spagni
d628ed2c14
Merge pull request #1880 
8d787e24 bump version number (Riccardo Spagni)
 2017-03-18 20:27:44 +02:00
Riccardo Spagni
585445d0bc
Merge pull request #1879 
c1c9eeaa p2p: use the fallback seed IPs when not enough seeds are found (moneromooo-monero)
 2017-03-18 20:27:00 +02:00
moneromooo-monero
f9a2b5279d
simplewallet: allow setting tx priority in watch wallets 
Those can create unsigned transactions
 2017-03-18 18:07:54 +00:00
moneromooo-monero
63d7cd8882
daemon: alt_chain_info now prints fork depth 2017-03-18 16:59:57 +00:00
moneromooo-monero
e9175cec07
wallet_rpc_server: make a few RPCs unavailable in restricted mode 
Address book modification, setting tx nodes, importing key images
 2017-03-18 13:01:53 +00:00
moneromooo-monero
d023831327
use const references in catch blocks 2017-03-18 12:56:07 +00:00
moneromooo-monero
3fa5975520
wallet2: call is_key_image_spent in blocks in rescan_spent 
This is a potentially long lasting daemon RPC call
 2017-03-18 12:47:07 +00:00
moneromooo-monero
9d134e8647
wallet_rpc_server: add a rescan_spent RPC 2017-03-18 12:04:17 +00:00
moneromooo-monero
1a666c3016
simplewallet: catch case where no transactions are made 
This would otherwise be a silent noop, which is confusing.
This can happen if the daemon is started, but not yet ready
to service all requests, and this is a safe catch all.
 2017-03-18 11:44:31 +00:00
moneromooo-monero
c1c9eeaaf7
p2p: use the fallback seed IPs when not enough seeds are found 
In case the DNS seed(s) is/are down, which would otherwise
cause the fallback seeds to never be used. Also if the seeds
resolve to too few IPs.
 2017-03-18 11:40:28 +00:00
Riccardo Spagni
8d787e2414
bump version number 2017-03-17 23:42:06 +01:00
stoffu
250c4cb3e0
wallet-rpc: enable openalias 2017-03-17 10:42:10 +09:00
Riccardo Spagni
c642d3224c
Merge pull request #1869 
3396a9f2 Add intervening v5 fork for increased min block size (moneromooo-monero)
 2017-03-15 18:23:51 +01:00
Riccardo Spagni
e5b5d041f5
Merge pull request #1868 
585c9176 Specify "524,288" iterations instead of "500,000" (darentuzi)
 2017-03-15 18:21:43 +01:00
Riccardo Spagni
2f8e0af7f9
Merge pull request #1867 
b54e19d0 protocol: fix wrong tx being looked up from fluffy block (moneromooo-monero)
 2017-03-15 18:21:19 +01:00
Riccardo Spagni
6de3a70347
Merge pull request #1861 
badec326 Adds a config file option to the wallet (Arne Brutschy)
 2017-03-15 18:20:53 +01:00
moneromooo-monero
3396a9f2af
Add intervening v5 fork for increased min block size 
Minimum mixin 4 and enforced ringct is moved from v5 to v6.
v5 is now used for an increased minimum block size (from 60000
to 300000) to cater for larger typical/minimum transaction size.

The fee algorithm is also changed to decrease the base per kB
fee, and add a cheap tier for those transactions which we do
not care if they get delayed (or even included in a block).
 2017-03-15 08:32:51 +00:00
darentuzi
585c917691 Specify "524,288" iterations instead of "500,000" 
CryptoNight does exactly 524,288 iterations over the scratchpad as defined in CNS008, saying 500,000 could be confusing. I know its meant to give a rough idea (around 500k) to the reader but if you are reading the code, might as well know the exact number.
 2017-03-14 16:39:44 +02:00
moneromooo-monero
b54e19d00e
protocol: fix wrong tx being looked up from fluffy block 
Found by smooth
 2017-03-13 19:16:25 +00:00
Riccardo Spagni
c6102d5c1b
Merge pull request #1864 
74b216a1 core: don't try to re-relay an empty set of pool transactions (moneromooo-monero)
 2017-03-13 17:22:33 +01:00
Riccardo Spagni
22e51c5d29
Merge pull request #1863 
09e060fe protocol: fix fluffy to normal block dropping txes (moneromooo-monero)
 2017-03-13 17:22:10 +01:00
Arne Brutschy
badec326d8 Adds a config file option to the wallet 2017-03-12 21:45:59 +01:00
moneromooo-monero
74b216a17f
core: don't try to re-relay an empty set of pool transactions 2017-03-12 14:57:58 +00:00
moneromooo-monero
09e060febb
protocol: fix fluffy to normal block dropping txes 2017-03-12 14:14:51 +00:00
kenshi84
7d07c64fe5
fix dependency: put HardFork back to cryptonote_basic, made some BlockchainDB functions virtual again to avoid missing symbols error 2017-03-10 11:22:39 +09:00
Riccardo Spagni
ba0767477d
Merge pull request #1841 
b553c282 rpc: fix BUILD_TAG mispelling (BUILDTAG) (moneromooo-monero)
02097c87 core: print the "new update found" message in cyan, for visibility (moneromooo-monero)
749ebace download: check available disk space before downloading (moneromooo-monero)
f36c5f1e download: give download threads distinct names (moneromooo-monero)
f6211322 core: make update download cancellable (moneromooo-monero)
63f0e074 download: async API (moneromooo-monero)
9bf017ed http_client: allow cancelling a download (moneromooo-monero)
0d90123c http_client: allow derived class to get headers at start (moneromooo-monero)
 2017-03-06 15:17:08 +00:00
Riccardo Spagni
ea047307da
Merge pull request #1848 
cfa2564a blockchain: don't try to load an empty block hash set (moneromooo-monero)
38359036 blockchain_import: make --log-level understand categories (moneromooo-monero)
5fee8561 blockchain_export: make --log-level understand categories (moneromooo-monero)
50ebf661 blockchain_import: error out nicely on exceptions (moneromooo-monero)
87d57d9c blockchain_export: error out nicely on exceptions (moneromooo-monero)
 2017-03-06 15:16:02 +00:00
Riccardo Spagni
5bcb25f3f8
Merge pull request #1846 
4b48565c wallet: add password command (moneromooo-monero)
 2017-03-06 15:14:59 +00:00
moneromooo-monero
cfa2564a40
blockchain: don't try to load an empty block hash set 
If the blocks aren't being linked against a binary (such as
one of the blockchain utilities), the symbol will not be
NULL, but the size will be 0. This avoids a apurious warning
about the data hash.
 2017-03-05 19:46:55 +00:00
moneromooo-monero
3835903650
blockchain_import: make --log-level understand categories 2017-03-05 19:45:22 +00:00
moneromooo-monero
5fee85616d
blockchain_export: make --log-level understand categories 2017-03-05 19:45:00 +00:00
moneromooo-monero
50ebf66150
blockchain_import: error out nicely on exceptions 2017-03-05 19:25:01 +00:00
moneromooo-monero
87d57d9c59
blockchain_export: error out nicely on exceptions 2017-03-05 19:24:47 +00:00
moneromooo-monero
b553c282fb
rpc: fix BUILD_TAG mispelling (BUILDTAG) 
This ensures a manual or RPC update tries the right build tag,
rather than source, which is currently not setup
 2017-03-05 16:59:39 +00:00
moneromooo-monero
02097c87eb
core: print the "new update found" message in cyan, for visibility 2017-03-05 16:59:36 +00:00
moneromooo-monero
749ebacebd
download: check available disk space before downloading 
We don't check *while* the download happens, so it might
still be that we don't have enough space later
 2017-03-05 16:59:32 +00:00
moneromooo-monero
f36c5f1e08
download: give download threads distinct names 2017-03-05 16:59:29 +00:00
moneromooo-monero
f6211322e5
core: make update download cancellable 2017-03-05 16:59:25 +00:00
moneromooo-monero
63f0e074eb
download: async API 2017-03-05 16:58:48 +00:00
Riccardo Spagni
e66866c1fc
Merge pull request #1844 
d18ff58a format_utils: fix typo in assert message (lethos3)
 2017-03-05 18:13:49 +02:00
Riccardo Spagni
b375dde57f
Merge pull request #1843 
3964b30f Add dependency for blocksdat.o (Howard Chu)
 2017-03-05 18:01:03 +02:00
Riccardo Spagni
8cb58dbb69
Merge pull request #1842 
223fe5bb wallet: fix get_tranfers with multiple incoming txes with same pid (moneromooo-monero)
 2017-03-05 17:52:42 +02:00
Riccardo Spagni
a861992359
Merge pull request #1839 
c7dd0b15 Revert "wallet: fix insertion of pool transactions" (moneromooo-monero)
 2017-03-05 17:47:18 +02:00
moneromooo-monero
4b48565c9e
wallet: add password command 
Also tweak wallet2 password code to verify password without
saying it's a new wallet, because it's assuming things.
 2017-03-05 14:53:46 +00:00
lethos3
d18ff58a1c format_utils: fix typo in assert message 
Fix two small typos as mentioned by reddit user nthterm.
 2017-03-05 11:11:44 +13:00
Howard Chu
3964b30f2d
Add dependency for blocksdat.o 
To make sure it gets regenerated whenever checkpoints.dat changes
Likewise for blocks.o and testnet_blocks.o
 2017-03-04 22:02:10 +00:00
moneromooo-monero
223fe5bbe2
wallet: fix get_tranfers with multiple incoming txes with same pid 2017-03-04 21:47:53 +00:00
Riccardo Spagni
4728ab977a
Merge pull request #1837 
31533493 core: quantize per kB fee to 8 decimals (moneromooo-monero)
 2017-03-04 21:15:04 +02:00
Riccardo Spagni
f2d0f0174f
Merge pull request #1836 
cd71774d tx_pool: log separately "not ready" and "double spend" cases (moneromooo-monero)
 2017-03-04 21:14:38 +02:00
moneromooo-monero
c7dd0b1535
Revert "wallet: fix insertion of pool transactions" 
This reverts commit d47dac9a88.

Callers actually expect the key to be payment id, so this
needs a lot more changes (like storing payment ids in the
structure, and possibly also to other existing structures
which do the same thing).
 2017-03-04 12:41:19 +00:00
moneromooo-monero
3153349325
core: quantize per kB fee to 8 decimals 2017-03-03 23:31:56 +00:00
moneromooo-monero
cd71774d77
tx_pool: log separately "not ready" and "double spend" cases 2017-03-03 22:32:51 +00:00
Howard Chu
e4437b2551
Fix double-import 
Incomplete ifdef cleanup in 9e82b694da
 2017-03-03 21:45:14 +00:00
Howard Chu
eb62dcc871
Remove redundant num_txs() method 
Cleanup of bf1348b7e2
 2017-03-03 16:52:45 +00:00
Howard Chu
296641e047
Fix #1824 don't end batch that we didn't start 2017-03-03 16:50:53 +00:00
Jaquee
9ae33b51fb
wallet api: fix parameters in wallet2callbackImpl 2017-03-03 15:49:12 +01:00
Jaquee
1cf2f5a5c2 use txid in wallet2::process_new_transaction() 2017-03-03 15:48:32 +01:00
Riccardo Spagni
e24cd86c18
Merge pull request #1827 
db1c7d80 wallet api: add missing mining options (Jaquee)
 2017-03-03 14:31:28 +02:00
Riccardo Spagni
d35d626181
Merge pull request #1826 
2c468dd4 allow user I/O in millinero, micronero, nanonero, piconero (moneromooo-monero)
 2017-03-03 14:31:04 +02:00
Riccardo Spagni
2f9ecd4fba
Merge pull request #1823 
d47dac9a wallet: fix insertion of pool transactions (moneromooo-monero)
 2017-03-03 14:30:24 +02:00
Riccardo Spagni
78a99fe7da
Merge pull request #1820 
7a44f38a Add support for the wallet to refresh pruned blocks (moneromooo-monero)
da18898f ringct: do not require range proof in decodeRct/decodeRctSimple (moneromooo-monero)
b49c6ab4 rpc: add a default category for daemon rpc (moneromooo-monero)
f113b92b core: add functions to serialize base tx info (moneromooo-monero)
6fd4b827 node_rpc_proxy: allow caching daemon RPC version (moneromooo-monero)
b5c74e40 wallet: invalidate node proxy cache when reconnecting (moneromooo-monero)
 2017-03-03 14:30:02 +02:00
Riccardo Spagni
11f8e0d33f
Merge pull request #1687 
1a7e18bf Make gray peer selection uniform (Miguel Herranz)
f3be9991 Make get_random_gray_peer distribution uniform (Miguel Herranz)
 2017-03-03 14:29:23 +02:00
Riccardo Spagni
9e10fac223
Merge pull request #1814 
11a00df6 daemon: fix bc_dyn_stats via rpc (moneromooo-monero)
 2017-03-03 14:14:51 +02:00
Riccardo Spagni
460836a2b7
Merge pull request #1813 
b8a08f19 wallet: fix --log-file not working (moneromooo-monero)
 2017-03-03 14:14:09 +02:00
Riccardo Spagni
1965c819f6
Merge pull request #1811 
378d2bb1 Revert attempt to write to console on daemon shutdown (Nano Akron)
 2017-03-03 14:13:52 +02:00
Riccardo Spagni
3787ffca80
Merge pull request #1804 
12adb4a3 core: move hardfork back to cryptonote_core (moneromooo-monero)
 2017-03-03 14:11:09 +02:00
Riccardo Spagni
14c6c910d7
Merge pull request #1803 
53105743 Wallet API: Add support for daemon rpc login (Jaquee)
 2017-03-03 14:10:44 +02:00
Riccardo Spagni
27b7320fed
Merge pull request #1801 
96ce57d5 protocol: tone down a rate limit not implemented yet warning (moneromooo-monero)
 2017-03-03 14:04:35 +02:00
moneromooo-monero
2c468dd429
allow user I/O in millinero, micronero, nanonero, piconero 2017-03-02 19:02:41 +00:00
Jaquee
db1c7d80b1
wallet api: add missing mining options 2017-03-02 14:09:04 +01:00
moneromooo-monero
d47dac9a88
wallet: fix insertion of pool transactions 
They were inserted using payment id as key, not txid
 2017-02-28 21:19:24 +00:00
Miguel Herranz
1a7e18bfdf Make gray peer selection uniform 
Prevents the system from always picking the gray peers with the most
recent last_seen.
 2017-02-28 17:39:39 +01:00
moneromooo-monero
b8a08f199a
wallet: fix --log-file not working 2017-02-28 09:07:56 +00:00
moneromooo-monero
7a44f38a7f
Add support for the wallet to refresh pruned blocks 2017-02-27 22:29:00 +00:00
moneromooo-monero
da18898f0e
ringct: do not require range proof in decodeRct/decodeRctSimple 
These fields aren't used, and they'll actually be pruned in
some cases
 2017-02-27 22:28:45 +00:00
moneromooo-monero
b49c6ab45d
rpc: add a default category for daemon rpc 2017-02-27 20:25:35 +00:00
moneromooo-monero
f113b92b93
core: add functions to serialize base tx info 
That is, information without signatures (for v1) nor range
proofs and MGs (for v2)
 2017-02-27 20:24:39 +00:00
moneromooo-monero
6fd4b827fb
node_rpc_proxy: allow caching daemon RPC version 2017-02-27 17:57:18 +00:00
moneromooo-monero
b5c74e4041
wallet: invalidate node proxy cache when reconnecting 2017-02-27 17:46:55 +00:00