moneromooo-monero
a0985044d9
wallet2: better test on whether to allow output import
...
Being offline is not a good enough heuristic, so we keep track
of whether the wallet ever refreshed from a daemon, which is a
lot better, and probably the best we can do without manual user
designation (which would break existing cold wallet setups till
the user designates those wallets)
2022-08-18 19:29:03 +00:00
moneromooo-monero
c5579ac236
allow exporting outputs in chunks
...
this will make it easier huge wallets to do so without hitting
random limits (eg, max string size in node).
2022-08-18 06:53:41 +00:00
j-berman
1e912ecd8a
wallet2: fixes for export/import output flow
...
- only allow offline wallets to import outputs
- don't import empty outputs
- export subaddress indexes when exporting outputs
2022-08-16 14:22:42 +00:00
moneromooo-monero
692f1d4e3d
wallet2: do not assume imported outputs must be non empty
2022-08-16 14:22:33 +00:00
moneromooo-monero
67b6d6ae2c
wallet2: prevent importing outputs in a hot wallet
2022-08-16 14:22:33 +00:00
moneromooo-monero
d9fc666db8
wallet2: fix missing subaddress indices in "light" exported outputs
2022-08-16 14:22:24 +00:00
moneromooo-monero
600de07bcf
wallet_rpc_server: longer timeout for stop_mining
...
That RPC will wait for mining to actually stop, which can be a while
if randomx has just started on randomx_init_dataset.
This fixes occasional failures in the mining functional test
2022-07-21 12:00:05 +00:00
luigi1111
070c3d6b0f
Merge pull request #8433
...
db8181a
2022-07-14 22:15:27 -04:00
luigi1111
02cbccc529
Merge pull request #8432
...
edcc094
2022-07-14 22:14:41 -04:00
luigi1111
d912444a4a
Merge pull request #7986
...
5770265
2022-07-14 12:54:39 -04:00
koe
edcc094558
derive multisig tx secret keys from an entropy source plus the tx inputs' key images
2022-07-13 12:40:34 -05:00
luigi1111
cfdee9ba69
Merge pull request #8421
...
bd1e7c5
2022-07-13 00:39:54 -04:00
luigi1111
6fed8c2d9f
Merge pull request #8149
...
c7b2944
2022-07-13 00:38:29 -04:00
Jeffrey Ryan
4d7f6f5cd5
GCC: fix some unused warnings
...
hash_extra: don't test for success in `jh_hash` and `skein_hash` since its guaranteed
device_ledger: move anonymous global variable apdu_verbose into .cpp file
Add comments to `refreshed` method variable in wallet2
2022-07-11 20:32:03 -05:00
luigi1111
4476c35fc8
Merge pull request #8408
...
09a597b
2022-07-06 00:01:59 -05:00
luigi1111
cea2498e95
Merge pull request #8404
...
50ccc7e
2022-07-06 00:01:29 -05:00
luigi1111
7a118f08f4
Merge pull request #8394
...
4278a3a
2022-07-06 00:00:24 -05:00
luigi1111
45a44aa45f
Merge pull request #8388
...
04c0da2
2022-07-05 23:58:46 -05:00
luigi1111
969316685b
Merge pull request #8371
...
16f8e04da0715e
2022-07-05 23:58:06 -05:00
j-berman
bd1e7c5635
wallet2: prevent crash when reading tx w/fewer outputs than expected
2022-07-05 21:39:59 -07:00
luigi1111
82cde936c3
Merge pull request #8356
...
de2f0d0
2022-07-03 17:26:35 -05:00
anon
c7b2944f89
multisig: fix critical vulnerabilities in signing
2022-06-30 12:56:40 -05:00
tobtoht
09a597ba28
wallet2: don't use DNS to obtain segregation heights
2022-06-28 23:12:03 +02:00
tobtoht
04c0da2986
Chunk /gettransactions to avoid hitting restricted RPC limit
2022-06-27 21:23:56 +02:00
tobtoht
db8181adf8
wallet2: force using output distribution for ringct outs
...
Co-authored-by: j-berman <justinberman@protonmail.com>
2022-06-25 13:06:11 +02:00
tobtoht
50ccc7e726
wallet2: remove obsolete rpc version check
2022-06-24 21:58:07 +02:00
moneromooo-monero
4278a3a7e3
cryptonote_basic: catch crypto api errors
2022-06-20 22:17:57 +00:00
moneromooo-monero
23fde151ee
wallet_rpc_server: chunk refresh to keep responding to RPC while refreshing
2022-06-03 07:15:15 +00:00
Luke Parker
16f8e042b5
Remove erraneous commas
2022-06-01 19:38:42 -04:00
Luke Parker
da0715e503
Improve consistency between on_money_received and on_money_received_unconfirmed
...
unconfirmed solely uses a - b, and received now accepts b so it can
provide more detailed logs on what occurred (printing a - b, yet with a
and b).
2022-06-01 18:20:11 -04:00
luigi1111
1ff2b02064
Merge pull request #8331
...
fde7c96
2022-05-26 21:24:38 -05:00
luigi1111
f96cf86532
Merge pull request #8328
...
2979474
2022-05-26 21:22:52 -05:00
selsta
de2f0d0102
wallet_api: add scanTransactions function
2022-05-26 03:51:31 +02:00
moneromooo-monero
5bb2369b55
wallet_rpc_server: add --no-initial-sync flag for quicker network binding
2022-05-25 09:02:27 +00:00
moneromooo-monero
2979474221
disable multisig by default
...
There are vulnerabilities in multisig protocol if the parties do not
trust each other, and while there is a patch for it, it has not been
throroughly reviewed yet, so it is felt safer to disable multisig by
default for now.
If all parties in a multisig setup trust each other, then it is safe
to enable multisig.
2022-05-17 19:52:03 +00:00
luigi1111
5b9724b03d
Merge pull request #8308
...
f63f7dc
2022-05-16 13:51:18 -05:00
moneromooo-monero
fde7c96b5c
wallet2: fix spurious reorg detection with untrusted nodes
...
When forced to deal with an untrusted node, a wallet will quantize
its current height to disguise the real height to the adversary, to
try and minimize the daemon's ability to distinguish returning
wallets.
Daemons will thus return more blocks than the wallet needs, starting
from earlier in the chain. These extra blocks will be disregarded
by the wallet, which had already scanned them.
However, for the purposes of reorg size detection, the wallet assumes
all blocks the daemon sends are different, which is only correct if
the wallet hasn't been coy, which is only the case for trusted
daemons (which you should use). This causes an issue when the size
of this "fake reorg" is above the sanity check threshold at which
the wallet refuses a reorg.
To fix this, the reorg size check is moved later on, when the reorg
is about to actually happen, after the wallet has checked which
blocks are actually different from the ones it expects.
2022-05-15 11:57:37 +00:00
moneromooo-monero
df2e680825
wallet2: speedup large tx construction: reserve vector memory
...
2.8 seconds -> 2.6 seconds on a test case
2022-05-13 17:43:22 +00:00
Crypto City
38cdf01c64
wallet2: speedup large tx construction: batch ringdb lookups
...
3.3 seconds -> 2.8 seconds on a test case
2022-05-13 17:43:22 +00:00
Crypto City
2b95178897
wallet2: speedup large tx construction: batch ringdb updates
...
5.2 seconds -> 4.1 seconds on a test case
2022-05-13 17:43:20 +00:00
moneromooo-monero
c9cf0b78f8
wallet2: speedup large tx construction: cache public key validity
...
5.9 second -> 5.2 seconds on a test case
2022-05-13 17:43:16 +00:00
luigi1111
436ca13722
Merge pull request #8277
...
baee2c0
2022-05-10 16:49:13 -05:00
luigi1111
c1625a8928
Merge pull request #8220
...
0d6ecb1
2022-05-10 16:41:02 -05:00
selsta
f63f7dc7e2
wallet2: fix a couple unused variable warnings
2022-05-02 21:28:40 +02:00
koe
0d6ecb1136
multisig: add post-kex verification round to check that all participants have completed the multisig address
2022-04-29 14:04:59 -05:00
luigi1111
a092b943d5
Merge pull request #8249
...
a14fdf8
2022-04-25 10:20:10 -05:00
luigi1111
e13244ea9c
Merge pull request #8178
...
5d388eb
2022-04-25 10:18:26 -05:00
Luke Parker
baee2c06ec
Preserve commitment format inside transactions
2022-04-21 18:58:47 -04:00
luigi1111
9f814edbd7
Merge pull request #8254
...
9df7179
2022-04-19 22:21:21 -05:00
j-berman
5d388eb74d
Bump ring size to 16 for v15 & remove set default in wallet cli
2022-04-18 14:36:28 -07:00
j-berman
ea87b30f89
Add view tags to outputs to reduce wallet scanning time
...
Implements view tags as proposed by @UkoeHB in MRL issue
https://github.com/monero-project/research-lab/issues/73
At tx construction, the sender adds a 1-byte view tag to each
output. The view tag is derived from the sender-receiver
shared secret. When scanning for outputs, the receiver can
check the view tag for a match, in order to reduce scanning
time. When the view tag does not match, the wallet avoids the
more expensive EC operations when deriving the output public
key using the shared secret.
2022-04-18 00:49:53 -07:00
moneromooo-monero
9df7179aaf
wallet2: use BP+ for cold signing
...
reported by ukoehb
2022-04-10 21:03:09 +00:00
moneromooo-monero
b030f20751
Fee changes from ArticMine
...
https://github.com/ArticMine/Monero-Documents/blob/master/MoneroScaling2021-02.pdf
with a change to use 1.7 instead of 2.0 for the max long term increase rate
2022-04-10 18:13:34 +00:00
Jeffrey
a14fdf8d5a
Remove /include
...
* `IWallet.h` hasn't been touched since 2014, and has been replaced by `src/wallet/api/wallet2_api.h`
* `INode.h` is in a similar situation with `src/p2p/net_node.h`
2022-04-09 23:47:02 -05:00
luigi1111
f096ac1349
Merge pull request #8215
...
d1f1947
2022-04-06 00:16:20 -04:00
luigi1111
9a124f6811
Merge pull request #8213
...
7dcfccb
2022-04-06 00:15:40 -04:00
luigi1111
0eb1b570b6
Merge pull request #8197
...
da9aa1f
2022-04-06 00:08:53 -04:00
luigi1111
88a5606795
Merge pull request #8195
...
3c82958
2022-04-06 00:07:36 -04:00
luigi1111
0285c07d7d
Merge pull request #8179
...
ae0a840
2022-04-06 00:06:20 -04:00
luigi1111
d054def63f
Merge pull request #7170
...
bd27debb7713ccb535d66a0d80b175bd004a3450604c94cfe5acdd0e
2022-04-05 23:56:09 -04:00
luigi1111
fb2f822c52
Merge pull request #7153
...
354e1d9
2022-04-05 23:48:18 -04:00
moneromooo-monero
4c94cfecfc
store outPk/8 in the tx for speed
...
It avoids dividing by 8 when deserializing a tx, which is a slow
operation, and multiplies by 8 when verifying and extracing the
amount, which is much faster as well as less frequent
2022-04-05 18:50:22 +00:00
moneromooo-monero
a0d80b1f95
plug bulletproofs plus into consensus
2022-04-05 18:50:17 +00:00
moneromooo-monero
ae0a840fda
wallet2: decrease the amount of data exchanged for output export
2022-03-29 08:40:32 +00:00
luigi1111
d9e6baac42
Merge pull request #8158
...
e5000a9
2022-03-18 16:28:16 -05:00
reemuru
d1f1947995
wallet_rpc_server: support regex for get_accounts tag
...
This commit adds a 'regexp' boolean field to the get_accounts
request. The flag is set to false by default and maintains backwards
compatibility. When set to true the user can search tags by regular
expression filters. An additional error message was added for failed
regular expression searches. Bump minor version to 25.
2022-03-13 11:30:48 -04:00
moneromooo-monero
7dcfccbaaf
wallet_rpc_server: fix make_integrated_address with no payment id
2022-03-11 17:23:19 +00:00
Norman Moeschter
354e1d9c65
Make the wallet name optional when locked.
2022-03-10 08:16:14 +00:00
mj-xmr
da9aa1f7f8
Copyright: Update to 2022
2022-03-04 06:59:20 +01:00
luigi1111
27f1d43547
Merge pull request #8145
...
fb5b2b3
2022-03-02 18:53:34 -05:00
luigi1111
5eaa4434e8
Merge pull request #7877
...
e08abaa
2022-03-02 18:51:54 -05:00
selsta
3c829586be
wallet2: update stagenet rollback blocks
2022-03-01 00:25:41 +01:00
koe
e08abaa43f
multisig key exchange update and refactor
2022-02-22 16:37:42 -06:00
woodser
e5000a9f0c
Balance includes unconfirmed transfers to self
2022-01-31 07:52:38 -05:00
luigi1111
d94715fd71
Merge pull request #8123
...
4446cc8
2022-01-24 15:15:11 -05:00
luigi1111
5283cf51ef
Merge pull request #8044
...
a02b342
2022-01-24 15:10:55 -05:00
woodser
fb5b2b352a
support authentication in monero-wallet-rpc set_daemon
2022-01-17 17:03:56 -05:00
woodser
4446cc88c3
wallet inits cache if file and blob missing
2021-12-24 09:22:57 -05:00
woodser
53be72c08a
make_uri disallows standalone payment ids
2021-11-30 09:28:45 -05:00
rbrunner7
a02b342347
Avoid unnecessary 'Invalid hashing blob' error message
2021-11-05 14:19:21 +01:00
luigi1111
d573b3d76c
Merge pull request #8020
...
47e7a43
2021-11-01 12:31:32 -05:00
luigi1111
ff4ede9356
Merge pull request #8017
...
a15466d
2021-11-01 12:29:22 -05:00
luigi1111
f405bf3d58
Merge pull request #8013
...
2cad563
2021-11-01 12:25:20 -05:00
tobtoht
47e7a43270
wallet_api: enable set_strict_default_file_permissions
2021-10-22 05:40:23 +02:00
selsta
e106bdc1fc
epee: add missing header
2021-10-22 04:14:25 +02:00
selsta
a15466d850
wallet2: remove 2 unused variables
2021-10-20 22:19:15 +02:00
moneromooo-monero
2cad563060
wallet2: fix key encryption when changing ask-password from 0/1 to 2
...
we reuse the wallet_keys_unlocker object, which does the right thing
in conjunction with other users of decrypt/encrypt (ie, refresh).
2021-10-19 22:01:45 +00:00
luigi1111
99507da993
Merge pull request #7994
...
84c5257
2021-10-17 23:38:47 -05:00
luigi1111
19a6cc26fc
Merge pull request #7867
...
eed7e79
2021-10-17 23:26:50 -05:00
luigi1111
308e601966
Merge pull request #7799
...
76542ea
2021-10-17 23:23:15 -05:00
luigi1111
7f477c1902
Merge pull request #7793
...
13a8a57
2021-10-11 12:54:17 -05:00
j-berman
84c52571ed
Decrease the "recent spend window" in gamma re-select to 15 blocks
...
- combined with patching integer truncation (#7798 ), this gets the algorithm marginally closer to mirroring empirically observed output ages
- 50 was originally chosen assuming integer truncation would remain in the client for that client release version. But patching integer truncation causes the client to select more outputs in the 10-100 block range, and therefore the benefit of choosing a larger recent spend window of 50 has less merit
- 15 seems well-suited to cover the somewhat sizable observable gap in the early window of blocks
2021-10-04 20:12:42 -07:00
tobtoht
5770265a16
wallet2: keep around transaction prefix for confirmed transfers
2021-10-01 12:42:48 +02:00
j-berman
76542ea709
Fix precision of average_output_time
...
The fix as suggested by <jberman> on IRC. Before the fix, it would truncate 1.9 to 1 skewing the output selection.
2021-09-12 10:07:31 +02:00
luigi1111
a39b1d56c8
Merge pull request #7899
...
cd76eb7
2021-09-09 15:21:10 -04:00
luigi1111
9273530bff
Merge pull request #7898
...
f353c29
2021-09-09 15:20:43 -04:00
luigi1111
dfa6b58d4d
Merge pull request #7823
...
24d3d65
2021-09-09 15:14:17 -04:00
luigi1111
b7315efc1c
Merge pull request #7342
...
520ce1c
2021-09-09 15:06:46 -04:00
mj-xmr
eed7e79c04
UB: Not calling virtual method in destructor of WalletImpl
2021-09-07 14:24:53 +02:00
selsta
cd76eb7b8c
wallet: fix unused lambda capture warning
2021-08-28 15:18:32 +02:00
selsta
f353c295f9
wallet_rpc_server: fix help text remaining bold
2021-08-27 02:59:36 +02:00
SChernykh
e52802baef
Wallet2: fix optimize-coinbase for p2pool payouts
...
RefreshOptimizeCoinbase was an optimization to speed up scanning of coinbase transactions before RingCT (tx version 2) where they split miner reward into multiple denominations, all to the same wallet.
When RingCT was introduced, all coinbase transactions became 1 output only, so this optimization does nothing now.
With p2pool, this optimization will skip scanning p2pool payouts because they use more than 1 output in coinbase transaction.
Fix it by applying this optimization only to pre-RingCT transactions (version < 2).
2021-08-26 11:50:15 +02:00
luigi1111
0061da9e63
Merge pull request #7878
...
a9aaa47
2021-08-20 16:50:24 -04:00
luigi1111
8b9eea92f1
Merge pull request #7849
...
6f15a0c
2021-08-20 16:49:59 -04:00
luigi1111
1b079e5195
Merge pull request #7845
...
e1af8dc
2021-08-20 16:45:15 -04:00
luigi1111
5812b757e0
Merge pull request #7821
...
da2955f
2021-08-20 16:33:53 -04:00
Kermit Alexander II
24d3d65d42
monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir
2021-08-20 08:54:41 -05:00
j-berman
e1af8dc02c
Protect client from divide by 0 caused by integer truncation
2021-08-19 14:56:36 -07:00
j-berman
da2955feae
Apply gamma distr from chain tip when selecting decoys
...
- matches the paper by Miller et al to apply the gamma from chain tip, rather than after unlock time
- if the gamma produces an output more recent than the unlock time, the algo packs that output into one of the first 50 spendable blocks, respecting the block density factor
2021-08-19 14:51:20 -07:00
tobtoht
a9aaa47abb
wallet_api: add make_uri
2021-08-19 15:35:37 +02:00
luigi1111
cb08466394
Merge pull request #7802
...
a3d2b71
2021-08-11 22:33:38 -04:00
luigi1111
62844a776d
Merge pull request #7786
...
9c6e094fix #7784 - deinit wallet in wallet dtor (Dusan Klinec)
2021-08-11 22:30:11 -04:00
j-berman
6f15a0c8d3
Make sure node returns to wallet that real output is unlocked
2021-08-11 07:28:10 -07:00
Dusan Klinec
13a8a576ed
trezor: try empty passphrase first
...
- Try empty passphrase first when opening a wallet, as all Trezors will have passphrase enabled by default by Trezor Suite by default.
This feature enables easier access to all users using disabled passphrase (or empty passhprase)
- If wallet address differs from device address with empty passphrase, another opening attempt is made, without passphrase suppression,
so user can enter his passhprase if using some. In this scenario, nothing changes to user, wallet opening just consumes one more call
to Trezor (get wallet address with empty passphrase)
- also change how m_passphrase is used. Previous version did not work well with recent passphrase entry mechanism change (made in Trezor),
thus this commit fixes the behaviour).
2021-08-03 13:54:04 +02:00
luigi1111
ed506006d2
Merge pull request #7796
...
0c6e1d3
2021-08-02 18:54:46 -04:00
luigi1111
eeda76570c
Merge pull request #7790
...
bc8d764
2021-08-02 18:53:05 -04:00
luigi1111
8c41d14ad5
Merge pull request #7788
...
f5eb2ce
2021-08-02 18:50:25 -04:00
luigi1111
894e5b2794
Merge pull request #7767
...
5fa1c90
2021-08-02 18:47:05 -04:00
luigi1111
9aa2d4c16e
Merge pull request #7747
...
8cf95c8
2021-08-02 18:42:32 -04:00
Alex Opie
5fa1c90102
Fix describe_transfer for multiple txes in a txset
...
This ensures each list of recipients is only the recipients
for one transaction. It also adds a new field "summary"
that describes the txset as a whole.
Fixes #7344
2021-08-02 20:39:49 +02:00
luigi1111
2d5b8a6ff7
Merge pull request #7740
...
8cea9d8
2021-07-27 16:55:14 -04:00
rating89us
a3d2b71ee9
wallet_api: expose offline mode status
2021-07-19 00:30:36 +02:00
moneromooo-monero
0c6e1d343e
wallet2: chunk get_outs.bin calls to avoid sanity limits
2021-07-15 17:25:07 +00:00
tobtoht
f5eb2ce968
wallet2: Don't auto lock device on process parsed blocks
2021-07-14 13:02:54 +02:00
Dusan Klinec
bc8d7644d2
wallet: rephrase error message on invalid device address
2021-07-14 11:02:29 +02:00
Dusan Klinec
9c6e0941cb
fix #7784 - deinit wallet in wallet dtor
2021-07-14 10:46:16 +02:00
anon
fe76d7dee7
cmake: fix undefined symbols and multiple definitions
2021-07-13 08:00:20 +02:00
luigi1111
3c8c8e5a5b
Merge pull request #7761
...
8ef51dc
2021-07-10 17:59:56 -04:00
luigi1111
c53e22c40a
Merge pull request #7748
...
bbeb555
2021-07-10 17:57:39 -04:00
tobtoht
bbeb555f00
wallet_api: getPassword
2021-07-05 02:49:27 +02:00
tobtoht
8a67724218
wallet_api: get bytes sent/received
2021-06-24 21:32:03 +02:00
luigi1111
4f08d52dfa
Merge pull request #7750
...
8e0b8dd
2021-06-24 14:12:37 -05:00
luigi1111
0a9d218044
Merge pull request #7749
...
e63c110
2021-06-24 14:11:45 -05:00
luigi1111
99aa45fd34
Merge pull request #7746
...
1aa1850
2021-06-24 14:06:13 -05:00
luigi1111
7c3629a5ee
Merge pull request #7742
...
f174a8f
2021-06-24 14:05:35 -05:00
luigi1111
ce129599d0
Merge pull request #7739
...
6914d5b
2021-06-24 14:04:42 -05:00
selsta
8ef51dc546
wallet_api: fix typo in exportKeyImages
2021-06-23 20:44:13 +02:00
woodser
e7615772fa
provide key images of spent outputs in wallet rpc
2021-06-15 15:54:39 -04:00
luigi1111
7499837a6f
Merge pull request #7661
...
08e4497
2021-06-10 12:00:54 -05:00
luigi1111
ca73284951
Merge pull request #7729
...
b2e1558
2021-06-10 11:47:05 -05:00
luigi1111
a1a3e970f7
Merge pull request #7662
...
4da1112
2021-06-10 11:34:20 -05:00
selsta
8e0b8ddb96
wallet/api: remove Bitmonero namespace alias
2021-06-08 23:29:41 +02:00
tobtoht
e63c1107c0
wallet_api: address_book: don't lose pid on setDescription
2021-06-08 15:20:48 +02:00
tobtoht
8cf95c8f29
wallet2: refresh: check error and throw before potentially breaking out of loop
2021-06-04 18:37:06 +02:00
tobtoht
1aa1850ba5
wallet_api: signMessage: add sign with subaddress
2021-06-04 18:16:10 +02:00
tobtoht
f174a8f05f
wallet_api: reconnectDevice
2021-06-04 15:24:53 +02:00
tobtoht
8cea9d8605
wallet: Reset RPC Pay ID on node switch
...
RPC pay client ID is sent with each RPC request, set a new secret every time we switch nodes to mitigate trivial correlation
2021-06-04 13:58:09 +02:00
tobtoht
6914d5b914
wallet_api: move adjust_mixin call within try block
2021-06-04 13:41:10 +02:00
woodser
b2e1558bde
support freeze, thaw, and frozen in wallet rpc
2021-05-18 20:35:48 -04:00
mj-xmr
44e8395d2a
CMake: glob missing headers for wallet2
2021-05-14 14:22:29 +02:00
