Riccardo Spagni
e9aa886d9e
Merge pull request #4921
...
ac665418
2018-12-12 11:59:56 +02:00
Riccardo Spagni
e19a205ff4
Merge pull request #4920
...
e98ae34e
2018-12-12 11:59:43 +02:00
Riccardo Spagni
83684ea515
Merge pull request #4909
...
756684bb
2018-12-12 11:59:25 +02:00
Riccardo Spagni
4556f0e2b8
Merge pull request #4908
...
5ca4994c
2018-12-12 11:59:04 +02:00
Riccardo Spagni
0fccc78e39
Merge pull request #4903
...
dc1c1252
2018-12-12 11:58:37 +02:00
Riccardo Spagni
d855f9bb92
Merge pull request #4901
...
a48f2dab17b45725
2018-12-12 11:57:31 +02:00
Riccardo Spagni
85262ca8cd
Merge pull request #4899
...
2be31b4c
2018-12-12 11:56:21 +02:00
Riccardo Spagni
c73ac91af8
Merge pull request #4897
...
9b5efad2
2018-12-12 11:55:13 +02:00
Riccardo Spagni
0b31baf6e4
Merge pull request #4839
...
d71f89e265b9bca79cf636afd21dad70318cc784
2018-12-12 11:53:42 +02:00
Riccardo Spagni
dde1e69723
Merge pull request #4787
...
3dba7f25
2018-12-12 11:53:10 +02:00
Jethro Grassie
b56b5b52eb
ignore child process when exec
2018-12-08 20:52:54 -05:00
moneromooo-monero
0e2f5cb5fc
perf_timer: make all logs Info level
...
and make them not default at log level 1
2018-12-08 10:53:09 +00:00
moneromooo-monero
2d7b0236eb
wallet2: clear all payments on soft rescan_bc
...
They'll get duplicated otherwise
2018-12-08 10:39:54 +00:00
moneromooo-monero
3a3858dc90
epee: avoid string allocation when parsing a pod from string
2018-12-08 02:00:34 +00:00
moneromooo-monero
25e5a8539c
singleton: fix missing *this return value in operator=
...
while there, disable both operator= and copy ctor, since they
are not supposed to be around for a singleton
2018-12-07 16:56:59 +00:00
moneromooo-monero
93c59b29a8
perf_timer: check allowed categories before logging
2018-12-07 14:23:47 +00:00
moneromooo-monero
6a507dab6f
perf_timer: add a way to get and reset the current time
2018-12-07 14:23:47 +00:00
moneromooo-monero
c1581a5bb8
perf_timer: only log to file
2018-12-07 14:23:47 +00:00
moneromooo-monero
dbbb3ce9d8
cryptonote: don't serialize for blob size if already known
2018-12-07 14:07:26 +00:00
moneromooo-monero
570dd3690e
p2p: use vector instead of list for peer lists
2018-12-07 13:20:34 +00:00
moneromooo-monero
5464725a29
protocol: change standby mode to not wait sleeping
2018-12-07 12:53:11 +00:00
selsta
1d892ec881
simplewallet: donate command validate amount
2018-12-07 13:43:21 +01:00
moneromooo-monero
db5737413e
util: use fcntl instead of flock, for compatibility
...
in particular with NFS
2018-12-06 12:59:29 +00:00
moneromooo-monero
9cc68a2f74
tx_pool: add a few std::move where it can make a difference
2018-12-05 21:13:37 +00:00
moneromooo-monero
d1efe3d91c
cryptonote: set tx hash on newly parsed txes when known
2018-12-05 21:13:29 +00:00
moneromooo-monero
5511563e92
db_lmdb: avoid pointless division
2018-12-05 21:13:24 +00:00
moneromooo-monero
833269834d
db_lmdb: inline check_open, it's trivial and called everywhere
2018-12-05 21:13:21 +00:00
moneromooo-monero
ce594f5af7
blockchain_db: allocate known size vector only once
2018-12-05 21:13:18 +00:00
moneromooo-monero
6644b9b7b7
blockchain_db: remove a couple unused functions
2018-12-05 21:13:13 +00:00
moneromooo-monero
1505dd38c9
util: set MONERO_DEFAULT_LOG_CATEGORY
...
Otherwise it'd end up with whatever was included last
2018-12-05 14:53:30 +00:00
moneromooo-monero
9e64a71e7d
blockchain: call deinit in dtor
...
This ensures the io service that runs in another thread cannot
access data after it's deleted
2018-12-05 00:13:28 +00:00
Dusan Klinec
d71f89e2a2
device/trezor: device/trezor: correct device initialization, status check
...
- checks if the device is in the correct usable state
- implements check for the v2.0.9 firmware which does not support payment IDs
- simple transacttion check, payment id fmt consistency
- minor fixes, refactoring, webusb session counting fix
2018-12-04 20:12:03 +01:00
Dusan Klinec
65b9bca70e
device/trezor: python2 compatibility - bundle dependencies
2018-12-04 18:38:18 +01:00
Dusan Klinec
9cf636af69
device/trezor: ask for KI sync on first refresh
...
When doing a first refresh on HW-token based wallet KI sync is required if money were received. Received money may indicate wallet was already used before the restore I.e., some transaction could have been already sent from the wallet. The spent UTXO would not be detected as spent which could lead to double spending errors on submitting a new transaction.
Thus if the wallet is HW-token based with the cold signing protocol and the first refresh detected received money the user is asked to perform the key image sync.
2018-12-04 18:38:17 +01:00
Dusan Klinec
d21dad70dd
device: enable to use multiple independent device wallets
...
- adds a new option `--hw-device-deriv-path` to the simple wallet. Enables to specify wallet derivation path / wallet code (path avoided so it can be misinterpreted as a file path).
- devices can use different derivation mechanisms. Trezor uses standard SLIP-10 mechanism with fixed SLIP-44 prefix for Monero
- Trezor: when empty, the default derivation mechanism is used with 44'/128'/0'. When entered the derivation path is 44'/128'/PATH.
- Trezor: the path is always taken as elements are hardened (1<<31 bit turned on)
2018-12-04 18:38:16 +01:00
Riccardo Spagni
7e957c162a
Merge pull request #4879
...
243f010e
2018-12-04 17:34:57 +02:00
Riccardo Spagni
5ed45acaec
Merge pull request #4906
...
506472e0
2018-12-04 17:33:53 +02:00
Riccardo Spagni
81418cb281
Merge pull request #4894
...
aee7a4e31a0733e50dac3c645d9915abd4f50cb16116397130023074
2018-12-04 17:33:19 +02:00
Riccardo Spagni
6d1c2a9304
Merge pull request #4892
...
c28e3d2d
2018-12-04 17:32:42 +02:00
moneromooo-monero
243f010edc
rpc: mask values that are nobody else's business in restricted RPC
2018-12-04 15:32:21 +00:00
Riccardo Spagni
0e0777e4d1
Merge pull request #4888
...
b0d9d605
2018-12-04 17:31:43 +02:00
Riccardo Spagni
6e74aa9a6c
Merge pull request #4885
...
b5573fc2
2018-12-04 17:31:27 +02:00
Riccardo Spagni
1bebe99496
Merge pull request #4884
...
56e616e8
2018-12-04 17:31:15 +02:00
Riccardo Spagni
302fd80826
Merge pull request #4882
...
6bfcc573
2018-12-04 17:30:30 +02:00
Riccardo Spagni
e799fc87ae
Merge pull request #4866
...
9c923badec1a62b5
2018-12-04 17:30:11 +02:00
Riccardo Spagni
d4a0fb2b89
Merge pull request #4880
...
96e6b439
2018-12-04 17:29:46 +02:00
Riccardo Spagni
e282e9fa40
Merge pull request #4878
...
517f25ef
2018-12-04 17:28:24 +02:00
Riccardo Spagni
868630c1db
Merge pull request #4877
...
c25260f5
2018-12-04 17:16:52 +02:00
moneromooo-monero
ec1a62b50d
move int-util.h to epee
2018-12-04 15:14:29 +00:00
Riccardo Spagni
a605c0da08
Merge pull request #4872
...
fc99f177
2018-12-04 17:13:21 +02:00
Riccardo Spagni
e7d30780de
Merge pull request #4869
...
60f36386
2018-12-04 17:12:47 +02:00
Riccardo Spagni
eba668c6ad
Merge pull request #4862
...
3998a9373900fb77
2018-12-04 17:09:40 +02:00
Riccardo Spagni
11d86f6008
Merge pull request #4859
...
6f2497bc
2018-12-04 17:09:21 +02:00
Riccardo Spagni
c00ac446fd
Merge pull request #4854
...
bd98e99c
2018-12-04 17:08:42 +02:00
Riccardo Spagni
398f7076bb
Merge pull request #4853
...
2b3595d0
2018-12-04 17:07:51 +02:00
Riccardo Spagni
94288d7d1d
Merge pull request #4845
...
6732fc7f
2018-12-04 17:06:04 +02:00
TheCharlatan
5a76933903
Add glibc back compat code
...
To ensure that the binaries compiled by gitian run across many linux
distributions, enforce 2.17 as the minimum libc version supported.
2018-12-04 02:21:06 +01:00
moneromooo-monero
affff949f9
blockchain: fix race between two external mining threads
2018-12-02 13:08:41 +00:00
Tadeas Moravec
6456cb415a
Bulletproof: Initialize members in default construtor.
...
Fixing a build warning on g++ 7.3.0
2018-12-01 13:03:32 +00:00
moneromooo-monero
9b69a0ae01
daemon: print monero version at startup when calling a detached daemon
...
So people who want a timstamp get a timestamp
2018-11-30 17:55:16 +00:00
moneromooo-monero
0c5dd3161b
cryptonote: add a set_null for transaction_prefix
...
Since it's all inline, I suspect the compiler will merge the
duplicate stores anyway.
2018-11-30 15:11:43 +00:00
moneromooo-monero
aba9a9c277
daemon: stop miner before we bring the whole thing down
...
This avoids the miner erroring out trying to submit blocks
to a core that's already shut down (and avoids pegging
the CPU while we're busy shutting down).
2018-11-30 15:10:25 +00:00
moneromooo-monero
ac665418f0
ringct: fix dummy bulletproofs on ledger in fake mode
...
Ledger does some basic checks on them
2018-11-30 13:33:29 +00:00
Dusan Klinec
318cc78457
device/trezor: passphrase entry on host
...
- simple device callback object added. Device can request passphrase/PIN entry via the callback or notify user some action is required
- callback is routed to wallet2, which routes the callback to i_wallet_callback so CLI or GUI wallets can support passphrase entry for HW tokens
- wallet: device open needs wallet callback first - passphrase protected device needs wallet callback so user can enter passphrase
2018-11-29 04:33:41 +01:00
Jason Wong
dc1c12528d
add command pop_blocks
...
add new public method to Blockchain and update according to code review
update after review: better lock/unlock, try catch and coding style
2018-11-28 12:20:28 +01:00
moneromooo-monero
a48f2dab00
blockchain_prune_known_spent_data: blackball file is now optional
...
If not present, the tool will scan the blockchain, since scanning
for this is fairly fast.
2018-11-27 15:45:47 +00:00
moneromooo-monero
17b45725af
Outputs where all amounts are known spent can now be pruned
...
Only for pre rct for obvious reasons.
Note: DO NOT use a known spent list which includes outputs
which are not known spent. If the list includes any output
that's just strongly thought to be spent, but not provably
so, you risk finding yourself unable to sync past the point
where that output is spent.
I estimate only 200 MB saved on current mainnet though,
unless the new blackballing rule unearths a good amount of
large-amount-set extra spent outs.
2018-11-27 15:45:42 +00:00
moneromooo-monero
756684bb28
blockchain: avoid unnecessary DB lookups when syncing
...
Some of the inputs for block in a span will be from other earlier
blocks in that span. Keep track of those outputs so we don't have
to look them up again after those early blocks are added to the
blockchain.
2018-11-27 14:03:06 +00:00
moneromooo-monero
5ca4994c9c
rpc: speed up the common get_output_distribution case while syncing
2018-11-27 14:01:40 +00:00
moneromooo-monero
e98ae34e4b
core: fix adding new pre-hoh block when a tx is already in the pool
2018-11-26 23:45:01 +00:00
stoffu
0e2a5d75de
simplewallet: use is_transfer_unlocked instead of is_tx_spendtime_unlocked for show_transfers
...
Followup on #4728
2018-11-27 07:50:16 +09:00
Riccardo Spagni
58ce16d4d9
Merge pull request #4821
...
fc98f7a0
2018-11-26 21:51:27 +02:00
moneromooo-monero
fc98f7a0a1
rpc: speedup get_outs.bin
2018-11-26 18:56:23 +00:00
Riccardo Spagni
3e2abc9eaa
Merge pull request #4834
...
2c7195d8
2018-11-26 20:30:15 +02:00
Riccardo Spagni
4a64303d71
Merge pull request #4831
...
c5ee14ae
2018-11-26 20:29:06 +02:00
Riccardo Spagni
c4fd8ce97e
Merge pull request #4830
...
dffec258
2018-11-26 20:28:49 +02:00
Riccardo Spagni
eccb9b08c4
Merge pull request #4825
...
b9b307d1
2018-11-26 20:28:02 +02:00
Riccardo Spagni
b37ce24cdd
Merge pull request #4824
...
2ffe53d9
2018-11-26 20:27:29 +02:00
Riccardo Spagni
cc1ea0b651
Merge pull request #4816
...
1a4d1603
2018-11-26 20:25:39 +02:00
moneromooo-monero
506472e0c6
protocol: fix use after free when dropping a connection
2018-11-26 17:19:25 +00:00
Dusan Klinec
2ffe53d9e6
device/trezor: webusb transport added, cmake fixes
...
- webusb transport based on libusb added. Provides direct access to Trezor via USB, no need for Trezor bridge.
- trezor protocol message handler improved, no recursion used. Ready for upcoming integration tests.
- libusb (for docker) bumped from v1.0.9 to v1.0.22, newer version required for webusb transport, for device enumeration.
- cmake improvements and fixes. Cmake Trezor checks are moved to a dedicated CheckTrezor.cmake file. In case of a problem Trezor is excluded from build.
- ifdefs made consistent to Ledger.
- UDP Transport enumeration disabled by default in release mode
2018-11-25 11:57:19 +01:00
moneromooo-monero
2be31b4c9c
blockchain_blackball: spot when all outputs of an amount are spent
2018-11-24 11:07:15 +00:00
stoffu
9b5efad294
simplewallet: enable donation on testnet/stagenet for easier testing
2018-11-24 08:25:38 +09:00
moneromooo-monero
aee7a4e364
wallet_rpc_server: do not use RPC data if the call failed
...
Found by codacy.com
2018-11-23 15:38:00 +00:00
moneromooo-monero
1a0733e534
windows_service: fix memory leak
...
Found by codacy.com
2018-11-23 15:38:00 +00:00
moneromooo-monero
5d9915ab9e
cryptonote: fix get_unit for non default settings
...
Found by codacy.com
2018-11-23 15:37:39 +00:00
moneromooo-monero
d4f50cb109
remove some unused code
...
Found by codacy.com
2018-11-23 15:37:36 +00:00
moneromooo-monero
611639710d
a few minor (but easy) performance tweaks
...
Found by codacy.com
2018-11-23 15:36:48 +00:00
moneromooo-monero
3002307418
tests: slow_memmem now returns size_t
...
Makes more sense than uint64_t for an offset, and agrees with
the %zu used to print results.
Found by codacy.com
2018-11-23 15:36:48 +00:00
stoffu
c28e3d2dae
rctOps: add braces to suppress warnings
2018-11-23 12:28:04 +09:00
moneromooo-monero
b0d9d6051f
cn_deserialize: allow parsing partially valid tx extra
2018-11-22 11:15:57 +00:00
stoffu
b5573fc231
wallet2: resume processing when tx extra is partially broken
...
Motivated by https://monero.stackexchange.com/questions/10483
Some exchanges appear to have customized the wallet software
in an inappropriate way, making the tx extra field partially
unreadable. PR #3716 changed the wallet behavior disallowing
such partially valid tx extra.
An example tx reported by the user is
e87c675a85f34ecac58a8846613d25062f1813e1023c552b705afad32b972c38
where the normal tx pubkey appears again with the aditional
tx pubkeys tag `04` which is inappropriate.
2018-11-22 14:51:35 +09:00
moneromooo-monero
56e616e855
wallet2: add n_vouts to capture list
2018-11-22 01:45:45 +00:00
Jethro Grassie
517f25efd1
rpc: add version to get_info
2018-11-21 12:56:34 -05:00
moneromooo-monero
6bfcc57395
scoped_message_writer: protect all std::cout usage from readline
2018-11-21 12:48:43 +00:00
moneromooo-monero
96e6b43970
blockchain_stats: don't use gmtime_r on Windows
...
In some cases, it doesn't like it (I don't know the details).
Factor into a new epee function
2018-11-21 00:50:53 +00:00
moneromooo-monero
c25260f51c
protocol: fix incorrect tx hash in log
2018-11-20 18:35:58 +00:00
naughtyfox
6732fc7fde
Fix issue 4793 - M/N multisig transaction signature
2018-11-20 16:50:41 +03:00
moneromooo-monero
b9b307d11a
rpc: speedup get_output_distribution
...
and decrease the amount of data carried around
2018-11-20 10:11:25 +00:00
Riccardo Spagni
84dd674cd0
Merge pull request #4781
...
2a48c2a2b39fdf8e
2018-11-20 12:34:41 +09:00
xiphon
fc99f177f3
lmdb: fix gcc 7.3.0 'implicit-fallthrough' warning
2018-11-19 22:36:10 +00:00
moneromooo-monero
60f36386e4
Avoid unnecessary temp block and copy ctor
...
block already has a default ctor, and the extra object
churn due to its innards (vectors, etc) is pointless.
2018-11-19 17:57:17 +00:00
moneromooo-monero
707c2f836b
Remove -Werror
...
It is an annoying piece of garbage
2018-11-17 13:15:03 +00:00
moneromooo-monero
31d80027b5
tests: add unit tests for get_output_distribution
2018-11-16 19:21:45 +00:00
Tadeas Moravec
3998a937e5
Enhance help text for print_ring.
2018-11-16 15:15:35 +00:00
Tadeas Moravec
3900fb779f
Enhance help text for incoming_transfers.
2018-11-16 14:53:31 +00:00
moneromooo-monero
0936dae8a4
blockchain: remove "0 is height" shortcut from get_output_distribution
...
This prevents asking for just 0, and the RPC layer already does this
2018-11-16 10:03:02 +00:00
moneromooo-monero
872c7eb26a
Revert "blockchain: simplify output distribution code"
...
This reverts commit b2bb9312a7
2018-11-16 10:02:59 +00:00
xiphon
2a48c2a286
slow-hash: some more big endian fixes
2018-11-16 09:58:41 +00:00
moneromooo-monero
b39fdf8ebe
slow-hash: fix for big endian
2018-11-16 09:58:38 +00:00
Riccardo Spagni
c37c70f459
Merge pull request #4806
...
ac23b10f3b14d972
2018-11-16 11:16:49 +02:00
Riccardo Spagni
0295055bcb
Merge pull request #4805
...
6a1062f5
2018-11-16 11:16:12 +02:00
Riccardo Spagni
cec336ecbc
Merge pull request #4804
...
00907c39
2018-11-16 11:15:56 +02:00
Riccardo Spagni
056abf980e
Merge pull request #4801
...
7ae36e91
2018-11-16 11:13:09 +02:00
Riccardo Spagni
3a40d94998
Merge pull request #4800
...
79b4dae6
2018-11-16 11:12:43 +02:00
Riccardo Spagni
45f597c564
Merge pull request #4799
...
f4988454
2018-11-16 11:12:09 +02:00
Riccardo Spagni
46f989bc49
Merge pull request #4795
...
5d7c2316
2018-11-16 11:11:10 +02:00
Riccardo Spagni
f9c60736b8
Merge pull request #4794
...
e198b06e
2018-11-16 11:10:20 +02:00
Riccardo Spagni
40bb7a304a
Merge pull request #4792
...
5d4f3df8
2018-11-16 11:09:41 +02:00
Riccardo Spagni
86395e5bd6
Merge pull request #4791
...
5878fe95
2018-11-16 11:08:34 +02:00
Riccardo Spagni
9aff9a5372
Merge pull request #4790
...
177a9d76
2018-11-16 11:08:07 +02:00
Riccardo Spagni
20bf9b93dd
Merge pull request #4789
...
0afdb00b
2018-11-16 11:07:40 +02:00
Riccardo Spagni
c8cc65f30a
Merge pull request #4788
...
8f3963d2
2018-11-16 11:07:21 +02:00
Riccardo Spagni
279a0a4d8a
Merge pull request #4786
...
c22e85fe
2018-11-16 11:06:32 +02:00
Riccardo Spagni
4561119846
Merge pull request #4784
...
1c04c21d
2018-11-16 11:05:31 +02:00
Riccardo Spagni
140defd89f
Merge pull request #4778
...
71eb32a9
2018-11-16 11:02:28 +02:00
Riccardo Spagni
b1ba96e159
Merge pull request #4777
...
c17a1d43
2018-11-16 11:01:33 +02:00
Riccardo Spagni
46d0dc2808
Merge pull request #4776
...
03fc731b14a5c206
2018-11-16 11:01:19 +02:00
Riccardo Spagni
d7bac99f6f
Merge pull request #4770
...
2bd46065
2018-11-16 10:59:38 +02:00
Riccardo Spagni
9827958f5e
Merge pull request #4768
...
cf552c75
2018-11-16 10:59:25 +02:00
Riccardo Spagni
e90ee7548c
Merge pull request #4765
...
09dbd9cb
2018-11-16 10:58:42 +02:00
Riccardo Spagni
95d96d139d
Merge pull request #4764
...
1598f01c
2018-11-16 10:58:29 +02:00
Riccardo Spagni
1910aab5f4
Merge pull request #4236
...
a9357141
2018-11-16 10:57:43 +02:00
doy-lee
6f2497bc7a
Don't cache nettype in core_rpc_server use m_core
...
This can go out of sync with m_core's nettype if you run in fakechain
mode since entering fakechain mode is done through code not the command
line and core_rpc_server only looks at the command line to figure out
the nettype.
2018-11-16 15:32:05 +11:00
moneromooo-monero
c5ee14ae6e
json_archive: initialize inner_array_size in ctor
...
Coverity 136581
2018-11-15 16:33:51 +00:00
Martijn Otto
bd98e99c80
Removed a lot of unnecessary includes
2018-11-15 17:29:34 +01:00
moneromooo-monero
2b3595d0fe
various: do not propagate exception through dtor
...
Coverity 189689, 189690, 189692, 189695
2018-11-15 15:53:21 +00:00
stoffu
79b4dae66f
simplewallet: slightly adjust wording when printing multisig seed
2018-11-15 23:51:19 +09:00
Riccardo Spagni
0cc3fc3756
Merge pull request #4769
...
5808530f1426209a6f7a5fd499fbe100bf31447e4f005a77593ef5986ecc99ad00cc1a16
2018-11-14 21:35:03 +02:00
Riccardo Spagni
33ad6fb4c1
Merge pull request #4761
...
6e1282b6
2018-11-14 21:34:51 +02:00
Riccardo Spagni
92c5a892b5
Merge pull request #4757
...
db24a2e5
2018-11-14 21:34:09 +02:00
Riccardo Spagni
8ba3f89b44
Merge pull request #4755
...
42d8d508
2018-11-14 21:33:38 +02:00
Riccardo Spagni
59e8a4c306
Merge pull request #4753
...
157054b82362baf7d9400f69cbe0122b
2018-11-14 21:33:02 +02:00
Riccardo Spagni
23fc891555
Merge pull request #4750
...
e61062b6
2018-11-14 21:32:21 +02:00
Riccardo Spagni
ff347c98a1
Merge pull request #4747
...
dad5bbfd
2018-11-14 21:32:10 +02:00
Riccardo Spagni
dd42b642ee
Merge pull request #4746
...
f3019efe
2018-11-14 21:31:08 +02:00
Riccardo Spagni
2312aacf18
Merge pull request #4847
...
6d3311acf0459abb
2018-11-14 21:30:19 +02:00
stoffu
f0459abbb9
cmake: move Boost_LOCALE_LIBRARY out of ICU_LIBRARIES
2018-11-15 00:18:31 +09:00
xiphon
d01bdaca12
common: fix base58 gcc -Werror=implicit-fallthrough
2018-11-13 12:15:18 +00:00
sachaaaaa
a93571410e
Add new command "export_transfers" to save transfers to csv
2018-11-12 12:03:11 +11:00
