j-berman
564a7a31e8
multisig: fix #8537 seed restore (suggestions by @UkoeHB)
...
- spend secret key is no longer the sum of multisig key shares;
no need to check that is the case upon restore.
- restoring a multisig wallet from multisig info means that the
wallet must have already completed all setup rounds. Upon restore,
set the number of rounds completed accordingly.
2022-09-06 11:59:25 -06:00
moneromooo-monero
959a3e627f
wallet2: ensure imported outputs subaddresses are created
...
reported by j-berman
2022-08-24 13:52:36 +00:00
luigi1111
4e42d6c69d
Merge pull request #8490
...
f8d76ec
version: bump master version number (selsta)
2022-08-22 22:50:47 -05:00
luigi1111
f46f16467a
Merge pull request #8486
...
6b61628
dns_util: remove outdated DNSSEC DS trust anchor (selsta)
2022-08-22 22:50:20 -05:00
luigi1111
ab63fbc549
Merge pull request #8465
...
04a1e28
ledger support for hf 15 (BP+, view tags) (j-berman)
2022-08-22 22:49:47 -05:00
luigi1111
386032dad9
Merge pull request #8462
...
f7f1445
device: set ledger min app version (selsta)
2022-08-22 22:49:07 -05:00
luigi1111
77053298ed
Merge pull request #8450
...
600de07
wallet_rpc_server: longer timeout for stop_mining (moneromooo-monero)
ac6db92
functional_tests: silence the cpu power test program (moneromooo-monero)
2022-08-22 22:47:45 -05:00
luigi1111
53a8cf7f8c
Merge pull request #8428
...
7a31d25
keccak: error out if passed mdlen 100 (moneromooo-monero)
2022-08-22 22:45:59 -05:00
luigi1111
ce80747c58
Merge pull request #8427
...
1fc60ca
Publish submitted txs via zmq (j-berman)
2022-08-22 22:45:14 -05:00
luigi1111
645d752b19
Merge pull request #8415
...
628fdcd
continue pool pruning even if a tx can't be found (j-berman)
2022-08-22 22:44:04 -05:00
luigi1111
3c78f4d3d4
Merge pull request #8381
...
f797655
Fixed get_block_template_backlog performance (SChernykh)
2022-08-22 22:43:12 -05:00
luigi1111
2056ef78a0
Merge pull request #8379
...
4a4936b
Fix use of rtxn without a mdb_txn_safe wrapper (Howard Chu)
2022-08-22 22:41:08 -05:00
luigi1111
df02b56289
Merge pull request #8359
...
4d7f6f5
GCC: fix some unused warnings (Jeffrey Ryan)
2022-08-22 22:40:09 -05:00
luigi1111
080fc69435
Merge pull request #8299
...
a0df140
feat(trezor): add HF15 support, BP+ (Dusan Klinec)
2022-08-22 22:37:08 -05:00
SerHack
09d69b6946
rpc: remove overwriting value
2022-08-22 10:34:50 +02:00
SerHack
e988530e01
Remove redundant check
2022-08-22 10:19:12 +02:00
SerHack
501db2cedb
Wallet RPC: remove duplicate line
2022-08-21 10:52:33 +02:00
Crypto City
6f0fb76025
blockchain: fix invalid memory read getting fee on empty chain
2022-08-19 14:39:27 +00:00
moneromooo-monero
a0985044d9
wallet2: better test on whether to allow output import
...
Being offline is not a good enough heuristic, so we keep track
of whether the wallet ever refreshed from a daemon, which is a
lot better, and probably the best we can do without manual user
designation (which would break existing cold wallet setups till
the user designates those wallets)
2022-08-18 19:29:03 +00:00
moneromooo-monero
c5579ac236
allow exporting outputs in chunks
...
this will make it easier huge wallets to do so without hitting
random limits (eg, max string size in node).
2022-08-18 06:53:41 +00:00
j-berman
1e912ecd8a
wallet2: fixes for export/import output flow
...
- only allow offline wallets to import outputs
- don't import empty outputs
- export subaddress indexes when exporting outputs
2022-08-16 14:22:42 +00:00
moneromooo-monero
692f1d4e3d
wallet2: do not assume imported outputs must be non empty
2022-08-16 14:22:33 +00:00
moneromooo-monero
67b6d6ae2c
wallet2: prevent importing outputs in a hot wallet
2022-08-16 14:22:33 +00:00
moneromooo-monero
d9fc666db8
wallet2: fix missing subaddress indices in "light" exported outputs
2022-08-16 14:22:24 +00:00
moneromooo-monero
d06202dcc0
blockchain_prune: faster
...
on my anecdotal SSD, goes from about 9 hours to 1h20.
2022-08-15 16:16:18 +00:00
selsta
f8d76ecb57
version: bump master version number
...
Otherwise Ledger rejects the wallet.
2022-08-09 03:37:27 +02:00
j-berman
04a1e2875d
ledger support for hf 15 (BP+, view tags)
2022-08-06 15:00:49 -07:00
selsta
6b61628881
dns_util: remove outdated DNSSEC DS trust anchor
2022-08-06 19:46:53 +02:00
SChernykh
f79765579c
Fixed get_block_template_backlog performance
...
Before the fix, it processed all transactions in the mempool which could be very slow when mempool grows to several MBs in size. I observed `get_block_template_backlog` taking up to 15 seconds of CPU time under high mempool load.
After the fix, only transactions that can potentially be mined in the next block will be processed (a bit more than the current block median weight).
2022-07-26 07:21:21 +02:00
selsta
f7f14459f5
device: set ledger min app version
2022-07-24 21:01:22 +02:00
j-berman
1fc60cac58
Publish submitted txs via zmq
2022-07-21 11:36:00 -07:00
moneromooo-monero
600de07bcf
wallet_rpc_server: longer timeout for stop_mining
...
That RPC will wait for mining to actually stop, which can be a while
if randomx has just started on randomx_init_dataset.
This fixes occasional failures in the mining functional test
2022-07-21 12:00:05 +00:00
Howard Chu
4a4936b8af
Fix use of rtxn without a mdb_txn_safe wrapper
2022-07-20 20:58:03 +01:00
luigi1111
f982163fc9
Merge pull request #8425
...
fe5d1be
build: prepare v0.18.0.0 (selsta)
2022-07-15 11:23:54 -04:00
luigi1111
4792ceefb1
Merge pull request #8414
...
2ba391f
hardforks: set mainnet and stagenet v15/16 fork height (selsta)
2022-07-15 11:22:01 -04:00
luigi1111
070c3d6b0f
Merge pull request #8433
...
db8181a
wallet2: force using output distribution for ringct outs (tobtoht)
2022-07-14 22:15:27 -04:00
luigi1111
02cbccc529
Merge pull request #8432
...
edcc094
derive multisig tx secret keys from an entropy source plus the tx inputs' key images (koe)
2022-07-14 22:14:41 -04:00
luigi1111
d912444a4a
Merge pull request #7986
...
5770265
wallet2: keep around transaction prefix for confirmed transfers (tobtoht)
2022-07-14 12:54:39 -04:00
selsta
fe5d1bef56
build: prepare v0.18.0.0
2022-07-13 22:07:31 +02:00
koe
edcc094558
derive multisig tx secret keys from an entropy source plus the tx inputs' key images
2022-07-13 12:40:34 -05:00
luigi1111
cfdee9ba69
Merge pull request #8421
...
bd1e7c5
wallet2: prevent crash when reading tx w/fewer outputs than expected (j-berman)
2022-07-13 00:39:54 -04:00
luigi1111
6fed8c2d9f
Merge pull request #8149
...
c7b2944
multisig: fix critical vulnerabilities in signing (anon)
2022-07-13 00:38:29 -04:00
Jeffrey Ryan
4d7f6f5cd5
GCC: fix some unused warnings
...
hash_extra: don't test for success in `jh_hash` and `skein_hash` since its guaranteed
device_ledger: move anonymous global variable apdu_verbose into .cpp file
Add comments to `refreshed` method variable in wallet2
2022-07-11 20:32:03 -05:00
moneromooo-monero
7a31d25b67
keccak: error out if passed mdlen 100
...
If we were to call it with 100, it would cause rsiz to be 0,
leading to an infinite loop.
This is really a pedantic patch, but since there's already a
range test, might as well make it better.
2022-07-11 17:43:59 +00:00
luigi1111
4476c35fc8
Merge pull request #8408
...
09a597b
wallet2: don't use DNS to obtain segregation heights (tobtoht)
2022-07-06 00:01:59 -05:00
luigi1111
cea2498e95
Merge pull request #8404
...
50ccc7e
wallet2: remove obsolete rpc version check (tobtoht)
2022-07-06 00:01:29 -05:00
luigi1111
7a118f08f4
Merge pull request #8394
...
4278a3a
cryptonote_basic: catch crypto api errors (moneromooo-monero)
2022-07-06 00:00:24 -05:00
luigi1111
5a3c77be18
Merge pull request #8391
...
41b1a6b
simplewallet: print usage when given no args (hinto.janaiyo)
2022-07-05 23:59:59 -05:00
luigi1111
45a44aa45f
Merge pull request #8388
...
04c0da2
Chunk /gettransactions to avoid hitting restricted RPC limit (tobtoht)
2022-07-05 23:58:46 -05:00
luigi1111
969316685b
Merge pull request #8371
...
16f8e04
Remove erraneous commas (Luke Parker)
da0715e
Improve consistency between on_money_received and on_money_received_unconfirmed (Luke Parker)
2022-07-05 23:58:06 -05:00
j-berman
bd1e7c5635
wallet2: prevent crash when reading tx w/fewer outputs than expected
2022-07-05 21:39:59 -07:00
luigi1111
b54d5ae383
Merge pull request #8384
...
8460fcc
Revert 'Merge pull request #7937 ' (j-berman)
2022-07-03 17:29:46 -05:00
luigi1111
82cde936c3
Merge pull request #8356
...
de2f0d0
wallet_api: add scanTransactions function (selsta)
2022-07-03 17:26:35 -05:00
luigi1111
30a9183091
Merge pull request #7774
...
ade464a
ITS#9385 fix using MDB_NOSUBDIR with nonexistent file (Kris Zyp)
033a32a
Remove check is_directory check on lmdb path (Howard Chu)
b096e16
Revert 'db_lmdb: test for mmap support at init time' (Howard Chu)
493577a
Silence spurious fallthru warning (Howard Chu)
b46a60e
Fix rawpart flag collision (Howard Chu)
4e7586c
More RAWPART support (Howard Chu)
747f5d3
Preliminary raw partition support (Howard Chu)
2022-07-03 17:24:47 -05:00
j-berman
628fdcdd49
continue pool pruning even if a tx can't be found
2022-07-01 09:44:58 -07:00
selsta
2ba391f02c
hardforks: set mainnet and stagenet v15/16 fork height
2022-07-01 01:49:59 +02:00
anon
c7b2944f89
multisig: fix critical vulnerabilities in signing
2022-06-30 12:56:40 -05:00
tobtoht
09a597ba28
wallet2: don't use DNS to obtain segregation heights
2022-06-28 23:12:03 +02:00
tobtoht
04c0da2986
Chunk /gettransactions to avoid hitting restricted RPC limit
2022-06-27 21:23:56 +02:00
tobtoht
db8181adf8
wallet2: force using output distribution for ringct outs
...
Co-authored-by: j-berman <justinberman@protonmail.com>
2022-06-25 13:06:11 +02:00
tobtoht
50ccc7e726
wallet2: remove obsolete rpc version check
2022-06-24 21:58:07 +02:00
moneromooo-monero
4278a3a7e3
cryptonote_basic: catch crypto api errors
2022-06-20 22:17:57 +00:00
Dusan Klinec
a0df140fd6
feat(trezor): add HF15 support, BP+
...
- BP+ support added for Trezor
- old Trezor firmware version support removed, code cleanup
2022-06-20 19:42:56 +02:00
hinto.janaiyo
41b1a6b0dd
simplewallet: print usage when given no args
2022-06-20 08:15:07 -04:00
j-berman
8460fcc32b
Revert "Merge pull request #7937 "
...
This reverts commit 50410d1f7d
, reversing
changes made to d054def63f
.
2022-06-13 18:44:09 +01:00
Howard Chu
033a32a20b
Remove check is_directory check on lmdb path
...
The check interferes with raw device/partition support.
2022-06-03 16:46:47 +01:00
Howard Chu
b096e16699
Revert "db_lmdb: test for mmap support at init time"
...
This reverts commit bd96536637
.
The check interferes with raw device/partition support.
2022-06-03 16:46:35 +01:00
moneromooo-monero
23fde151ee
wallet_rpc_server: chunk refresh to keep responding to RPC while refreshing
2022-06-03 07:15:15 +00:00
Luke Parker
16f8e042b5
Remove erraneous commas
2022-06-01 19:38:42 -04:00
Luke Parker
da0715e503
Improve consistency between on_money_received and on_money_received_unconfirmed
...
unconfirmed solely uses a - b, and received now accepts b so it can
provide more detailed logs on what occurred (printing a - b, yet with a
and b).
2022-06-01 18:20:11 -04:00
luigi1111
9750e1fa10
Merge pull request #8340
...
08080df
unit_tests: add more sha256sum test cases (Jeffrey Ryan)
a66a52d
common: update sha256sum to use OpenSSL 3.0 API (Jeffrey Ryan)
2022-05-26 21:26:42 -05:00
luigi1111
e8252ef99b
Merge pull request #8337
...
1164874
src, epee: fix a couple compiler warnings (selsta)
2022-05-26 21:25:06 -05:00
luigi1111
1ff2b02064
Merge pull request #8331
...
fde7c96
wallet2: fix spurious reorg detection with untrusted nodes (moneromooo-monero)
2022-05-26 21:24:38 -05:00
luigi1111
f9d789d68c
Merge pull request #8330
...
2dab31f
Don't exclusively drop tor/i2p outgoing cxns in idle loop (j-berman)
2022-05-26 21:23:38 -05:00
luigi1111
f96cf86532
Merge pull request #8328
...
2979474
disable multisig by default (moneromooo-monero)
2022-05-26 21:22:52 -05:00
luigi1111
d52b7d0e99
Merge pull request #8326
...
b9d2c78
fix backoff delay logic when re-relaying txs (j-berman)
2022-05-26 21:21:18 -05:00
luigi1111
7f2f7ce404
Merge pull request #8324
...
bae4a1a
Don't send peerlist larger than max allowed (j-berman)
2022-05-26 21:20:23 -05:00
selsta
de2f0d0102
wallet_api: add scanTransactions function
2022-05-26 03:51:31 +02:00
moneromooo-monero
5bb2369b55
wallet_rpc_server: add --no-initial-sync flag for quicker network binding
2022-05-25 09:02:27 +00:00
Jeffrey Ryan
a4cb77f9f3
epee: update 'http_server_handlers_map2.h' macros to use fully qualified names
...
quick patch which fixes the issue where if you use some macros from `http_server_handlers_map2.h` you have to be in the `epee` namespace or it doesn't compile. Now can remove `using namespace epee;` from header file `core_rpc_server.h`, which caused a couple of name qualifying mistakes
2022-05-23 14:46:36 -05:00
j-berman
2dab31f62f
Don't exclusively drop tor/i2p outgoing cxns in idle loop
2022-05-18 09:54:21 -07:00
Jeffrey Ryan
a66a52d144
common: update sha256sum to use OpenSSL 3.0 API
...
As of OpenSSL 3.0, `SHA256_Init`, `SHA256_Update`, and `SHA256_Final`
are deprectaed in favor of the higher-level `EVP_*` class of functions.
This causes compiler warnings, and sooner or later, will cause build
errors as these functions are excluded from distro headers.
Also add some documentation.
2022-05-18 01:34:16 +02:00
moneromooo-monero
2979474221
disable multisig by default
...
There are vulnerabilities in multisig protocol if the parties do not
trust each other, and while there is a patch for it, it has not been
throroughly reviewed yet, so it is felt safer to disable multisig by
default for now.
If all parties in a multisig setup trust each other, then it is safe
to enable multisig.
2022-05-17 19:52:03 +00:00
selsta
1164874afc
src, epee: fix a couple compiler warnings
2022-05-17 00:33:10 +02:00
luigi1111
6e60919e6d
Merge pull request #8315
...
1ddb1ee
Give better error messages when missing SSL files (Jeffrey Ryan)
2022-05-16 13:53:16 -05:00
luigi1111
5b9724b03d
Merge pull request #8308
...
f63f7dc
wallet2: fix a couple unused variable warnings (selsta)
2022-05-16 13:51:18 -05:00
luigi1111
3d1e5db44d
Merge pull request #8307
...
b7978cf
Remove src/serialization/list.h (Jeffrey)
2022-05-16 13:50:52 -05:00
moneromooo-monero
fde7c96b5c
wallet2: fix spurious reorg detection with untrusted nodes
...
When forced to deal with an untrusted node, a wallet will quantize
its current height to disguise the real height to the adversary, to
try and minimize the daemon's ability to distinguish returning
wallets.
Daemons will thus return more blocks than the wallet needs, starting
from earlier in the chain. These extra blocks will be disregarded
by the wallet, which had already scanned them.
However, for the purposes of reorg size detection, the wallet assumes
all blocks the daemon sends are different, which is only correct if
the wallet hasn't been coy, which is only the case for trusted
daemons (which you should use). This causes an issue when the size
of this "fake reorg" is above the sanity check threshold at which
the wallet refuses a reorg.
To fix this, the reorg size check is moved later on, when the reorg
is about to actually happen, after the wallet has checked which
blocks are actually different from the ones it expects.
2022-05-15 11:57:37 +00:00
moneromooo-monero
df2e680825
wallet2: speedup large tx construction: reserve vector memory
...
2.8 seconds -> 2.6 seconds on a test case
2022-05-13 17:43:22 +00:00
Crypto City
38cdf01c64
wallet2: speedup large tx construction: batch ringdb lookups
...
3.3 seconds -> 2.8 seconds on a test case
2022-05-13 17:43:22 +00:00
Crypto City
353cd5355e
wallet2: speedup large tx construction: no pointless clsag generation
...
4.1 seconds -> 3.3 seconds on a test case
2022-05-13 17:43:21 +00:00
Crypto City
2b95178897
wallet2: speedup large tx construction: batch ringdb updates
...
5.2 seconds -> 4.1 seconds on a test case
2022-05-13 17:43:20 +00:00
moneromooo-monero
c9cf0b78f8
wallet2: speedup large tx construction: cache public key validity
...
5.9 second -> 5.2 seconds on a test case
2022-05-13 17:43:16 +00:00
j-berman
b9d2c788bc
fix backoff delay logic when re-relaying txs
2022-05-12 08:39:51 -07:00
j-berman
bae4a1ad8f
Don't send peerlist larger than max allowed
2022-05-11 18:41:24 -07:00
luigi1111
8349cfe4a6
Merge pull request #8321
...
7d6c748
Set hf v15 testnet fork heights (j-berman)
2022-05-10 16:57:53 -05:00
luigi1111
d58ea37a8d
Merge pull request #8302
...
41da2fe
Update copyright to 2022 for Hardfork files (Akrit)
2022-05-10 16:56:39 -05:00
luigi1111
8480575cec
Merge pull request #8300
...
070e41d
Change Github to GitHub (Abdullah)
2022-05-10 16:53:48 -05:00
luigi1111
fbd1f1e476
Merge pull request #8293
...
4f08bcd
refactor(bp+): save one inversion, use sc_muladd (Dusan Klinec)
2022-05-10 16:51:59 -05:00
luigi1111
436ca13722
Merge pull request #8277
...
baee2c0
Preserve commitment format inside transactions (kayabaNerve)
2022-05-10 16:49:13 -05:00